From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id D8703A0527; Mon, 9 Nov 2020 17:04:24 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B42AA6004; Mon, 9 Nov 2020 17:04:23 +0100 (CET) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 3CDFF5AB8 for ; Mon, 9 Nov 2020 17:04:21 +0100 (CET) IronPort-SDR: qDD20Zp52U5T7N2GDU5/q/yIckRadVHmP1+WPWrEhVKvNf0CF4y5U6D5Zu1sosX5xAupyTdJCo d3VvQmu3M4tg== X-IronPort-AV: E=McAfee;i="6000,8403,9800"; a="166315308" X-IronPort-AV: E=Sophos;i="5.77,463,1596524400"; d="scan'208";a="166315308" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Nov 2020 08:03:47 -0800 IronPort-SDR: lSh5Ntld1Cmw3xarNdxqlJ85SJMBxuIznMcu5jnH8LoO6vpR1l6+fImE8izIqkMvdCwKbLEA0W peGSu+4TDfQQ== X-IronPort-AV: E=Sophos;i="5.77,463,1596524400"; d="scan'208";a="540904112" Received: from bricha3-mobl.ger.corp.intel.com ([10.214.194.11]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 09 Nov 2020 08:03:44 -0800 Date: Mon, 9 Nov 2020 16:03:39 +0000 From: Bruce Richardson To: Stephen Hemminger , thomas@monjalon.net, david.marchand@redhat.com Cc: dev@dpdk.org, Luca Boccassi , Gaetan Rivet Message-ID: <20201109160339.GI831@bricha3-MOBL.ger.corp.intel.com> References: <20200922143202.8755-1-stephen@networkplumber.org> <20201105223602.5965-1-stephen@networkplumber.org> <20201105223602.5965-2-stephen@networkplumber.org> <20201109134931.GG831@bricha3-MOBL.ger.corp.intel.com> <20201109075440.44130509@hermes.local> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201109075440.44130509@hermes.local> Subject: Re: [dpdk-dev] [PATCH v9 1/6] eal: replace usage of blacklist/whitelist in enum X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, Nov 09, 2020 at 07:54:40AM -0800, Stephen Hemminger wrote: > On Mon, 9 Nov 2020 13:49:31 +0000 > Bruce Richardson wrote: > > > On Thu, Nov 05, 2020 at 02:35:57PM -0800, Stephen Hemminger wrote: > > > This patch renames the enum values in the EAL include files. > > > As a backward compatible temporary migration tool, define > > > a replacement mapping for old values. > > > > > > The old names relating to blacklist and whitelist are replaced > > > by block list and allow list, but applications may be using the > > > older compatibility macros. To help with conversion to new names > > > cause a message when the compatibility names are used. > > > > > > Signed-off-by: Stephen Hemminger > > > Acked-by: Luca Boccassi > > > Acked-by: Gaetan Rivet > > > --- > > > lib/librte_eal/common/eal_common_devargs.c | 14 +++++++------- > > > lib/librte_eal/include/rte_bus.h | 10 ++++++++-- > > > lib/librte_eal/include/rte_dev.h | 10 ++++++++-- > > > lib/librte_eal/include/rte_devargs.h | 10 ++++++++-- > > > 4 files changed, 31 insertions(+), 13 deletions(-) > > > > > > > > +/* Backwards compatibility will be removed later */ > > > +#define RTE_DEVTYPE_WHITELISTED_PCI \ > > > + RTE_DEPRECATED(RTE_DEVTYPE_WHITELISTED_PCI) RTE_DEVTYPE_ALLOWED > > > +#define RTE_DEVTYPE_BLACKLISTED_PCI \ > > > + RTE_DEPRECATED(RTE_DEVTYPE_BLACKLISTED_PCI) RTE_DEVTYPE_BLOCKED > > > + > > > > This patch causes build failures which persist until patch 3, because of > > these deprecations. I think you need to define the backward-compatibility > > macros here, but only mark them deprecated at the end of the set. > > > > /Bruce > > Is building without warnings in every step that important? > The previous patch series for master/slave had the same effect > I assumed it was necessary, but maybe I'm mistaken. Thomas, David, your feedback please? We really could do with getting this patchset into the LTS release! /Bruce