From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id A73D4A0527; Mon, 9 Nov 2020 19:02:29 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 8F341697B; Mon, 9 Nov 2020 19:02:28 +0100 (CET) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id 1A1746947 for ; Mon, 9 Nov 2020 19:02:25 +0100 (CET) IronPort-SDR: CqSko0qgXMpBYie3EEGa8mWC4LymVzM1fkCb69M6eLOjav0EwrIgMI86XXdk4g0SY6249PdCPR Cn4Z6Qh3X+yg== X-IronPort-AV: E=McAfee;i="6000,8403,9800"; a="231475366" X-IronPort-AV: E=Sophos;i="5.77,464,1596524400"; d="scan'208";a="231475366" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Nov 2020 10:02:24 -0800 IronPort-SDR: 89wi8zn0EoxcHongq7ZU7KVn7J4bSQOs4vZX5AdUFQDoh3dVBlYNDMXTpYcWtMMURfO+Es2Wpn iTPpxTlVcTVQ== X-IronPort-AV: E=Sophos;i="5.77,464,1596524400"; d="scan'208";a="473072100" Received: from bricha3-mobl.ger.corp.intel.com ([10.214.194.11]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 09 Nov 2020 10:02:22 -0800 Date: Mon, 9 Nov 2020 18:02:16 +0000 From: Bruce Richardson To: Thomas Monjalon Cc: dev@dpdk.org, david.marchand@redhat.com Message-ID: <20201109180216.GM831@bricha3-MOBL.ger.corp.intel.com> References: <20201027173836.891184-1-bruce.richardson@intel.com> <3123472.p7xLvF2YS7@thomas> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3123472.p7xLvF2YS7@thomas> Subject: Re: [dpdk-dev] [PATCH] devtools/test-meson-builds: allow custom set of examples X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, Nov 09, 2020 at 06:09:51PM +0100, Thomas Monjalon wrote: > 27/10/2020 18:38, Bruce Richardson: > > To test the installation process of DPDK using "ninja install" > > test-meson-builds.sh builds a subset of the examples using "make". To allow > > more flexibility for people testing, allow the set of examples chosen for > > this make test to be overridden using variable "DPDK_BUILD_TEST_EXAMPLES" > > in the environment. > > > > Since a number of example apps link against drivers directly even for > > shared builds, we need to ensure that LD_LIBRARY_PATH points to the main > > DPDK lib folder so any dependencies of those drivers can be found e.g. that > > the PCI/vdev bus driver .so is found. [All drivers are symlinked from > > drivers dir back to lib dir on install, so only one dir rather than two is > > needed in the path.] > [...] > > +libdir=$(dirname $(find $DESTDIR -name librte_eal.so)) > > +export LD_LIBRARY_PATH=$libdir:$LD_LIBRARY_PATH > > I don't get why libdir is required for some examples, > and not for others? The pkg-config file is not enough? > It's only needed for examples that link against drivers directly. I believe it's needed in those cases, because app linker flags (including e.g. -lrte_pmd_bond) occur before the pkg-config flags, which means that the linker at that point does not have the path to find the dependencies of the driver. [In a normal build, this wouldn't be necessary because the library directory would be a standard path] > > +examples_to_test=${DPDK_BUILD_TEST_EXAMPLES:-"cmdline helloworld l2fwd l3fwd skeleton timer"} > > It makes me think that we should rename TEST_MESON_BUILD_VERY_VERBOSE > to DPDK_BUILD_TEST_VERY_VERBOSE for consistency. > Sure.