From: Thomas Monjalon <thomas@monjalon.net>
To: dev@dpdk.org
Cc: david.marchand@redhat.com, ferruh.yigit@intel.com,
olivier.matz@6wind.com, mb@smartsharesystems.com,
konstantin.ananyev@intel.com, andrew.rybchenko@oktetlabs.ru,
viacheslavo@nvidia.com, ajit.khaparde@broadcom.com,
jerinj@marvell.com, hemant.agrawal@nxp.com,
Nithin Dabilpuram <ndabilpuram@marvell.com>,
Ankur Dwivedi <adwivedi@marvell.com>,
Anoob Joseph <anoobj@marvell.com>,
Pavan Nikhilesh <pbhagavatula@marvell.com>,
Kiran Kumar K <kirankumark@marvell.com>,
Guy Kaneti <guyk@marvell.com>
Subject: [dpdk-dev] [PATCH v2 1/2] drivers: disable OCTEON TX2 in 32-bit build
Date: Mon, 9 Nov 2020 22:29:36 +0100 [thread overview]
Message-ID: <20201109212937.989954-2-thomas@monjalon.net> (raw)
In-Reply-To: <20201109212937.989954-1-thomas@monjalon.net>
The drivers for OCTEON TX2 are not supported in 32-bit mode.
Suggested-by: Jerin Jacob <jerinj@marvell.com>
Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
---
drivers/common/octeontx2/meson.build | 18 ++++++------------
drivers/crypto/octeontx2/meson.build | 17 +++--------------
drivers/event/octeontx2/meson.build | 18 ++++++------------
drivers/mempool/octeontx2/meson.build | 18 ++++++------------
drivers/net/octeontx2/meson.build | 11 ++++++-----
drivers/regex/octeontx2/meson.build | 22 +++-------------------
6 files changed, 30 insertions(+), 74 deletions(-)
diff --git a/drivers/common/octeontx2/meson.build b/drivers/common/octeontx2/meson.build
index f2c04342e9..84fb11524d 100644
--- a/drivers/common/octeontx2/meson.build
+++ b/drivers/common/octeontx2/meson.build
@@ -2,6 +2,12 @@
# Copyright(C) 2019 Marvell International Ltd.
#
+if not dpdk_conf.get('RTE_ARCH_64')
+ build = false
+ reason = 'only supported on 64-bit'
+ subdir_done()
+endif
+
sources= files('otx2_dev.c',
'otx2_irq.c',
'otx2_mbox.c',
@@ -9,18 +15,6 @@ sources= files('otx2_dev.c',
'otx2_sec_idev.c',
)
-extra_flags = []
-# This integrated controller runs only on a arm64 machine, remove 32bit warnings
-if not dpdk_conf.get('RTE_ARCH_64')
- extra_flags += ['-Wno-int-to-pointer-cast', '-Wno-pointer-to-int-cast']
-endif
-
-foreach flag: extra_flags
- if cc.has_argument(flag)
- cflags += flag
- endif
-endforeach
-
deps = ['eal', 'pci', 'ethdev', 'kvargs']
includes += include_directories('../../common/octeontx2',
'../../mempool/octeontx2', '../../bus/pci')
diff --git a/drivers/crypto/octeontx2/meson.build b/drivers/crypto/octeontx2/meson.build
index 4e4522cace..0aad4e9a16 100644
--- a/drivers/crypto/octeontx2/meson.build
+++ b/drivers/crypto/octeontx2/meson.build
@@ -1,9 +1,10 @@
# SPDX-License-Identifier: BSD-3-Clause
# Copyright (C) 2019 Marvell International Ltd.
-if not is_linux
+if not is_linux or not dpdk_conf.get('RTE_ARCH_64')
build = false
- reason = 'only supported on Linux'
+ reason = 'only supported on 64-bit Linux'
+ subdir_done()
endif
deps += ['bus_pci']
@@ -21,18 +22,6 @@ sources = files('otx2_cryptodev.c',
'otx2_cryptodev_ops.c',
'otx2_cryptodev_sec.c')
-extra_flags = []
-# This integrated controller runs only on a arm64 machine, remove 32bit warnings
-if not dpdk_conf.get('RTE_ARCH_64')
- extra_flags += ['-Wno-int-to-pointer-cast', '-Wno-pointer-to-int-cast']
-endif
-
-foreach flag: extra_flags
- if cc.has_argument(flag)
- cflags += flag
- endif
-endforeach
-
includes += include_directories('../../common/cpt')
includes += include_directories('../../common/octeontx2')
includes += include_directories('../../crypto/octeontx2')
diff --git a/drivers/event/octeontx2/meson.build b/drivers/event/octeontx2/meson.build
index 724da2e6b7..22e7e4cb63 100644
--- a/drivers/event/octeontx2/meson.build
+++ b/drivers/event/octeontx2/meson.build
@@ -2,6 +2,12 @@
# Copyright(C) 2019 Marvell International Ltd.
#
+if not dpdk_conf.get('RTE_ARCH_64')
+ build = false
+ reason = 'only supported on 64-bit'
+ subdir_done()
+endif
+
sources = files('otx2_worker.c',
'otx2_worker_dual.c',
'otx2_evdev.c',
@@ -13,18 +19,6 @@ sources = files('otx2_worker.c',
'otx2_tim_worker.c'
)
-extra_flags = []
-# This integrated controller runs only on a arm64 machine, remove 32bit warnings
-if not dpdk_conf.get('RTE_ARCH_64')
- extra_flags += ['-Wno-int-to-pointer-cast', '-Wno-pointer-to-int-cast']
-endif
-
-foreach flag: extra_flags
- if cc.has_argument(flag)
- cflags += flag
- endif
-endforeach
-
deps += ['bus_pci', 'common_octeontx2', 'crypto_octeontx2', 'mempool_octeontx2', 'net_octeontx2']
includes += include_directories('../../crypto/octeontx2')
diff --git a/drivers/mempool/octeontx2/meson.build b/drivers/mempool/octeontx2/meson.build
index 0226f76d4b..0586321abe 100644
--- a/drivers/mempool/octeontx2/meson.build
+++ b/drivers/mempool/octeontx2/meson.build
@@ -5,6 +5,12 @@
if is_windows
build = false
reason = 'not supported on Windows'
+ subdir_done()
+endif
+if not dpdk_conf.get('RTE_ARCH_64')
+ build = false
+ reason = 'only supported on 64-bit'
+ subdir_done()
endif
sources = files('otx2_mempool_ops.c',
@@ -13,16 +19,4 @@ sources = files('otx2_mempool_ops.c',
'otx2_mempool_debug.c'
)
-extra_flags = []
-# This integrated controller runs only on a arm64 machine, remove 32bit warnings
-if not dpdk_conf.get('RTE_ARCH_64')
- extra_flags += ['-Wno-int-to-pointer-cast', '-Wno-pointer-to-int-cast']
-endif
-
-foreach flag: extra_flags
- if cc.has_argument(flag)
- cflags += flag
- endif
-endforeach
-
deps += ['eal', 'mbuf', 'kvargs', 'bus_pci', 'common_octeontx2', 'mempool']
diff --git a/drivers/net/octeontx2/meson.build b/drivers/net/octeontx2/meson.build
index 599ade6727..638c04a2fe 100644
--- a/drivers/net/octeontx2/meson.build
+++ b/drivers/net/octeontx2/meson.build
@@ -2,6 +2,12 @@
# Copyright(C) 2019 Marvell International Ltd.
#
+if not dpdk_conf.get('RTE_ARCH_64')
+ build = false
+ reason = 'only supported on 64-bit'
+ subdir_done()
+endif
+
sources = files('otx2_rx.c',
'otx2_tx.c',
'otx2_tm.c',
@@ -29,11 +35,6 @@ deps += ['bus_pci', 'cryptodev', 'eventdev', 'security']
deps += ['common_octeontx2', 'mempool_octeontx2']
extra_flags = ['-flax-vector-conversions']
-# This integrated controller runs only on a arm64 machine, remove 32bit warnings
-if not dpdk_conf.get('RTE_ARCH_64')
- extra_flags += ['-Wno-int-to-pointer-cast', '-Wno-pointer-to-int-cast']
-endif
-
foreach flag: extra_flags
if cc.has_argument(flag)
cflags += flag
diff --git a/drivers/regex/octeontx2/meson.build b/drivers/regex/octeontx2/meson.build
index aada0b5601..34e51728c2 100644
--- a/drivers/regex/octeontx2/meson.build
+++ b/drivers/regex/octeontx2/meson.build
@@ -2,9 +2,10 @@
# Copyright(C) 2020 Marvell International Ltd.
#
-if not is_linux
+if not is_linux or not dpdk_conf.get('RTE_ARCH_64')
build = false
- reason = 'only supported on Linux'
+ reason = 'only supported on 64-bit Linux'
+ subdir_done()
endif
lib = cc.find_library('librxp_compiler', required: false)
@@ -21,23 +22,6 @@ sources = files('otx2_regexdev.c',
'otx2_regexdev_compiler.c'
)
-extra_flags = []
-# This integrated controller runs only on a arm64 machine, remove 32bit warnings
-if not dpdk_conf.get('RTE_ARCH_64')
- extra_flags += ['-Wno-int-to-pointer-cast', '-Wno-pointer-to-int-cast']
-endif
-
-# for clang 32-bit compiles we need libatomic for 64-bit atomic ops
-if cc.get_id() == 'clang' and dpdk_conf.get('RTE_ARCH_64') == false
- ext_deps += cc.find_library('atomic')
-endif
-
-foreach flag: extra_flags
- if cc.has_argument(flag)
- cflags += flag
- endif
-endforeach
-
fmt_name = 'octeontx2_regex'
deps += ['bus_pci', 'common_octeontx2', 'regexdev']
--
2.28.0
next prev parent reply other threads:[~2020-11-09 21:30 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-07 15:53 [dpdk-dev] [PATCH 1/1] mbuf: move pool pointer in first half Thomas Monjalon
2020-11-07 17:12 ` Jerin Jacob
2020-11-07 18:39 ` Thomas Monjalon
2020-11-07 19:05 ` Jerin Jacob
2020-11-07 20:33 ` Thomas Monjalon
2020-11-09 5:18 ` Jerin Jacob
2020-11-09 8:04 ` Thomas Monjalon
2020-11-09 8:27 ` Jerin Jacob
2020-11-09 9:47 ` Bruce Richardson
2020-11-09 12:01 ` Jerin Jacob
2020-11-09 12:59 ` Thomas Monjalon
2020-11-09 13:35 ` Jerin Jacob
2020-11-09 14:02 ` Thomas Monjalon
2020-11-09 14:08 ` Jerin Jacob
2020-11-09 14:42 ` Thomas Monjalon
2020-11-09 14:53 ` Jerin Jacob
2020-11-09 8:16 ` Morten Brørup
2020-11-09 10:06 ` [dpdk-dev] [dpdk-techboard] " Bruce Richardson
2020-11-09 10:21 ` Morten Brørup
2020-11-09 18:04 ` Stephen Hemminger
2020-11-10 7:15 ` Morten Brørup
2020-11-07 18:57 ` [dpdk-dev] " Morten Brørup
2020-11-09 10:08 ` Bruce Richardson
2020-11-09 10:30 ` Morten Brørup
2020-11-09 10:33 ` Ananyev, Konstantin
2020-11-09 10:36 ` Bruce Richardson
2020-11-09 11:24 ` Ananyev, Konstantin
2020-11-09 21:29 ` [dpdk-dev] [PATCH v2 0/2] move mbuf pool pointer Thomas Monjalon
2020-11-09 21:29 ` Thomas Monjalon [this message]
2020-11-10 18:05 ` [dpdk-dev] [PATCH v2 1/2] drivers: disable OCTEON TX2 in 32-bit build Jerin Jacob
2020-11-09 21:29 ` [dpdk-dev] [PATCH v2 2/2] mbuf: move pool pointer in first half Thomas Monjalon
2020-11-10 10:05 ` Morten Brørup
2020-11-10 10:44 ` Thomas Monjalon
2020-11-10 16:25 ` Olivier Matz
2020-11-10 18:06 ` Jerin Jacob
2020-11-12 14:39 ` Thomas Monjalon
2020-11-10 18:08 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201109212937.989954-2-thomas@monjalon.net \
--to=thomas@monjalon.net \
--cc=adwivedi@marvell.com \
--cc=ajit.khaparde@broadcom.com \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=anoobj@marvell.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=guyk@marvell.com \
--cc=hemant.agrawal@nxp.com \
--cc=jerinj@marvell.com \
--cc=kirankumark@marvell.com \
--cc=konstantin.ananyev@intel.com \
--cc=mb@smartsharesystems.com \
--cc=ndabilpuram@marvell.com \
--cc=olivier.matz@6wind.com \
--cc=pbhagavatula@marvell.com \
--cc=viacheslavo@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).