From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id E54BDA09D3; Thu, 12 Nov 2020 12:38:37 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 9B2C75928; Thu, 12 Nov 2020 12:38:36 +0100 (CET) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id 47655493D for ; Thu, 12 Nov 2020 12:38:35 +0100 (CET) IronPort-SDR: 82U3qloMiyNzPgKlt2lxTcWZ8HCYItLonE13CdfAKhz+sSyRUnNs/uV5vgMAK3m2liIn+8r0ix 7CB2d/Cb/0aA== X-IronPort-AV: E=McAfee;i="6000,8403,9802"; a="158073083" X-IronPort-AV: E=Sophos;i="5.77,471,1596524400"; d="scan'208";a="158073083" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Nov 2020 03:38:32 -0800 IronPort-SDR: Tyti+tcWHnt2DedwYhyHbalp2QMHHjv5msQ98QXXx2BbbHotNyv+/P3mWlrvCaCoKx+71g5c1s d9FfowOMoUyA== X-IronPort-AV: E=Sophos;i="5.77,471,1596524400"; d="scan'208";a="542231116" Received: from bricha3-mobl.ger.corp.intel.com ([10.213.208.146]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 12 Nov 2020 03:38:30 -0800 Date: Thu, 12 Nov 2020 11:38:27 +0000 From: Bruce Richardson To: David Marchand Cc: dev , Thomas Monjalon Message-ID: <20201112113827.GG1309@bricha3-MOBL.ger.corp.intel.com> References: <20201110170809.1309043-1-bruce.richardson@intel.com> <20201112094142.1781861-1-bruce.richardson@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [dpdk-dev] [PATCH v4 0/4] improve examples installation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Nov 12, 2020 at 12:14:27PM +0100, David Marchand wrote: > On Thu, Nov 12, 2020 at 10:42 AM Bruce Richardson > wrote: > > > > This patch improves the installation of the examples when "ninja install" is > > run. It removes issues with the directory structure being flattened out, and > > removes from the install list any examples that are not buildable with built > > DPDK code. > > > > V4: resubmit v3 to retest in CI hopefully with proper patch tracking > > > > V3: fix issues with building on Windows > > > > V2: add support for filtering examples that won't build > > > > Bruce Richardson (4): > > examples: fix flattening directory layout on install > > examples/l2fwd-keepalive: skip build when no librt > > examples: stop processing build file if build is impossible > > examples: skip installing unbuildable examples > > Thanks Bruce. > This series looks good to me. > > My only comment is about vm_power_manager which won't build without > the internal librte_power header. > It builds fine with meson, because I guess meson pulls this library > directory into the include flags of the example, but it won't build > outside. > > We can skip it in devtools/test-meson-builds.sh but, on the other > hand, I would exclude it from installing until it is fixed (in a > future release). > Yes, good point. Rather than adding special logic for it, I think we just add it in the initialization of the exclusion array in patch 4, i.e. -dpdk_examples_exclude = []$ +dpdk_examples_exclude = ['vm_power_manager'] Can this be done on apply, or do you want a v5 for it? /Bruce