* [dpdk-dev] [PATCH] net/bnxt: fix incorrect assignment
@ 2020-11-12 15:29 Ajit Khaparde
2020-11-12 18:20 ` [dpdk-dev] [dpdk-stable] " Ferruh Yigit
0 siblings, 1 reply; 2+ messages in thread
From: Ajit Khaparde @ 2020-11-12 15:29 UTC (permalink / raw)
To: dev; +Cc: Mike Baucom, stable
From: Mike Baucom <michael.baucom@broadcom.com>
Use comparison operator instead of incorrectly using the assignment
operator.
Coverity issue: 363566
Coverity issue: 363577
Fixes: 42c40f8902f7 ("net/bnxt: consolidate template table processing")
Cc: stable@dpdk.org
Signed-off-by: Mike Baucom <michael.baucom@broadcom.com>
Reviewed-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
---
drivers/net/bnxt/tf_ulp/ulp_mapper.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/bnxt/tf_ulp/ulp_mapper.c b/drivers/net/bnxt/tf_ulp/ulp_mapper.c
index 29643232d8..429e7fcfee 100644
--- a/drivers/net/bnxt/tf_ulp/ulp_mapper.c
+++ b/drivers/net/bnxt/tf_ulp/ulp_mapper.c
@@ -2522,7 +2522,7 @@ ulp_mapper_tbls_process(struct bnxt_ulp_mapper_parms *parms, uint32_t tid)
tbls = ulp_mapper_tbl_list_get(parms, tid, &num_tbls);
if (!tbls || !num_tbls) {
BNXT_TF_DBG(ERR, "No %s tables for %d:%d\n",
- (parms->tmpl_type = BNXT_ULP_TEMPLATE_TYPE_CLASS) ?
+ (parms->tmpl_type == BNXT_ULP_TEMPLATE_TYPE_CLASS) ?
"class" : "action", parms->dev_id, tid);
return -EINVAL;
}
@@ -2569,7 +2569,7 @@ ulp_mapper_tbls_process(struct bnxt_ulp_mapper_parms *parms, uint32_t tid)
return rc;
error:
BNXT_TF_DBG(ERR, "%s tables failed creation for %d:%d\n",
- (parms->tmpl_type = BNXT_ULP_TEMPLATE_TYPE_CLASS) ?
+ (parms->tmpl_type == BNXT_ULP_TEMPLATE_TYPE_CLASS) ?
"class" : "action", parms->dev_id, tid);
return rc;
}
--
2.21.1 (Apple Git-122.3)
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [dpdk-dev] [dpdk-stable] [PATCH] net/bnxt: fix incorrect assignment
2020-11-12 15:29 [dpdk-dev] [PATCH] net/bnxt: fix incorrect assignment Ajit Khaparde
@ 2020-11-12 18:20 ` Ferruh Yigit
0 siblings, 0 replies; 2+ messages in thread
From: Ferruh Yigit @ 2020-11-12 18:20 UTC (permalink / raw)
To: Ajit Khaparde, dev; +Cc: Mike Baucom, stable
On 11/12/2020 3:29 PM, Ajit Khaparde wrote:
> From: Mike Baucom <michael.baucom@broadcom.com>
>
> Use comparison operator instead of incorrectly using the assignment
> operator.
>
> Coverity issue: 363566
> Coverity issue: 363577
> Fixes: 42c40f8902f7 ("net/bnxt: consolidate template table processing")
> Cc: stable@dpdk.org
>
> Signed-off-by: Mike Baucom <michael.baucom@broadcom.com>
> Reviewed-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
Applied to dpdk-next-net/main, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-11-12 18:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-12 15:29 [dpdk-dev] [PATCH] net/bnxt: fix incorrect assignment Ajit Khaparde
2020-11-12 18:20 ` [dpdk-dev] [dpdk-stable] " Ferruh Yigit
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).