From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id C42A7A0545; Fri, 13 Nov 2020 01:48:51 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 9D8645B30; Fri, 13 Nov 2020 01:48:27 +0100 (CET) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id A961456A3 for ; Fri, 13 Nov 2020 01:48:23 +0100 (CET) IronPort-SDR: bLxm66A0PC/w9T/yeC7xmZBm1dQbU1JqfDbmRz3ckrzuCJ9WP7Egk4G49Zvvj4uyXLor7dU369 nLWNWEd5hRJw== X-IronPort-AV: E=McAfee;i="6000,8403,9803"; a="158183654" X-IronPort-AV: E=Sophos;i="5.77,473,1596524400"; d="scan'208";a="158183654" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Nov 2020 16:48:22 -0800 IronPort-SDR: R5qyaFAAd1I8poMRv4G/ocz7YbxVB8CXR6CwwiVul65dN2WCdPktMilPm4+reol8T6P8UCPsJ+ 399fBBQ/ymUA== X-IronPort-AV: E=Sophos;i="5.77,473,1596524400"; d="scan'208";a="542465756" Received: from intel-npg-odc-srv01.cd.intel.com ([10.240.178.136]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Nov 2020 16:48:20 -0800 From: Steve Yang To: dev@dpdk.org Cc: qiming.yang@intel.com, beilei.xing@intel.com, jingjing.wu@intel.com, qi.z.zhang@intel.com, Steve Yang Date: Fri, 13 Nov 2020 00:46:42 +0000 Message-Id: <20201113004642.17115-3-stevex.yang@intel.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20201113004642.17115-1-stevex.yang@intel.com> References: <20201109065136.26807-1-stevex.yang@intel.com> <20201113004642.17115-1-stevex.yang@intel.com> Subject: [dpdk-dev] [PATCH v3 2/2] net/iavf: fix the RSS error when VF port closed X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Check the VF RSS offload flag and ignore relative operation when iavf hash uninit to avoid reset/close error. Fixes: 7be10c3004be ("net/iavf: add RSS configuration for VF") Signed-off-by: Steve Yang --- drivers/net/iavf/iavf_hash.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/net/iavf/iavf_hash.c b/drivers/net/iavf/iavf_hash.c index 8a5a6bb5a4..c4c73e6644 100644 --- a/drivers/net/iavf/iavf_hash.c +++ b/drivers/net/iavf/iavf_hash.c @@ -1093,6 +1093,12 @@ iavf_hash_uninit(struct iavf_adapter *ad) if (vf->vf_reset) return; + if (!vf->vf_res) + return; + + if (!(vf->vf_res->vf_cap_flags & VIRTCHNL_VF_OFFLOAD_ADV_RSS_PF)) + return; + if (iavf_hash_default_set(ad, false)) PMD_DRV_LOG(ERR, "fail to delete default RSS"); -- 2.17.1