From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3A442A0545; Fri, 13 Nov 2020 08:06:33 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 1CC3C5AB8; Fri, 13 Nov 2020 08:06:32 +0100 (CET) Received: from mail-lj1-f194.google.com (mail-lj1-f194.google.com [209.85.208.194]) by dpdk.org (Postfix) with ESMTP id 1E75D56A3 for ; Fri, 13 Nov 2020 08:06:31 +0100 (CET) Received: by mail-lj1-f194.google.com with SMTP id y16so9448515ljk.1 for ; Thu, 12 Nov 2020 23:06:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=t0/YcvxN/nHz3i8muhXwtV6yKCxs3QUt9IVc7xeSVtk=; b=W4OXugVxNHjp/bJt8PGURaDIdmWm71Jw4KQXz1Clk2c9Ov77bn7dJOwP7Ucw0sWTek Aw43ZgyqXOA5+1BypzSApAMs0VqB5iVpOrJSdyMqKBxnz62p8yzwuKbFk/RbFJ3oxL+i HwcTVioad5v2VTJkhmxDGXuuhvjkEW2SqxfXuALXj/90fLKRqKZbORvIVnf9i1elTTd9 QMgMpHS/63yUyZNLvTKiLT754HaMfsn9gT4aFMmJEMNHOTzljFiu/wW0rdwRHwNkf8zI e7NXW4lBNMcpf2ANfFGI1nhzrx8+u1G4cSL5faYpIOpGbuiSqdAgLA3yHm8F8/xaDxdn 6Jvg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=t0/YcvxN/nHz3i8muhXwtV6yKCxs3QUt9IVc7xeSVtk=; b=TlMpIQ44qN3lDgkSAASYmNvAkH4AjBcpOt1BH64EPomR28qVFYBe++unQmJfdg5QHk qo3Gs1qnVYs46tE6iwpYCurVU1e0pcVFLyUCq/c7+HRw9GB7vNV6pJdaM6np/cwgA9+H hM+ONwq5PE5fyFu40UH0c89KtcB7x71MbznGKjJ2xIvqeaADb5ETqnPRtPSMtGVEE/PC zYSm1NE8tIrU9EfDS12IiIa6F1TVoEfza3DOZyArYgKDJgrsBMqiRbhMvYHFxN+kCimw u1235s8OTJEfo8qX1fgcSnGGLoQXVyXHpyNxTb568sEd6CLf4BaGgXYC4zCyFVAJXYg1 YVzQ== X-Gm-Message-State: AOAM530XUzx8Asw10LjQIi18MxR15dMy+Wy6lrXIxHgeQtJncMgKI8Q8 EbNdMm8weVnXjwL9C3NqPyY= X-Google-Smtp-Source: ABdhPJzoc81KIIiyxiDnJ+rxYWaDiR1PXjgGNm7PAKWHaZLCrP/fFyX95M3ch/SkBaXuedOcK9OBlA== X-Received: by 2002:a2e:9189:: with SMTP id f9mr462526ljg.295.1605251189561; Thu, 12 Nov 2020 23:06:29 -0800 (PST) Received: from sovereign (broadband-37-110-65-23.ip.moscow.rt.ru. [37.110.65.23]) by smtp.gmail.com with ESMTPSA id u4sm1422515lfq.255.2020.11.12.23.06.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Nov 2020 23:06:28 -0800 (PST) Date: Fri, 13 Nov 2020 10:06:27 +0300 From: Dmitry Kozlyuk To: luca.boccassi@gmail.com Cc: dev@dpdk.org, thomas@monjalon.net, John Alexander , Luca Boccassi Message-ID: <20201113100627.569e346a@sovereign> In-Reply-To: <20201112201509.1002479-1-luca.boccassi@gmail.com> References: <20201029225505.30093-1-dmitry.kozliuk@gmail.com> <20201112201509.1002479-1-luca.boccassi@gmail.com> X-Mailer: Claws Mail 3.17.6 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [kmods PATCH v2] windows: normalize line-endings X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Luca, Thank you for taking the initiative. However, the patch fails to apply on my system, and that's the reason I've been delaying my own): $ git am \[kmods\ PATCH\ v2\]\ windows:\ normalize\ line-endings Applying: windows: normalize line-endings error: windows/virt2phys/virt2phys.sln: does not match index error: windows/virt2phys/virt2phys.vcxproj: does not match index error: patch failed: windows/virt2phys/virt2phys.vcxproj.filters:1 error: windows/virt2phys/virt2phys.vcxproj.filters: patch does not apply Patch failed at 0001 windows: normalize line-endings As far as I understand, this is caused by removed BOM: it exists in the repo, so it is included in the patch, but it's absent from checked-out files, so the patch fails to apply. Either there is some git option we're missing or only committer (i.e. Thomas) can do the conversion. It is correct to remove BOM. Note that \No newline at end of file will be restored by Visual Studio on save.