From: Bruce Richardson <bruce.richardson@intel.com>
To: Maxime Coquelin <maxime.coquelin@redhat.com>
Cc: dev@dpdk.org, yong.liu@intel.com, david.marchand@redhat.com,
stable@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] config: enable packet prefetching with Meson
Date: Fri, 13 Nov 2020 15:05:23 +0000 [thread overview]
Message-ID: <20201113150523.GA1441@bricha3-MOBL.ger.corp.intel.com> (raw)
In-Reply-To: <20201113145212.486443-1-maxime.coquelin@redhat.com>
On Fri, Nov 13, 2020 at 03:52:12PM +0100, Maxime Coquelin wrote:
> With Make build system, RTE_PMD_PACKET_PREFETCH was enabled
> by default. It got lost when transitioning to Meson build
> system.
>
> In order to avoid performance changes, this patch enables
> packet prefetching in rte_config.h.
>
> Reported-by: Marvin Liu <yong.liu@intel.com>
> Suggested-by: David Marchand <david.marchand@redhat.com>
> Signed-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>
> ---
>
> Hi Bruce,
>
> We were not sure whether adding below Fixes tag so that it is
> backported to LTSes. What do you think?
>
> Fixes: 9314afb68a53 ("drivers: add infrastructure for meson build")
> Cc: stable@dpdk.org
>
> config/rte_config.h | 3 +++
> 1 file changed, 3 insertions(+)
>
I view it as a gap in the transition from make to meson, so +1 for
adding these. Stable maintainers can then decide themselves on whether to
accept the patch or not.
/Bruce
next prev parent reply other threads:[~2020-11-13 15:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-13 14:52 Maxime Coquelin
2020-11-13 15:05 ` Bruce Richardson [this message]
2020-11-14 8:51 ` [dpdk-dev] [dpdk-stable] " Thomas Monjalon
2020-11-14 9:00 ` Thomas Monjalon
2020-11-14 10:54 ` David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201113150523.GA1441@bricha3-MOBL.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=maxime.coquelin@redhat.com \
--cc=stable@dpdk.org \
--cc=yong.liu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).