From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 27F54A09E0; Fri, 13 Nov 2020 16:05:38 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 4DB83C86E; Fri, 13 Nov 2020 16:05:36 +0100 (CET) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id B5C4DC86E; Fri, 13 Nov 2020 16:05:33 +0100 (CET) IronPort-SDR: AyYK+urfduuWQByHmn+1K5DXWzRYdAwg2A015zkVyVRqatKdeiu9yhJk3SyZnZhpIL3PFA/7NU 5/HPPMDfOLgQ== X-IronPort-AV: E=McAfee;i="6000,8403,9803"; a="150332370" X-IronPort-AV: E=Sophos;i="5.77,475,1596524400"; d="scan'208";a="150332370" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Nov 2020 07:05:30 -0800 IronPort-SDR: 6Y7ja14GKTHN+FkGRN9x/MGpMYNuuafpe5XKBrcxlEkJrjJ9iuNj3xQ18+lXkQm/ek4oSGVe1q HE8SIMVNfC+g== X-IronPort-AV: E=Sophos;i="5.77,475,1596524400"; d="scan'208";a="542682907" Received: from acuconoi-mobl1.ger.corp.intel.com (HELO bricha3-MOBL.ger.corp.intel.com) ([10.252.18.250]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 13 Nov 2020 07:05:26 -0800 Date: Fri, 13 Nov 2020 15:05:23 +0000 From: Bruce Richardson To: Maxime Coquelin Cc: dev@dpdk.org, yong.liu@intel.com, david.marchand@redhat.com, stable@dpdk.org Message-ID: <20201113150523.GA1441@bricha3-MOBL.ger.corp.intel.com> References: <20201113145212.486443-1-maxime.coquelin@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201113145212.486443-1-maxime.coquelin@redhat.com> Subject: Re: [dpdk-dev] [PATCH] config: enable packet prefetching with Meson X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, Nov 13, 2020 at 03:52:12PM +0100, Maxime Coquelin wrote: > With Make build system, RTE_PMD_PACKET_PREFETCH was enabled > by default. It got lost when transitioning to Meson build > system. > > In order to avoid performance changes, this patch enables > packet prefetching in rte_config.h. > > Reported-by: Marvin Liu > Suggested-by: David Marchand > Signed-off-by: Maxime Coquelin > --- > > Hi Bruce, > > We were not sure whether adding below Fixes tag so that it is > backported to LTSes. What do you think? > > Fixes: 9314afb68a53 ("drivers: add infrastructure for meson build") > Cc: stable@dpdk.org > > config/rte_config.h | 3 +++ > 1 file changed, 3 insertions(+) > I view it as a gap in the transition from make to meson, so +1 for adding these. Stable maintainers can then decide themselves on whether to accept the patch or not. /Bruce