From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8A577A04B5; Mon, 16 Nov 2020 11:12:26 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 35B56C8FE; Mon, 16 Nov 2020 11:12:24 +0100 (CET) Received: from relay8-d.mail.gandi.net (relay8-d.mail.gandi.net [217.70.183.201]) by dpdk.org (Postfix) with ESMTP id 344ADC8F8 for ; Mon, 16 Nov 2020 11:12:22 +0100 (CET) X-Originating-IP: 90.78.4.16 Received: from inocybe.home (lfbn-poi-1-1343-16.w90-78.abo.wanadoo.fr [90.78.4.16]) (Authenticated sender: grive@u256.net) by relay8-d.mail.gandi.net (Postfix) with ESMTPSA id 71C411BF2B0; Mon, 16 Nov 2020 10:12:19 +0000 (UTC) From: Gaetan Rivet To: dev@dpdk.org Cc: stephen@networkplumber.org, Hemant Agrawal , Luca Boccassi , Thomas Monjalon Date: Mon, 16 Nov 2020 11:12:12 +0100 Message-Id: <20201116101212.405300-1-grive@u256.net> X-Mailer: git-send-email 2.29.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-dev] [PATCH] bus/pci: fix comment explaining device naming X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" The original triple negative was hard to read and the attempt to improve the formulation was commendable, unfortunately the new comment is the inverse of correct. Fixes: a65a34a85ebf ("eal: replace usage of blacklist/whitelist in enums") Cc: stephen@networkplumber.org Signed-off-by: Gaetan Rivet --- No Cc:stable as it was not yet released. drivers/bus/pci/pci_common.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/bus/pci/pci_common.c b/drivers/bus/pci/pci_common.c index b24c069713..d55e5a38cf 100644 --- a/drivers/bus/pci/pci_common.c +++ b/drivers/bus/pci/pci_common.c @@ -68,7 +68,9 @@ pci_name_set(struct rte_pci_device *dev) devargs = pci_devargs_lookup(&dev->addr); dev->device.devargs = devargs; - /* If the device is blocked, no rte_devargs exists for it. */ + /* When using a block-list, only blocked devices will have + * an rte_devargs. Allowed devices won't have one. + */ if (devargs != NULL) /* If an rte_devargs exists, the generic rte_device uses the * given name as its name. -- 2.29.2