From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 733D4A04E6; Wed, 18 Nov 2020 12:46:41 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C4A48C902; Wed, 18 Nov 2020 12:45:46 +0100 (CET) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id 43B65C8CC; Wed, 18 Nov 2020 12:45:43 +0100 (CET) IronPort-SDR: 5E3YzCg1nQrIaY6A08YsfUc1QQZBnO5FbxfH9xXCtfohOcux3RVlQAVjIsf/fpDt1l90SBuIYK qgAu3muPi6eA== X-IronPort-AV: E=McAfee;i="6000,8403,9808"; a="158876064" X-IronPort-AV: E=Sophos;i="5.77,486,1596524400"; d="scan'208";a="158876064" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Nov 2020 03:45:42 -0800 IronPort-SDR: GAnN0wHJdjeZpscW4syskshCEp3dybPMpkx+bjep7Ilcq3kEQ66od2oKr7mTtGaYNOowq2tGB3 A1TMARBtD96Q== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,486,1596524400"; d="scan'208";a="476313140" Received: from silpixa00399752.ir.intel.com (HELO silpixa00399752.ger.corp.intel.com) ([10.237.222.180]) by orsmga004.jf.intel.com with ESMTP; 18 Nov 2020 03:45:41 -0800 From: Ferruh Yigit To: Maryam Tahhan , Reshma Pattan , John McNamara , Vipin Varghese Cc: Ferruh Yigit , dev@dpdk.org, stable@dpdk.org Date: Wed, 18 Nov 2020 11:45:21 +0000 Message-Id: <20201118114525.99053-4-ferruh.yigit@intel.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20201118114525.99053-1-ferruh.yigit@intel.com> References: <20201117171435.2303641-1-ferruh.yigit@intel.com> <20201118114525.99053-1-ferruh.yigit@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-dev] [PATCH v2 3/7] app/procinfo: remove suspicious sizeof X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" The intention with the "sizeof(0)" usage is not clear, but the 'stats' already 'memset' by 'rte_cryptodev_stats_get()' API, removing 'memset' in application. Fixes: fe773600fe3e ("app/procinfo: add --show-crypto") Cc: stable@dpdk.org Signed-off-by: Ferruh Yigit --- app/proc-info/main.c | 1 - 1 file changed, 1 deletion(-) diff --git a/app/proc-info/main.c b/app/proc-info/main.c index c11fe25af4..dc5cc92209 100644 --- a/app/proc-info/main.c +++ b/app/proc-info/main.c @@ -1207,7 +1207,6 @@ show_crypto(void) display_crypto_feature_info(dev_info.feature_flags); - memset(&stats, 0, sizeof(0)); if (rte_cryptodev_stats_get(i, &stats) == 0) { printf("\t -- stats\n"); printf("\t\t + enqueue count (%"PRIu64")" -- 2.26.2