From: <pbhagavatula@marvell.com> To: <jerinj@marvell.com>, Pavan Nikhilesh <pbhagavatula@marvell.com> Cc: <dev@dpdk.org> Subject: [dpdk-dev] [PATCH 1/2] event/octeontx2: remove selftest from dev args Date: Thu, 19 Nov 2020 17:53:35 +0530 Message-ID: <20201119122336.5079-1-pbhagavatula@marvell.com> (raw) From: Pavan Nikhilesh <pbhagavatula@marvell.com> Since selftest now depends on dynamic mbuf fields it is not feasible to run selftest on device probe. Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com> --- drivers/event/octeontx2/otx2_evdev.c | 8 -------- drivers/event/octeontx2/otx2_evdev.h | 1 - 2 files changed, 9 deletions(-) diff --git a/drivers/event/octeontx2/otx2_evdev.c b/drivers/event/octeontx2/otx2_evdev.c index b31c26e95..c1a5916cd 100644 --- a/drivers/event/octeontx2/otx2_evdev.c +++ b/drivers/event/octeontx2/otx2_evdev.c @@ -1606,7 +1606,6 @@ static struct rte_eventdev_ops otx2_sso_ops = { #define OTX2_SSO_XAE_CNT "xae_cnt" #define OTX2_SSO_SINGLE_WS "single_ws" #define OTX2_SSO_GGRP_QOS "qos" -#define OTX2_SSO_SELFTEST "selftest" static void parse_queue_param(char *value, void *opaque) @@ -1696,8 +1695,6 @@ sso_parse_devargs(struct otx2_sso_evdev *dev, struct rte_devargs *devargs) if (kvlist == NULL) return; - rte_kvargs_process(kvlist, OTX2_SSO_SELFTEST, &parse_kvargs_flag, - &dev->selftest); rte_kvargs_process(kvlist, OTX2_SSO_XAE_CNT, &parse_kvargs_value, &dev->xae_cnt); rte_kvargs_process(kvlist, OTX2_SSO_SINGLE_WS, &parse_kvargs_flag, @@ -1813,10 +1810,6 @@ otx2_sso_init(struct rte_eventdev *event_dev) otx2_sso_dbg("Initializing %s max_queues=%d max_ports=%d", event_dev->data->name, dev->max_event_queues, dev->max_event_ports); - if (dev->selftest) { - event_dev->dev->driver = &pci_sso.driver; - event_dev->dev_ops->dev_selftest(); - } otx2_tim_init(pci_dev, (struct otx2_dev *)dev); @@ -1866,5 +1859,4 @@ RTE_PMD_REGISTER_KMOD_DEP(event_octeontx2, "vfio-pci"); RTE_PMD_REGISTER_PARAM_STRING(event_octeontx2, OTX2_SSO_XAE_CNT "=<int>" OTX2_SSO_SINGLE_WS "=1" OTX2_SSO_GGRP_QOS "=<string>" - OTX2_SSO_SELFTEST "=1" OTX2_NPA_LOCK_MASK "=<1-65535>"); diff --git a/drivers/event/octeontx2/otx2_evdev.h b/drivers/event/octeontx2/otx2_evdev.h index 547e29d4a..210ee89f1 100644 --- a/drivers/event/octeontx2/otx2_evdev.h +++ b/drivers/event/octeontx2/otx2_evdev.h @@ -147,7 +147,6 @@ struct otx2_sso_evdev { uint64_t *timer_adptr_sz; /* Dev args */ uint8_t dual_ws; - uint8_t selftest; uint32_t xae_cnt; uint8_t qos_queue_cnt; struct otx2_sso_qos *qos_parse_data; -- 2.17.1
next reply other threads:[~2020-11-19 12:23 UTC|newest] Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-11-19 12:23 pbhagavatula [this message] 2020-11-19 12:23 ` [dpdk-dev] [PATCH 2/2] event/octeontx: " pbhagavatula 2020-11-19 13:15 ` [dpdk-dev] [PATCH 1/2] event/octeontx2: " David Marchand 2020-11-19 13:30 ` [dpdk-dev] [EXT] " Pavan Nikhilesh Bhagavatula 2020-11-19 13:36 ` David Marchand 2020-11-19 13:45 ` Pavan Nikhilesh Bhagavatula 2020-11-19 13:57 ` [dpdk-dev] [PATCH v2 " pbhagavatula 2020-11-19 13:57 ` [dpdk-dev] [PATCH v2 2/2] event/octeontx: " pbhagavatula 2020-11-20 12:26 ` Jerin Jacob
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20201119122336.5079-1-pbhagavatula@marvell.com \ --to=pbhagavatula@marvell.com \ --cc=dev@dpdk.org \ --cc=jerinj@marvell.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
DPDK patches and discussions This inbox may be cloned and mirrored by anyone: git clone --mirror http://inbox.dpdk.org/dev/0 dev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 dev dev/ http://inbox.dpdk.org/dev \ dev@dpdk.org public-inbox-index dev Example config snippet for mirrors. Newsgroup available over NNTP: nntp://inbox.dpdk.org/inbox.dpdk.dev AGPL code for this site: git clone https://public-inbox.org/public-inbox.git