From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 71087A04DD; Fri, 20 Nov 2020 10:55:11 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 8B415DED; Fri, 20 Nov 2020 10:55:09 +0100 (CET) Received: from new1-smtp.messagingengine.com (new1-smtp.messagingengine.com [66.111.4.221]) by dpdk.org (Postfix) with ESMTP id 1E05D3B5 for ; Fri, 20 Nov 2020 10:55:06 +0100 (CET) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailnew.nyi.internal (Postfix) with ESMTP id 7F7C5580393; Fri, 20 Nov 2020 04:55:05 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Fri, 20 Nov 2020 04:55:05 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; s=fm2; bh=XAei+Ny9m3cQ/s9BVnn+p8/X7c D8KX9V7TfzJIXnl6M=; b=LKqbLvctTZ+tOhMa4LMpM6MKOlSQ7x+Xoozw61NogF qtU4OiDUL3j8urvQ2XOlTBjkC/fNmJ94xOUD0EwM+pVsnktlf7YHnV9APU+7PF5W 9YJyJTTUcZ9Y3Xr+yos0vsyfHJ0JNlnNcc9JOQUAWcoV6UUp8X8v1O1+wKgNfldf LS/GWrzmfZdthJwfZcwesk5ktPv8r5ezVqbGRwEVlsUKbUezsqbn6FyMmpfdtJ/4 D/PQs0XdIzXza2jY/ZGdFaOsHumHjzxu7SCcwKJG5WIU7qKR7WrWNWbHURnO7umk w+jT9EsxKjUgPj4+Ai1rckf4YAAUJ3RqM/0caIwSld0Q== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:date:from :message-id:mime-version:subject:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=XAei+Ny9m3cQ/s9BV nn+p8/X7cD8KX9V7TfzJIXnl6M=; b=kELFoeWy2L3NFmyEgKMwBCE3nbEcsz6Aa zARomjfqoEdUuQPnY5CvSP90bfE06FQ3z/b99IbJxVbi/YyYf44xTXnXYJN+9Gn/ /VXmEkNWq4jMSf4O0lzyuU4JDH8J9D62a1EmqA7XxPI8Z4NqGvw2wbGN3uUbRFcN vqAX3T3VqXqKCRFvosLBRlD29Bs8zWpyaSGHazsxOtbMmEmyhT8tPHEteYdhOB+y kXzoam0X/bOCoCN/RSMOZPVX4WnZUbIoZ9ZhVr9TRI6EdRdPEpk0f/nzGHt96QEJ /OgQRjdcMIQ0VEaFVzO3LUVb8L0ugvXXdYFned9wz9JLBkpDrYV9g== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrudegtddgtdejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkffoggfgsedtkeertdertddtnecuhfhrohhmpefvhhhomhgrshcu ofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecuggftrf grthhtvghrnhepvdelvdduhedvudduveeuvdevheegudelgeeigfejheduhedttdegudff jeeihffgnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghrufhiii gvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghlohhn rdhnvght X-ME-Proxy: Received: from xps.monjalon.net (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 3AF833064AB0; Fri, 20 Nov 2020 04:55:03 -0500 (EST) From: Thomas Monjalon To: dev@dpdk.org Cc: david.marchand@redhat.com, andreyv@nvidia.com, talshn@nvidia.com, dmitry.kozliuk@gmail.com, orika@nvidia.com, Matan Azrad , Shahaf Shuler , Viacheslav Ovsiienko , Ferruh Yigit , Andrew Rybchenko Date: Fri, 20 Nov 2020 10:54:38 +0100 Message-Id: <20201120095438.2620653-1-thomas@monjalon.net> X-Mailer: git-send-email 2.28.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-dev] [PATCH 1/1] ethdev: rename a flow shared action error code X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" In the experimental function rte_flow_shared_action_destroy() introduced in DPDK 20.11, the errno ETOOMANYREFS was used. This errno is not always available on Windows, so it is preferred using EBUSY instead. Signed-off-by: Thomas Monjalon --- drivers/net/mlx5/mlx5_flow_dv.c | 4 ++-- lib/librte_ethdev/rte_flow.h | 3 +-- 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/net/mlx5/mlx5_flow_dv.c b/drivers/net/mlx5/mlx5_flow_dv.c index 62d9ca9ffb..51cc41face 100644 --- a/drivers/net/mlx5/mlx5_flow_dv.c +++ b/drivers/net/mlx5/mlx5_flow_dv.c @@ -11436,14 +11436,14 @@ __flow_dv_action_rss_release(struct rte_eth_dev *dev, uint32_t idx, "invalid shared action"); remaining = __flow_dv_action_rss_hrxqs_release(dev, shared_rss); if (remaining) - return rte_flow_error_set(error, ETOOMANYREFS, + return rte_flow_error_set(error, EBUSY, RTE_FLOW_ERROR_TYPE_ACTION, NULL, "shared rss hrxq has references"); if (!__atomic_compare_exchange_n(&shared_rss->refcnt, &old_refcnt, 0, 0, __ATOMIC_ACQUIRE, __ATOMIC_RELAXED)) - return rte_flow_error_set(error, ETOOMANYREFS, + return rte_flow_error_set(error, EBUSY, RTE_FLOW_ERROR_TYPE_ACTION, NULL, "shared rss has references"); diff --git a/lib/librte_ethdev/rte_flow.h b/lib/librte_ethdev/rte_flow.h index 8b970ba0b7..b98334c5c4 100644 --- a/lib/librte_ethdev/rte_flow.h +++ b/lib/librte_ethdev/rte_flow.h @@ -3549,8 +3549,7 @@ rte_flow_shared_action_create(uint16_t port_id, * - (-ENOSYS) if underlying device does not support this functionality. * - (-EIO) if underlying device is removed. * - (-ENOENT) if action pointed by *action* handle was not found. - * - (-ETOOMANYREFS) if action pointed by *action* handle still used by one or - * more rules + * - (-EBUSY) if action pointed by *action* handle still used by some rules * rte_errno is also set. */ __rte_experimental -- 2.28.0