From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6D509A04DD; Sat, 21 Nov 2020 00:21:56 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 12E674C90; Sat, 21 Nov 2020 00:21:55 +0100 (CET) Received: from mail-pg1-f179.google.com (mail-pg1-f179.google.com [209.85.215.179]) by dpdk.org (Postfix) with ESMTP id 8B8DBF90 for ; Sat, 21 Nov 2020 00:21:53 +0100 (CET) Received: by mail-pg1-f179.google.com with SMTP id t37so8539984pga.7 for ; Fri, 20 Nov 2020 15:21:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Mos+bPI3bc0e0JhYE+vemZgavISNE/1V1aQekeL04NE=; b=RC6SY393dzSO15fWxJx64O68FV9akPuk7h+NDlrUGBhta89oEBn33dgmZSUHq4WVtc lbdR3rjrnVuymYVF2A01OPTs5a6hFDho9Gkh2t6zgBNVlwmBwgRY7mYuIKNyzo850t9u n4kLQuvv1JfR3gNO4R2Sqraw0ULG+adzyHLXRcx/4B/1Z3ckrpusQC0KRjDXHt/mTeDb PMyDGSzP4k0X99Ods4ZHnOhpeXOBbCtFHbdeZ1bLB5km+Y2gPo04EfmBzZBaosqGneUJ 770JNYREqEEOFs/XlYmQ3XXakoTIh0XxPnmuOkJyigPDSmDdH87UoybbZdaB4XXiDDw3 Fpew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Mos+bPI3bc0e0JhYE+vemZgavISNE/1V1aQekeL04NE=; b=folMKHYeiXZIr1QIRWse2+CU2WDU32FeFEvnISdNIyP6juIWsZ+slekN65si9a7xEf 6UIjqE2YMBSSlI6hamYpcJ1DlhOpuDZYh6T/NTk891aL6nvuuLtRb6YGT598Us44JA3R hPzREPgA8SC8ig0a0D7Rm1rHyp5Kite/rvAxtg9tsuHJSeEScYbMhEgKaqzZx/F699af jXIVgzWAFHc3WDCXE1Zuv9HnCCxZIFmcPs6vKQjXiqr/B4O1ghJavYed+hiNSsac5w+q xAY8LdAIS7YoEKF5nL7WY/4JFOW4OCtwfiNa/rv9FQz4ImGHZ/OWDQUlUUMlWvvYaPsW 3LOQ== X-Gm-Message-State: AOAM533+4IODMo+hnWwpmeZWZU/CFCm6j1GLvQdPpAbO6Qfd5DDGOqmt +yDEHQBS4EtNx9bXp2eZuju93Q== X-Google-Smtp-Source: ABdhPJwhvXuNSCrhbsQaLeF7l8/gePCFzqGABrbBHmcm+G1PcSVyL+7Nophxq2I9zKWdWg4LxuimCA== X-Received: by 2002:aa7:8430:0:b029:18b:b3f5:ea4b with SMTP id q16-20020aa784300000b029018bb3f5ea4bmr15661937pfn.61.1605914511624; Fri, 20 Nov 2020 15:21:51 -0800 (PST) Received: from hermes.local (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id b3sm4698253pfd.66.2020.11.20.15.21.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 Nov 2020 15:21:51 -0800 (PST) Date: Fri, 20 Nov 2020 15:21:37 -0800 From: Stephen Hemminger To: Ferruh Yigit Cc: "Min Hu (Connor)" , dev@dpdk.org, bruce.richardson@intel.com, thomas.monjalon@6wind.com, lihuisong@huawei.com Message-ID: <20201120152137.37d11e99@hermes.local> In-Reply-To: <94a17751-c71a-a1c0-7cfd-d7990ff265e5@intel.com> References: <531504ce-0547-48c2-4e34-c2ed6cb12e57@intel.com> <1605873002-51934-1-git-send-email-humin29@huawei.com> <94a17751-c71a-a1c0-7cfd-d7990ff265e5@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [RFC V4] app/testpmd: fix queue stats mapping configuration X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, 20 Nov 2020 17:26:55 +0000 Ferruh Yigit wrote: > On 11/20/2020 11:50 AM, Min Hu (Connor) wrote: > > From: Huisong Li > > > > Currently, the queue stats mapping has the following problems: > > 1) Many PMD drivers don't support queue stats mapping. But there is no > > failure message after executing the command "set stat_qmap rx 0 2 2". > > 2) Once queue mapping is set, unrelated and unmapped queues are also > > displayed. > > 3) The configuration result does not take effect or can not be queried > > in real time. > > 4) The mapping arrays, "tx_queue_stats_mappings_array" & > > "rx_queue_stats_mappings_array" are global and their sizes are based on > > fixed max port and queue size assumptions. > > 5) These record structures, 'map_port_queue_stats_mapping_registers()' > > and its sub functions are redundant for majority of drivers. > > 6) The display of the queue stats and queue stats mapping is mixed > > together. > > > > Since xstats is used to obtain queue statistics, we have made the following > > simplifications and adjustments: > > 1) If PMD requires and supports queue stats mapping, configure to driver in > > real time by calling ethdev API after executing the command > > "set stat_qmap rx/tx ...". If not, the command can not be accepted. > > 2) Based on the above adjustments, these record structures, > > 'map_port_queue_stats_mapping_registers()' and its sub functions can be > > removed. "tx-queue-stats-mapping" & "rx-queue-stats-mapping" parameters, > > and 'parse_queue_stats_mapping_config()' can be removed too. > > 3) remove display of queue stats mapping in 'fwd_stats_display()' & > > 'nic_stats_display()', and obtain queue stats by xstats. > > Since the record structures are removed, 'nic_stats_mapping_display()' > > can be deleted. > > > > Fixes: 4dccdc789bf4b ("app/testpmd: simplify handling of stats mappings error") > > Fixes: 013af9b6b64f6 ("app/testpmd: various updates") > > Fixes: ed30d9b691b21 ("app/testpmd: add stats per queue") > > > > Signed-off-by: Huisong Li > > Overall looks good to me. > I did a quick test didn't see anything unexpected. 'xstats' or 'dpdk-proc-info' > app still can be used to get queue stats and "set stat_qmap ..." is working as > expected. > > But it is a little late for this release cycle, would you be OK to get this at > the beginning of next release? Could we plan to deprecate queue stats mapping in future when xstats work is done?