From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 036B6A04E7; Sat, 21 Nov 2020 05:29:48 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 59FA1DED; Sat, 21 Nov 2020 05:29:47 +0100 (CET) Received: from mail-pg1-f196.google.com (mail-pg1-f196.google.com [209.85.215.196]) by dpdk.org (Postfix) with ESMTP id 840E03B5 for ; Sat, 21 Nov 2020 05:29:45 +0100 (CET) Received: by mail-pg1-f196.google.com with SMTP id q28so9127313pgk.1 for ; Fri, 20 Nov 2020 20:29:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=FrqhqaZRcvytVg5t09vRF013pDwgaWiZ1pd8fYPvb70=; b=mlrL77QiEVTdRQ3N7qcA2l43XIQeP7wQnqnMqFbs01UGe5ruJH8lJdvZMqggZUapaN 7BbJDrIzL2cWp923N+NRv2oDg1drVq9KnyZznpLZrS3s0kYci7NitqtYoZ+PDIHj5CPX 4xer9Pelho7F/UzKzyEC5bf4e/dB8bcA7qYZgUKDk6yOu2MQlAZhZZrLVnzxq4sAqdTK PCJTfzDW7kcpTNeI1tKbttZcmk6EitVqVoiVF3s9iKgTQhfO66TlnsJkHK72seJ5lyvB bHwVuU7ESpY+plPgY8gKg1exj4g+TyBUmbCeNrrnRH9eEiKEyHCLtUclTWz/1wKKJnk/ KOtQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=FrqhqaZRcvytVg5t09vRF013pDwgaWiZ1pd8fYPvb70=; b=V4Bt0ZgYpOI8sy8UCVVZyIqOklAQDdAQaIz+RkuafNzUw1GVvlSOoOweD2WA6czp2R mGK+f7fxHl/BZrvZ5kwYC332zbzlvZw9Cyh/FpXK/fVqX8WGCrSr5dBYn8qzNFOXedL9 2ewv9my1XuTema5+azyri4nukixmAzSlgL5vHXOF3epvXQWlbW2pbP/YTXYSPm84N0Xa TvvbqqsZeAJPbSYZwu5lbhu6gh092fgt0/cj3uZa6YdV59g+6ig/7UxvL0rbVvI6PR9O 2/xf8H/EYtZYPgp7GqwONI5HhxFFHrj/0f8Zij4sSixPh4UQ0IGeSBqtfpC6KAkNIAyu pOSg== X-Gm-Message-State: AOAM530WHqtCt2ku0j++fnzDH6qEIFgdn56Ror8tFiZ4+GZ9kViWPB+C r9SDGLaBJbu9E0YIrlAHprV6BA== X-Google-Smtp-Source: ABdhPJxXfVcEF33EqJnzF22G5CLdoRS7OqMmO+Qh7jZo7pctEwQk7Z3Zv+fOZtKlj/BW4EBk4MlKMQ== X-Received: by 2002:a17:90a:c257:: with SMTP id d23mr13595578pjx.46.1605932983421; Fri, 20 Nov 2020 20:29:43 -0800 (PST) Received: from hermes.local (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id 145sm4830493pgh.66.2020.11.20.20.29.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 Nov 2020 20:29:43 -0800 (PST) Date: Fri, 20 Nov 2020 20:29:28 -0800 From: Stephen Hemminger To: Ferruh Yigit Cc: "Min Hu (Connor)" , dev@dpdk.org, bruce.richardson@intel.com, thomas.monjalon@6wind.com, lihuisong@huawei.com Message-ID: <20201120202928.126217ad@hermes.local> In-Reply-To: <9dca1ddf-1842-7087-7f04-98604536340e@intel.com> References: <531504ce-0547-48c2-4e34-c2ed6cb12e57@intel.com> <1605873002-51934-1-git-send-email-humin29@huawei.com> <94a17751-c71a-a1c0-7cfd-d7990ff265e5@intel.com> <20201120152137.37d11e99@hermes.local> <9dca1ddf-1842-7087-7f04-98604536340e@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [RFC V4] app/testpmd: fix queue stats mapping configuration X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, 20 Nov 2020 23:33:40 +0000 Ferruh Yigit wrote: > On 11/20/2020 11:21 PM, Stephen Hemminger wrote: > > On Fri, 20 Nov 2020 17:26:55 +0000 > > Ferruh Yigit wrote: > > > >> On 11/20/2020 11:50 AM, Min Hu (Connor) wrote: > >>> From: Huisong Li > >>> > >>> Currently, the queue stats mapping has the following problems: > >>> 1) Many PMD drivers don't support queue stats mapping. But there is no > >>> failure message after executing the command "set stat_qmap rx 0 2 2". > >>> 2) Once queue mapping is set, unrelated and unmapped queues are also > >>> displayed. > >>> 3) The configuration result does not take effect or can not be queried > >>> in real time. > >>> 4) The mapping arrays, "tx_queue_stats_mappings_array" & > >>> "rx_queue_stats_mappings_array" are global and their sizes are based on > >>> fixed max port and queue size assumptions. > >>> 5) These record structures, 'map_port_queue_stats_mapping_registers()' > >>> and its sub functions are redundant for majority of drivers. > >>> 6) The display of the queue stats and queue stats mapping is mixed > >>> together. > >>> > >>> Since xstats is used to obtain queue statistics, we have made the following > >>> simplifications and adjustments: > >>> 1) If PMD requires and supports queue stats mapping, configure to driver in > >>> real time by calling ethdev API after executing the command > >>> "set stat_qmap rx/tx ...". If not, the command can not be accepted. > >>> 2) Based on the above adjustments, these record structures, > >>> 'map_port_queue_stats_mapping_registers()' and its sub functions can be > >>> removed. "tx-queue-stats-mapping" & "rx-queue-stats-mapping" parameters, > >>> and 'parse_queue_stats_mapping_config()' can be removed too. > >>> 3) remove display of queue stats mapping in 'fwd_stats_display()' & > >>> 'nic_stats_display()', and obtain queue stats by xstats. > >>> Since the record structures are removed, 'nic_stats_mapping_display()' > >>> can be deleted. > >>> > >>> Fixes: 4dccdc789bf4b ("app/testpmd: simplify handling of stats mappings error") > >>> Fixes: 013af9b6b64f6 ("app/testpmd: various updates") > >>> Fixes: ed30d9b691b21 ("app/testpmd: add stats per queue") > >>> > >>> Signed-off-by: Huisong Li > >> > >> Overall looks good to me. > >> I did a quick test didn't see anything unexpected. 'xstats' or 'dpdk-proc-info' > >> app still can be used to get queue stats and "set stat_qmap ..." is working as > >> expected. > >> > >> But it is a little late for this release cycle, would you be OK to get this at > >> the beginning of next release? > > > > Could we plan to deprecate queue stats mapping in future when xstats work is done? > > > > Even queue stats moved to xstats, a few PMDs still need this configuration and API. > And this patch already cleans the queue stats mapping noise from testpmd. > > What is the benefit/motivation to deprecate the queue stats mapping API? Mostly because so few drivers implement it, that any application using it is going to be non-portable.