From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 524DAA04B5; Sat, 21 Nov 2020 23:02:29 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 136E93B5; Sat, 21 Nov 2020 23:02:27 +0100 (CET) Received: from mail-lf1-f66.google.com (mail-lf1-f66.google.com [209.85.167.66]) by dpdk.org (Postfix) with ESMTP id ED043160 for ; Sat, 21 Nov 2020 23:02:23 +0100 (CET) Received: by mail-lf1-f66.google.com with SMTP id t6so2409800lfl.13 for ; Sat, 21 Nov 2020 14:02:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=VK2Hy12L6dm+x5yOjdpHsYM3kuBB9bNggM+T4XgX/ns=; b=iVc4d2kyBnAtDaIYq7wwH1qZA/cxAPfF9/nrA0GgHiN6R3veq8BCNatNclRRauG+2S E3x+NpS8ANWywlZYGK+ypyQt66CQEsCmiXcAExttxYjL++tP+utuUPG47iqKbYRWfH81 dCwiNKw1qoR8HY+6HDoqlq0tEEMxN9JZL3Kg0ZG2QYuV7zG4sBJIXNX/uIVJFAfH8i2M mJRPeFfm877GGRI7I4QygGGkjKj52FCvGLxcIOldBgIAFmpfULt8gpWNdn7TFkU1ft+e Eo/azJ3DQTasnHGVKKuqJik8YnO5iI5pW+oKWsh2urrnMujakwhsfxqHd6FfmE40YgYx KzTQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=VK2Hy12L6dm+x5yOjdpHsYM3kuBB9bNggM+T4XgX/ns=; b=dYRS1BemqLoONNET8KpXYe6a3b1+0DYeafNNhG63TzEZypMtHNcXh01jByLA/O7fxY teVUzl+YFXF9W45w/alL46BoSF5lQnp91ZH3yGFv6mZo6bcLSJPydnuWVedNuo0/1QdD YjwRQpUTkuOQ2lrzVAcmXGib6j4RurE5lj03roZFB9KnPhN8PpFJHWvJQazD8R+Kn46u HB0D3J9NG2TuS9HXKDT69OuEx3YZPy9AG+XsJp6zxPVguV66pHomjHb/e+yw4xIaHxBO ftn6ZhCqh99gFWaSJkfclGIIDK+FlC1nlxEmeH6uDg4M+1GD9JHid0R1kzlzySS4GR1O eh8Q== X-Gm-Message-State: AOAM531dvJU5oDGG24WeVYIxmOrr4aRJAsaLzSgOgDx6od/A26Jl6+Xs YJhbZOW3uwlg+Icdn6Frrj0= X-Google-Smtp-Source: ABdhPJxQ/UW2MGl4CFhFqZX3NE7E7o8bE2A2kHjhdBFQNFfUmBnh6HOEAtyAJLdDcK5ZgUojblZE/w== X-Received: by 2002:a19:4c3:: with SMTP id 186mr10222597lfe.206.1605996143516; Sat, 21 Nov 2020 14:02:23 -0800 (PST) Received: from sovereign (broadband-37-110-65-23.ip.moscow.rt.ru. [37.110.65.23]) by smtp.gmail.com with ESMTPSA id b7sm841772lfo.24.2020.11.21.14.02.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 21 Nov 2020 14:02:22 -0800 (PST) Date: Sun, 22 Nov 2020 01:02:21 +0300 From: Dmitry Kozlyuk To: Nick Connolly Cc: Narcisa Ana Maria Vasile , Dmitry Malloy , Pallavi Kadam , Tal Shnaiderman , dev@dpdk.org Message-ID: <20201122010221.1387bb3d@sovereign> In-Reply-To: <20201120211255.24803-1-nick.connolly@mayadata.io> References: <20201120211255.24803-1-nick.connolly@mayadata.io> X-Mailer: Claws Mail 3.17.6 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] eal/windows: fix link error with MinGW X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, 20 Nov 2020 21:12:55 +0000, Nick Connolly wrote: > Linking with the 'pci' driver when building with MinGW on > Windows fails with undefined symbol 'GUID_DEVCLASS_NET'. > This occurs because devguid.h is included in rte_windows.h > before INITGUID is defined. > > Resolved by moving the include of devguid.h after the definition > of INITGUID. Commit changes should be described in present tense. > > Fixes: b762221ac24f ("bus/pci: support Windows with bifurcated drivers") > Cc: talshn@mellanox.com A blank line should be here. > Signed-off-by: Nick Connolly > --- Apart from those nits, Acked-by: Dmitry Kozlyuk