From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7F1FAA04DD; Thu, 26 Nov 2020 17:24:57 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id DF719C9E6; Thu, 26 Nov 2020 17:24:55 +0100 (CET) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id EE0DAC9D6 for ; Thu, 26 Nov 2020 17:24:53 +0100 (CET) IronPort-SDR: lK6AjmZAtJAbynQYnOAa0oZeFDc2SQgOVyy4i/JcaO9RLOnsnqEoxg77BmrnPFk12TacDSP+rY MqX4dN39Pu+w== X-IronPort-AV: E=McAfee;i="6000,8403,9817"; a="168801430" X-IronPort-AV: E=Sophos;i="5.78,372,1599548400"; d="scan'208";a="168801430" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Nov 2020 08:24:48 -0800 IronPort-SDR: NstbHBGNhuACNzCHBXcxV+PP9BtLSpwVyqAzTYJqxu5YjpXUjRKp2RSqwFuxOOFLW8f5tvOuSa XUoRhbQfejcw== X-IronPort-AV: E=Sophos;i="5.78,372,1599548400"; d="scan'208";a="333421538" Received: from bricha3-mobl.ger.corp.intel.com ([10.252.21.198]) by orsmga006-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 26 Nov 2020 08:24:46 -0800 Date: Thu, 26 Nov 2020 16:24:43 +0000 From: Bruce Richardson To: Thomas Monjalon Cc: dev@dpdk.org, david.marchand@redhat.com, Gregory Etelson Message-ID: <20201126162443.GG1340@bricha3-MOBL.ger.corp.intel.com> References: <20201117181746.17904-1-getelson@nvidia.com> <20201126154218.1222717-1-thomas@monjalon.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201126154218.1222717-1-thomas@monjalon.net> Subject: Re: [dpdk-dev] [PATCH v2 1/1] doc: add pkg-config requirement for applications X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Nov 26, 2020 at 04:42:18PM +0100, Thomas Monjalon wrote: > From: Gregory Etelson > > DPDK relies on pkg-config(1) to provide correct parameters for > compiler and linker used in application build. Inaccurate build > parameters, produced by pkg-config from DPDK .pc files could fail > application build or cause unpredicted results during application > runtime. > > Update system requirements doc about a bug in pkg-config v0.27 > used in RHEL-7. > > Signed-off-by: Gregory Etelson > Signed-off-by: Thomas Monjalon > --- > > v2: make a more global note about the need for pkg-config in app build > > --- > doc/guides/linux_gsg/sys_reqs.rst | 13 +++++++++++++ > 1 file changed, 13 insertions(+) > > diff --git a/doc/guides/linux_gsg/sys_reqs.rst b/doc/guides/linux_gsg/sys_reqs.rst > index 6ecdc04aa9..ab38284950 100644 > --- a/doc/guides/linux_gsg/sys_reqs.rst > +++ b/doc/guides/linux_gsg/sys_reqs.rst > @@ -94,6 +94,19 @@ found in that driver's documentation in the relevant DPDK guide document, > e.g. :doc:`../nics/index` > > > +Building DPDK Applications > +-------------------------- > + > +The tool pkg-config or pkgconf, integrated in most build systems, > +must be used to parse options and dependencies from libdpdk.pc. > + > +.. note:: > + > + pkg-config 0.27, supplied with RHEL-7, > + does not process correctly Libs.private section, "correctly process the Lib.private..." or "process the Libs.private section correctly..." would read better, I think. > + resulting in misses in statically linked applications. "misses" is a strange term to use here, and I think it needs clarification on what exactly is being missed. How about generalizing it a bit: "resulting in statically linked applications not being linked properly." > + > + > Running DPDK Applications > ------------------------- > > -- > 2.28.0 >