From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 30CF0A0524; Fri, 27 Nov 2020 17:16:25 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C56D2C902; Fri, 27 Nov 2020 17:16:22 +0100 (CET) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 49491C8FE for ; Fri, 27 Nov 2020 17:16:20 +0100 (CET) IronPort-SDR: DCOpd9ReUNh4oU6H9ajkZs0MagtaF9PVej+m4cZvFxqUqkCdsM6G1pEFvdMTAXLLkp2WMltG86 OiqM4UqlHOsA== X-IronPort-AV: E=McAfee;i="6000,8403,9818"; a="169851019" X-IronPort-AV: E=Sophos;i="5.78,375,1599548400"; d="scan'208";a="169851019" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Nov 2020 08:16:18 -0800 IronPort-SDR: dvVMxvF7nlyPTrsX88HAGTH2KpRuYUX755sMJFWOgvcQ5g+MOIhkbMxVtSublN/PhJW8XpQPyF dEQwD6pLonsA== X-IronPort-AV: E=Sophos;i="5.78,375,1599548400"; d="scan'208";a="479720318" Received: from bricha3-mobl.ger.corp.intel.com ([10.252.6.231]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 27 Nov 2020 08:16:16 -0800 Date: Fri, 27 Nov 2020 16:16:12 +0000 From: Bruce Richardson To: Ferruh Yigit Cc: Ray Kinsella , Neil Horman , dev@dpdk.org, Andrew Rybchenko , Thomas Monjalon , Ori Kam Message-ID: <20201127161612.GG1561@bricha3-MOBL.ger.corp.intel.com> References: <20201123134007.2870297-1-ferruh.yigit@intel.com> <20201124131535.276072-1-ferruh.yigit@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201124131535.276072-1-ferruh.yigit@intel.com> Subject: Re: [dpdk-dev] [PATCH v2] doc: announce flow API matching pattern struct changes X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Nov 24, 2020 at 01:15:35PM +0000, Ferruh Yigit wrote: > Proposing to replace protocol header fields in the ``rte_flow_item_*`` > structures with the protocol structs. > > This is both for documenting the intention and to be sure > ``rte_flow_item_*`` always starts with complete protocol header. > > Change will be done in two steps, at first step in v21.02 release, > protocol header struct will be added as union, for example: > > Current ``struct rte_flow_item_eth``, > > struct rte_flow_item_eth { > struct rte_ether_addr dst; > struct rte_ether_addr src; > rte_be16_t type; > uint32_t has_vlan:1; > uint32_t reserved:31; > } > > will become in v21.02: > > __extension__ > struct rte_flow_item_eth { > union { > struct { > struct rte_ether_addr dst; > struct rte_ether_addr src; > rte_be16_t type; > }; > struct rte_ether_hdr hdr; > }; > uint32_t has_vlan:1; > uint32_t reserved:31; > } > > After this point usage should switch to 'hdr' struct. > > And in the second step, in the v21.11 LTS release the protocol fields > will be removed, and the struct will become: > > struct rte_flow_item_eth { > struct rte_ether_hdr hdr; > uint32_t has_vlan:1; > uint32_t reserved:31; > } > > Already many ``rte_flow_item_*`` structures implemented to have protocol > struct, target is convert all to this usage. > > Signed-off-by: Ferruh Yigit > Acked-by: Andrew Rybchenko > --- > Cc: Thomas Monjalon > Cc: Andrew Rybchenko > Cc: Ori Kam > Acked-by: Bruce Richardson