From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9140BA0527; Sun, 29 Nov 2020 14:42:23 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id D6AFCC8F6; Sun, 29 Nov 2020 14:42:21 +0100 (CET) Received: from mail-lj1-f193.google.com (mail-lj1-f193.google.com [209.85.208.193]) by dpdk.org (Postfix) with ESMTP id 340ABC8E6; Sun, 29 Nov 2020 14:42:20 +0100 (CET) Received: by mail-lj1-f193.google.com with SMTP id z1so12645692ljn.4; Sun, 29 Nov 2020 05:42:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=dbxCdpJnUEK+pKyM2/GpEQrN50DA+vgx1oGx4kqxgZg=; b=DarF8ugp0O1FYDQ+faYb6zKbDw84vpjk5J/eyfJkvB387YtVxoasQlpCM+vSEVvBgu R5psE/ILfQULxFzq04/idZHUOtPOCHsVaZL8uo6Nx6N34PJrl0DYNNh6U1FgcRbBpiDY z4iJLoQr6zuAIrOHUaKgPw2odkv/GVJu+g1Fu75ePDe5yu35xUyaxuUxsWZ18ky1i/uq RRibtL5HjjQ6qaQMpyhwHc3SoVTgi4bliQ2Vo6BIRsLKOkSr0kIVw+6k2+hIwAPxybFR u8k92V12eysMcooaTbFCGIUoEw4lmJ1u0++hvTmx0fsQDUivSFentLPfGIbsqpc3WydO YyLg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=dbxCdpJnUEK+pKyM2/GpEQrN50DA+vgx1oGx4kqxgZg=; b=IvcLsJYNaHKN2S4i4KhtqUQP6WO+tl8L35H2v7wTpDeBgNuxqvvNla33EK5gkma3IE V8Z41wnToPuQUSXB6wzewsvuH95r67pP0qyaTopkslVXL+I85jBGkVKUsWkCt3LzZiOm izu2cg/V/r6I9L3vdO8YQhqXpGIxu53Iq4cjfsAyNYMnSbtVlNhbcUKX1gTUO8hQ9kQ1 eTbLxzGcmCDzmXiJBIh/MzV7LWxrGQk+YHiN+7Ha0iAw67ofNlP/Uqut0Yjwr2NLcxbr pQQhyEkw43A1KJ25/QNefguDgMNpSu3/smy0XkO3yf8L9j621XGbcpSWm02X+NOrRD5I XRKQ== X-Gm-Message-State: AOAM530WPHi4BingxF6c7hWbe1sgyzK5dwwhhEz0s8NNvZrG8/rxCgZc JlXGyJE4qEOBRQxSGOwmUjw= X-Google-Smtp-Source: ABdhPJwZpudZ9NvDNcxElHustKJMJNWCrTC5/P4TiwAdxB9mrAaTio7AgLtriXp7iGNOOe+MIa3kIg== X-Received: by 2002:a2e:884f:: with SMTP id z15mr7355080ljj.200.1606657338797; Sun, 29 Nov 2020 05:42:18 -0800 (PST) Received: from sovereign (broadband-37-110-65-23.ip.moscow.rt.ru. [37.110.65.23]) by smtp.gmail.com with ESMTPSA id y134sm1547450lff.162.2020.11.29.05.42.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 29 Nov 2020 05:42:18 -0800 (PST) Date: Sun, 29 Nov 2020 16:42:16 +0300 From: Dmitry Kozlyuk To: Nick Connolly Cc: Narcisa Ana Maria Vasile , Dmitry Malloy , Pallavi Kadam , dev@dpdk.org, David Marchand , stable@dpdk.org Message-ID: <20201129164216.0c251b6d@sovereign> In-Reply-To: <20201129130047.798-1-nick.connolly@mayadata.io> References: <20201127120711.15703-1-nick.connolly@mayadata.io> <20201129130047.798-1-nick.connolly@mayadata.io> X-Mailer: Claws Mail 3.17.6 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v2] eal/windows: vfprintf build warning with clang X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Sun, 29 Nov 2020 13:00:47 +0000, Nick Connolly wrote: > When building with clang (11.0,--buildtype=debug), eal_lcore.c > produces a -Wformat-nonliteral warning from the vfprintf call > in log_early. > > Add __rte_format_printf annotation. > > Fixes: b8a36b086625 ("eal/windows: improve CPU and NUMA node detection") > Cc: stable@dpdk.org > > Signed-off-by: Nick Connolly > Suggested-by: Dmitry Kozlyuk > --- > v2: > * Use __rte_format_printf instead of disabling the warning > > lib/librte_eal/windows/eal_lcore.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/lib/librte_eal/windows/eal_lcore.c b/lib/librte_eal/windows/eal_lcore.c > index d5ff721e0..a85149be9 100644 > --- a/lib/librte_eal/windows/eal_lcore.c > +++ b/lib/librte_eal/windows/eal_lcore.c > @@ -38,6 +38,7 @@ static struct cpu_map cpu_map = { 0 }; > > /* eal_create_cpu_map() is called before logging is initialized */ > static void > +__rte_format_printf(1, 2) > log_early(const char *format, ...) > { > va_list va; Acked-by: Dmitry Kozlyuk