* [dpdk-dev] [PATCH] eal/windows: add stub for rte_intr_free_epoll_fd
@ 2020-11-19 14:00 Tal Shnaiderman
2020-11-19 15:01 ` David Marchand
2020-11-19 15:18 ` [dpdk-dev] [PATCH v2] " Tal Shnaiderman
0 siblings, 2 replies; 5+ messages in thread
From: Tal Shnaiderman @ 2020-11-19 14:00 UTC (permalink / raw)
To: dev; +Cc: thomas, dmitry.kozliuk, navasile, dmitrym, pallavi.kadam
Linux epoll mechanism is not implemented in Windows.
Add stub similarly to freeBSD.
Signed-off-by: Tal Shnaiderman <talshn@nvidia.com>
---
lib/librte_eal/windows/eal_interrupts.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/lib/librte_eal/windows/eal_interrupts.c b/lib/librte_eal/windows/eal_interrupts.c
index 6c64a48f34..6f7a1c7acc 100644
--- a/lib/librte_eal/windows/eal_interrupts.c
+++ b/lib/librte_eal/windows/eal_interrupts.c
@@ -105,3 +105,9 @@ eal_intr_thread_schedule(void (*func)(void *arg), void *arg)
return 0;
}
+
+void
+rte_intr_free_epoll_fd(struct rte_intr_handle *intr_handle)
+{
+ RTE_SET_USED(intr_handle);
+}
--
2.16.1.windows.4
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [dpdk-dev] [PATCH] eal/windows: add stub for rte_intr_free_epoll_fd
2020-11-19 14:00 [dpdk-dev] [PATCH] eal/windows: add stub for rte_intr_free_epoll_fd Tal Shnaiderman
@ 2020-11-19 15:01 ` David Marchand
2020-11-19 15:08 ` Tal Shnaiderman
2020-11-19 15:18 ` [dpdk-dev] [PATCH v2] " Tal Shnaiderman
1 sibling, 1 reply; 5+ messages in thread
From: David Marchand @ 2020-11-19 15:01 UTC (permalink / raw)
To: Tal Shnaiderman
Cc: dev, Thomas Monjalon, Dmitry Kozlyuk, Narcisa Ana Maria Vasile,
Dmitry Malloy (MESHCHANINOV),
Pallavi Kadam
On Thu, Nov 19, 2020 at 3:00 PM Tal Shnaiderman <talshn@nvidia.com> wrote:
>
> Linux epoll mechanism is not implemented in Windows.
>
> Add stub similarly to freeBSD.
>
> Signed-off-by: Tal Shnaiderman <talshn@nvidia.com>
> ---
> lib/librte_eal/windows/eal_interrupts.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/lib/librte_eal/windows/eal_interrupts.c b/lib/librte_eal/windows/eal_interrupts.c
> index 6c64a48f34..6f7a1c7acc 100644
> --- a/lib/librte_eal/windows/eal_interrupts.c
> +++ b/lib/librte_eal/windows/eal_interrupts.c
> @@ -105,3 +105,9 @@ eal_intr_thread_schedule(void (*func)(void *arg), void *arg)
>
> return 0;
> }
> +
> +void
> +rte_intr_free_epoll_fd(struct rte_intr_handle *intr_handle)
> +{
> + RTE_SET_USED(intr_handle);
> +}
This will not be of much use if you don't export it in
rte_eal_exports.def, right?
--
David Marchand
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [dpdk-dev] [PATCH] eal/windows: add stub for rte_intr_free_epoll_fd
2020-11-19 15:01 ` David Marchand
@ 2020-11-19 15:08 ` Tal Shnaiderman
0 siblings, 0 replies; 5+ messages in thread
From: Tal Shnaiderman @ 2020-11-19 15:08 UTC (permalink / raw)
To: David Marchand
Cc: dev, NBU-Contact-Thomas Monjalon, Dmitry Kozlyuk,
Narcisa Ana Maria Vasile, Dmitry Malloy (MESHCHANINOV),
Pallavi Kadam
> Subject: Re: [dpdk-dev] [PATCH] eal/windows: add stub for
> rte_intr_free_epoll_fd
>
> External email: Use caution opening links or attachments
>
>
> On Thu, Nov 19, 2020 at 3:00 PM Tal Shnaiderman <talshn@nvidia.com>
> wrote:
> >
> > Linux epoll mechanism is not implemented in Windows.
> >
> > Add stub similarly to freeBSD.
> >
> > Signed-off-by: Tal Shnaiderman <talshn@nvidia.com>
> > ---
> > lib/librte_eal/windows/eal_interrupts.c | 6 ++++++
> > 1 file changed, 6 insertions(+)
> >
> > diff --git a/lib/librte_eal/windows/eal_interrupts.c
> > b/lib/librte_eal/windows/eal_interrupts.c
> > index 6c64a48f34..6f7a1c7acc 100644
> > --- a/lib/librte_eal/windows/eal_interrupts.c
> > +++ b/lib/librte_eal/windows/eal_interrupts.c
> > @@ -105,3 +105,9 @@ eal_intr_thread_schedule(void (*func)(void *arg),
> > void *arg)
> >
> > return 0;
> > }
> > +
> > +void
> > +rte_intr_free_epoll_fd(struct rte_intr_handle *intr_handle) {
> > + RTE_SET_USED(intr_handle);
> > +}
>
> This will not be of much use if you don't export it in rte_eal_exports.def,
> right?
You're absolutely right, thank you for noticing, I'll send a v2 promptly.
>
> --
> David Marchand
^ permalink raw reply [flat|nested] 5+ messages in thread
* [dpdk-dev] [PATCH v2] eal/windows: add stub for rte_intr_free_epoll_fd
2020-11-19 14:00 [dpdk-dev] [PATCH] eal/windows: add stub for rte_intr_free_epoll_fd Tal Shnaiderman
2020-11-19 15:01 ` David Marchand
@ 2020-11-19 15:18 ` Tal Shnaiderman
2020-12-01 16:42 ` Dmitry Kozlyuk
1 sibling, 1 reply; 5+ messages in thread
From: Tal Shnaiderman @ 2020-11-19 15:18 UTC (permalink / raw)
To: dev
Cc: thomas, dmitry.kozliuk, navasile, dmitrym, pallavi.kadam, david.marchand
Linux epoll mechanism is not implemented in Windows.
Add stub similarly to freeBSD.
Signed-off-by: Tal Shnaiderman <talshn@nvidia.com>
---
v2: add missing export in def file [DavidM]
---
lib/librte_eal/rte_eal_exports.def | 1 +
lib/librte_eal/windows/eal_interrupts.c | 6 ++++++
2 files changed, 7 insertions(+)
diff --git a/lib/librte_eal/rte_eal_exports.def b/lib/librte_eal/rte_eal_exports.def
index 6a6be1cfa6..50e6cd3d42 100644
--- a/lib/librte_eal/rte_eal_exports.def
+++ b/lib/librte_eal/rte_eal_exports.def
@@ -63,6 +63,7 @@ EXPORTS
rte_get_tsc_hz
rte_hexdump
rte_hypervisor_get
+ rte_intr_free_epoll_fd
rte_intr_rx_ctl
rte_lcore_count
rte_lcore_has_role
diff --git a/lib/librte_eal/windows/eal_interrupts.c b/lib/librte_eal/windows/eal_interrupts.c
index 6c64a48f34..6f7a1c7acc 100644
--- a/lib/librte_eal/windows/eal_interrupts.c
+++ b/lib/librte_eal/windows/eal_interrupts.c
@@ -105,3 +105,9 @@ eal_intr_thread_schedule(void (*func)(void *arg), void *arg)
return 0;
}
+
+void
+rte_intr_free_epoll_fd(struct rte_intr_handle *intr_handle)
+{
+ RTE_SET_USED(intr_handle);
+}
--
2.16.1.windows.4
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [dpdk-dev] [PATCH v2] eal/windows: add stub for rte_intr_free_epoll_fd
2020-11-19 15:18 ` [dpdk-dev] [PATCH v2] " Tal Shnaiderman
@ 2020-12-01 16:42 ` Dmitry Kozlyuk
0 siblings, 0 replies; 5+ messages in thread
From: Dmitry Kozlyuk @ 2020-12-01 16:42 UTC (permalink / raw)
To: Tal Shnaiderman
Cc: dev, thomas, navasile, dmitrym, pallavi.kadam, david.marchand
On Thu, 19 Nov 2020 17:18:11 +0200, Tal Shnaiderman wrote:
> Linux epoll mechanism is not implemented in Windows.
>
> Add stub similarly to freeBSD.
>
> Signed-off-by: Tal Shnaiderman <talshn@nvidia.com>
>
> ---
> v2: add missing export in def file [DavidM]
> ---
> lib/librte_eal/rte_eal_exports.def | 1 +
> lib/librte_eal/windows/eal_interrupts.c | 6 ++++++
> 2 files changed, 7 insertions(+)
Acked-by: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-12-01 16:42 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-19 14:00 [dpdk-dev] [PATCH] eal/windows: add stub for rte_intr_free_epoll_fd Tal Shnaiderman
2020-11-19 15:01 ` David Marchand
2020-11-19 15:08 ` Tal Shnaiderman
2020-11-19 15:18 ` [dpdk-dev] [PATCH v2] " Tal Shnaiderman
2020-12-01 16:42 ` Dmitry Kozlyuk
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).