From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 28582A0524; Thu, 3 Dec 2020 17:08:32 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 33331C954; Thu, 3 Dec 2020 17:08:30 +0100 (CET) Received: from mail-pg1-f196.google.com (mail-pg1-f196.google.com [209.85.215.196]) by dpdk.org (Postfix) with ESMTP id A4156C93E for ; Thu, 3 Dec 2020 17:08:27 +0100 (CET) Received: by mail-pg1-f196.google.com with SMTP id o4so1686057pgj.0 for ; Thu, 03 Dec 2020 08:08:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=KGxBsMspnjgwPCUPM+4RziagikS4Z0Hn+m5NMZEwvNM=; b=D6Dyjlq8b93PtDoAuupjUq+yBPkv2OL4W3H1su2YYJs0X7SlqLGWkcX5qC9tfxx75A BeMMTve9NvJmPhLlEPBFnIIWx2DJPMYPOEaQE4s6QBfKIfTmqJt1C/BQUnjVR0sPwXN7 nEoHcVqoL+ZDDYp3PApoXgv6ZBoBuWVfQYsiUvqhuUa5YZY+yG+70/AAB6/MpYKT8JUB y+ez3GcNQVri4taTi8/tnImB0ZcSZ2BnxN9P4uHfc/SZmkoaklKsSQSHxnBEleno23PX fVO4r6uuSQEhhQCziLZH4rmygykAdg2XXcXC7XKitHk7xaFxgvkjXlrexjMwrysqGnVq NDBg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=KGxBsMspnjgwPCUPM+4RziagikS4Z0Hn+m5NMZEwvNM=; b=AO37SkJyJGt7L078lcEKe4b40ZowlY/F5lBvdTmpCi7ez40ODPObqW/cydu5odl5oL JNdiwT+aqc0bOeBJqwrBfuJNz8dh+yWrvUenbkbPDvR1yTIajjIXKf2Kcji2QQJb13Zw 98u4pb3/ylxpxp1EpVh9gghe59qQWOBCLdJnCt33bg6ZZ4ZWhW7vRrgOZw3Xk/NJvrPa Zes2UHpp0zH/hXD1N+V130OZXixsnZ51psrwnIuHvzLWHNE5SUoCv1tSvbdpIbeY1zpm sq7rXg6LcFH3OzOgUteE8piUioI/rdNKBmkwJyUvdhdH8bSHeRFvBflBGgO6U0A7nYCE i3cA== X-Gm-Message-State: AOAM533lbWvq3cjQfPU+gTNLg9LupCEko7rbM6E2iD+NpOt057sqVKUF gZ3EyNvQsDs8d02vqsrExBVPtw== X-Google-Smtp-Source: ABdhPJxxLKv33UiE3Qp9qfAZBw40t4zxbhlkqLS/VyjTLs9tPyGgdoJHJJYbQunrbU1hUI7FraITyQ== X-Received: by 2002:a63:a62:: with SMTP id z34mr3672949pgk.193.1607011705624; Thu, 03 Dec 2020 08:08:25 -0800 (PST) Received: from hermes.local (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id m77sm2268152pfd.105.2020.12.03.08.08.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 03 Dec 2020 08:08:25 -0800 (PST) Date: Thu, 3 Dec 2020 08:08:12 -0800 From: Stephen Hemminger To: George Prekas Cc: Wenzhuo Lu , Beilei Xing , Bernard Iremonger , Message-ID: <20201203080812.3d9940c9@hermes.local> In-Reply-To: <20201203135954.1127-1-prekageo@amazon.com> References: <20201203135954.1127-1-prekageo@amazon.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] app/testpmd: fix IP checksum calculation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, 3 Dec 2020 07:59:54 -0600 George Prekas wrote: > Insert a compiler barrier to make sure that the IP checksum calculation > happens after setting all the fields of the IP header. > > Signed-off-by: George Prekas I don't think this is necessary. All other OS's don't have to do this. The CPU is going to maintain proper memory order.