From: Stephen Hemminger <stephen@networkplumber.org>
To: Ed Czeck <ed.czeck@atomicrules.com>
Cc: dev@dpdk.org, ferruh.yigit@intel.com, thomas@monjalon.net,
shepard.siegel@atomicrules.com, john.miller@atomicrules.com
Subject: Re: [dpdk-dev] [PATCH] net/ark: export ark timestamp dynfield offset
Date: Fri, 4 Dec 2020 14:31:20 -0800 [thread overview]
Message-ID: <20201204143120.5c488d36@hermes.local> (raw)
In-Reply-To: <20201204202745.24675-1-ed.czeck@atomicrules.com>
On Fri, 4 Dec 2020 15:27:45 -0500
Ed Czeck <ed.czeck@atomicrules.com> wrote:
> Access to mbuf dynfields in application code requires variable
> export through header and dynamic library.
>
> Fixes: a926951a606f ("net/ark: switch Rx timestamp to dynamic mbuf field")
> Cc: thomas@monjalon.net
>
> Signed-off-by: Ed Czeck <ed.czeck@atomicrules.com>
Not happy with having offsets exposed from driver.
Expopsing weird offsets for their special fields
is worse than the old model.
Why not use standardized field name and have the application lookup that?
There is an API already for that.
next prev parent reply other threads:[~2020-12-04 22:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-04 20:27 Ed Czeck
2020-12-04 22:31 ` Stephen Hemminger [this message]
2020-12-06 15:52 ` Thomas Monjalon
2020-12-07 16:35 ` Ed Czeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201204143120.5c488d36@hermes.local \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
--cc=ed.czeck@atomicrules.com \
--cc=ferruh.yigit@intel.com \
--cc=john.miller@atomicrules.com \
--cc=shepard.siegel@atomicrules.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).