From: Bruce Richardson <bruce.richardson@intel.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: Pallavi Kadam <pallavi.kadam@intel.com>,
dev@dpdk.org, ranjit.menon@intel.com, dmitry.kozliuk@gmail.com,
Narcisa.Vasile@microsoft.com, talshn@nvidia.com,
ferruh.yigit@intel.com, beilei.xing@intel.com, jia.guo@intel.com
Subject: Re: [dpdk-dev] [PATCH 2/3] net/i40e: add changes to support i40e PMD on windows
Date: Mon, 7 Dec 2020 09:14:08 +0000 [thread overview]
Message-ID: <20201207091408.GA19@bricha3-MOBL.ger.corp.intel.com> (raw)
In-Reply-To: <1656459.hZBu3j2uRN@thomas>
On Sun, Dec 06, 2020 at 04:49:40PM +0100, Thomas Monjalon wrote:
> 05/12/2020 02:10, Pallavi Kadam:
> > --- a/drivers/net/meson.build
> > +++ b/drivers/net/meson.build
> > @@ -1,9 +1,6 @@
> > # SPDX-License-Identifier: BSD-3-Clause
> > # Copyright(c) 2017 Intel Corporation
> >
> > -if is_windows
> > - subdir_done()
> > -endif
> >
> > drivers = ['af_packet',
> > 'af_xdp',
> > @@ -56,6 +53,12 @@ drivers = ['af_packet',
> > 'virtio',
> > 'vmxnet3',
> > ]
> > +
> > +if is_windows
> > + drivers = ['i40e',
> > + ]
> > +endif
>
> Let's not add an alternative list please.
> I prefer disabling compilation in other drivers.
>
+1 for this. It's more work, but it keeps the existing style where all info
about whether a driver should be built, and how it's built in a single file
for each driver.
next prev parent reply other threads:[~2020-12-07 9:14 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-05 1:10 [dpdk-dev] [PATCH 0/3] Support i40e PMD on Windows Pallavi Kadam
2020-12-05 1:10 ` [dpdk-dev] [PATCH 1/3] eal/windows: add some interrupt functions stub Pallavi Kadam
2020-12-05 1:10 ` [dpdk-dev] [PATCH 2/3] net/i40e: add changes to support i40e PMD on windows Pallavi Kadam
2020-12-05 13:52 ` Dmitry Kozlyuk
2020-12-09 0:09 ` Kadam, Pallavi
2020-12-06 15:49 ` Thomas Monjalon
2020-12-07 9:14 ` Bruce Richardson [this message]
2020-12-09 0:14 ` Kadam, Pallavi
2020-12-09 0:21 ` Kadam, Pallavi
2020-12-09 8:59 ` Thomas Monjalon
2020-12-17 23:17 ` Kadam, Pallavi
2020-12-05 1:10 ` [dpdk-dev] [PATCH 3/3] config/build: ignore enum forward reference warning Pallavi Kadam
2020-12-05 13:51 ` Dmitry Kozlyuk
2020-12-10 0:53 ` Narcisa Ana Maria Vasile
2020-12-17 23:15 ` Kadam, Pallavi
2020-12-17 22:59 ` [dpdk-dev] [PATCH v2 0/2] Support i40e PMD on Windows Pallavi Kadam
2020-12-17 22:59 ` [dpdk-dev] [PATCH v2 1/2] eal: add rte_random.c file on windows Pallavi Kadam
2020-12-18 11:29 ` Thomas Monjalon
2020-12-18 18:49 ` Kadam, Pallavi
2020-12-17 22:59 ` [dpdk-dev] [PATCH v2 2/2] build: i40e PMD on Windows Pallavi Kadam
2020-12-18 11:27 ` Thomas Monjalon
2020-12-18 18:42 ` Kadam, Pallavi
2020-12-22 0:45 ` [dpdk-dev] [PATCH v3 0/2] Support " Pallavi Kadam
2020-12-22 0:45 ` [dpdk-dev] [PATCH v3 1/2] eal: add rte_random.c file on windows Pallavi Kadam
2020-12-22 0:45 ` [dpdk-dev] [PATCH v3 2/2] build: i40e PMD on Windows Pallavi Kadam
2021-01-08 22:58 ` Jie Zhou
2021-01-13 22:52 ` Thomas Monjalon
2021-01-13 22:55 ` Ranjit Menon
2021-01-13 23:10 ` Thomas Monjalon
2021-01-14 1:51 ` Tal Shnaiderman
2021-01-14 22:55 ` [dpdk-dev] [PATCH v3 0/2] Support " Thomas Monjalon
2021-01-14 23:06 ` Ranjit Menon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201207091408.GA19@bricha3-MOBL.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=Narcisa.Vasile@microsoft.com \
--cc=beilei.xing@intel.com \
--cc=dev@dpdk.org \
--cc=dmitry.kozliuk@gmail.com \
--cc=ferruh.yigit@intel.com \
--cc=jia.guo@intel.com \
--cc=pallavi.kadam@intel.com \
--cc=ranjit.menon@intel.com \
--cc=talshn@nvidia.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).