From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by inbox.dpdk.org (Postfix) with ESMTP id A9B9AA0524;
	Mon,  7 Dec 2020 10:14:20 +0100 (CET)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id DE20DF72;
	Mon,  7 Dec 2020 10:14:18 +0100 (CET)
Received: from mga09.intel.com (mga09.intel.com [134.134.136.24])
 by dpdk.org (Postfix) with ESMTP id 74D43F12
 for <dev@dpdk.org>; Mon,  7 Dec 2020 10:14:17 +0100 (CET)
IronPort-SDR: TIG98nQgjtnFT7Ztda3rEx9ETiaDX3vjt6Sd16Ma6vkPKqRcGslgr9yKyoTmlm6oTxu/zNu3OU
 ePB3QvTLI8MA==
X-IronPort-AV: E=McAfee;i="6000,8403,9827"; a="173821351"
X-IronPort-AV: E=Sophos;i="5.78,399,1599548400"; d="scan'208";a="173821351"
Received: from fmsmga008.fm.intel.com ([10.253.24.58])
 by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
 07 Dec 2020 01:14:14 -0800
IronPort-SDR: 9TcbBcZMdlEqJXNlZw2X4wVPF0dZvAdkPL5kCyEGcUluUl6HUh9i3XXbFnqsGkaNXYeDQDCvx4
 Rr2z89CKPx2A==
X-IronPort-AV: E=Sophos;i="5.78,399,1599548400"; d="scan'208";a="317045814"
Received: from bricha3-mobl.ger.corp.intel.com ([10.252.10.3])
 by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA;
 07 Dec 2020 01:14:12 -0800
Date: Mon, 7 Dec 2020 09:14:08 +0000
From: Bruce Richardson <bruce.richardson@intel.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: Pallavi Kadam <pallavi.kadam@intel.com>, dev@dpdk.org,
 ranjit.menon@intel.com, dmitry.kozliuk@gmail.com,
 Narcisa.Vasile@microsoft.com, talshn@nvidia.com,
 ferruh.yigit@intel.com, beilei.xing@intel.com, jia.guo@intel.com
Message-ID: <20201207091408.GA19@bricha3-MOBL.ger.corp.intel.com>
References: <20201205011020.6276-1-pallavi.kadam@intel.com>
 <20201205011020.6276-3-pallavi.kadam@intel.com>
 <1656459.hZBu3j2uRN@thomas>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1656459.hZBu3j2uRN@thomas>
Subject: Re: [dpdk-dev] [PATCH 2/3] net/i40e: add changes to support i40e
 PMD on windows
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Sun, Dec 06, 2020 at 04:49:40PM +0100, Thomas Monjalon wrote:
> 05/12/2020 02:10, Pallavi Kadam:
> > --- a/drivers/net/meson.build
> > +++ b/drivers/net/meson.build
> > @@ -1,9 +1,6 @@
> >  # SPDX-License-Identifier: BSD-3-Clause
> >  # Copyright(c) 2017 Intel Corporation
> >  
> > -if is_windows
> > -	subdir_done()
> > -endif
> >  
> >  drivers = ['af_packet',
> >  	'af_xdp',
> > @@ -56,6 +53,12 @@ drivers = ['af_packet',
> >  	'virtio',
> >  	'vmxnet3',
> >  ]
> > +
> > +if is_windows
> > +	drivers = ['i40e',
> > +	]
> > +endif
> 
> Let's not add an alternative list please.
> I prefer disabling compilation in other drivers.
> 
+1 for this. It's more work, but it keeps the existing style where all info
about whether a driver should be built, and how it's built in a single file
for each driver.