From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5F914A04E6; Mon, 7 Dec 2020 18:48:04 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id BB361F72; Mon, 7 Dec 2020 18:48:02 +0100 (CET) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id D9255F12 for ; Mon, 7 Dec 2020 18:47:59 +0100 (CET) IronPort-SDR: 9lWUodDxKcGPpJe8TsCh/05mVJVrqYtzL0hxpeOGfSXzs2d73p3HfqjRGcUXTsZKf3c0BRvWAY D5Yst5LbhnAg== X-IronPort-AV: E=McAfee;i="6000,8403,9828"; a="153554337" X-IronPort-AV: E=Sophos;i="5.78,400,1599548400"; d="scan'208";a="153554337" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Dec 2020 09:47:59 -0800 IronPort-SDR: p8fPiExLfTEKufScS7OTV3+Uyhab2o7gPuNLdgT9TFzahuERZG3J0ZxISjbykVthIo6poUrAvc dAlAEPC9fG/w== X-IronPort-AV: E=Sophos;i="5.78,400,1599548400"; d="scan'208";a="317272755" Received: from bricha3-mobl.ger.corp.intel.com ([10.252.10.3]) by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 07 Dec 2020 09:47:58 -0800 Date: Mon, 7 Dec 2020 17:47:54 +0000 From: Bruce Richardson To: Thomas Monjalon Cc: dev@dpdk.org, david.marchand@redhat.com Message-ID: <20201207174754.GA24@bricha3-MOBL.ger.corp.intel.com> References: <20201207173319.1397740-1-thomas@monjalon.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201207173319.1397740-1-thomas@monjalon.net> Subject: Re: [dpdk-dev] [PATCH 1/1] devtools: avoid installing static binaries X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, Dec 07, 2020 at 06:33:19PM +0100, Thomas Monjalon wrote: > When testing compilation and checking ABI compatibility, > there is no real need of static binaries eating disks. > The static linkage of applications are tested with GCC and Clang, > plus some examples are statically linked. > The after-installation build test is limited to "helloworld" example. > Note the meson static build test was already limited to "l3fwd" example. > > The ABI compatibility is checked on shared libraries, so no need > running this test a second time on builds intended for static linking. > However, limiting ABI check to "shared builds" means all test cases > must have a "shared build" occurence. > As a consequence the 32-bit build test is switched to shared linking. > > Signed-off-by: Thomas Monjalon > --- > devtools/test-meson-builds.sh | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-) I think this might be better as two patches - one for the ABI check changes and a second for the example build changes with installed DPDK. > > diff --git a/devtools/test-meson-builds.sh b/devtools/test-meson-builds.sh > index 7280b7a93d..ed44d4ffb1 100755 > --- a/devtools/test-meson-builds.sh > +++ b/devtools/test-meson-builds.sh > @@ -166,6 +166,9 @@ build () # > config $srcdir $builds_dir/$targetdir $cross --werror $* > compile $builds_dir/$targetdir > if [ -n "$DPDK_ABI_REF_VERSION" ]; then > + if echo $* | grep -qw -- '--default-library=static' ; then > + return # skip ABI check for static build > + fi > abirefdir=${DPDK_ABI_REF_DIR:-reference}/$DPDK_ABI_REF_VERSION > if [ ! -d $abirefdir/$targetdir ]; then > # clone current sources > @@ -230,7 +233,7 @@ if check_cc_flags '-m32' ; then > export PKG_CONFIG_LIBDIR='/usr/lib/pkgconfig' > fi > target_override='i386-pc-linux-gnu' > - build build-32b cc -Dc_args='-m32' -Dc_link_args='-m32' > + build build-32b cc -Dc_args='-m32' -Dc_link_args='-m32' $use_shared > target_override= > unset PKG_CONFIG_LIBDIR > fi > @@ -274,7 +277,8 @@ if pkg-config --define-prefix libdpdk >/dev/null 2>&1; then > export PKGCONF="pkg-config --define-prefix" > for example in $examples; do > echo "## Building $example" > + [ $example = helloworld ] && static=static || static= # save disk space > $MAKE -C $DESTDIR/usr/local/share/dpdk/examples/$example \ > - clean shared static >&$veryverbose > + clean shared $static >&$veryverbose > done > fi Just wonder are we likely to miss things with this change? Would changing the order to do a clean at the end to free back up the disk space not achieve much the same result while still saving disk space?