From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 22EE9A09E9; Wed, 9 Dec 2020 04:22:24 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id E6E12C9DA; Wed, 9 Dec 2020 04:21:12 +0100 (CET) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id B843DC9D6 for ; Wed, 9 Dec 2020 04:21:11 +0100 (CET) IronPort-SDR: FqQQhGaqdT9M/E5q+nZ6/twrjJYsAiRbaL4bGt7WD+I7rH90YOQWDY2/Qqizcmp4aDJnQM4q21 ZDX2u+a7KdYg== X-IronPort-AV: E=McAfee;i="6000,8403,9829"; a="173251975" X-IronPort-AV: E=Sophos;i="5.78,404,1599548400"; d="scan'208";a="173251975" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Dec 2020 19:21:09 -0800 IronPort-SDR: v82VILHxfshAq6BXm4M6e0QFqBQUmcBPdwXPq+xrOq6jKndFG/MauSZGqaK0MJQinhkO02tJlN 9jaQgWOx4/Zw== X-IronPort-AV: E=Sophos;i="5.78,404,1599548400"; d="scan'208";a="363949114" Received: from intel-npg-odc-srv01.cd.intel.com ([10.240.178.136]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Dec 2020 19:20:58 -0800 From: Steve Yang To: dev@dpdk.org Cc: hemant.agrawal@nxp.com, sachin.saxena@oss.nxp.com, jia.guo@intel.com, haiyue.wang@intel.com, xavier.huwei@huawei.com, humin29@huawei.com, yisen.zhuang@huawei.com, oulijun@huawei.com, beilei.xing@intel.com, jingjing.wu@intel.com, qiming.yang@intel.com, qi.z.zhang@intel.com, rosen.xu@intel.com, hkalra@marvell.com, jerinj@marvell.com, ndabilpuram@marvell.com, kirankumark@marvell.com, rmody@marvell.com, shshaikh@marvell.com, andrew.rybchenko@oktetlabs.ru, mczekaj@marvell.com, wei.dai@intel.com, fengchunsong@huawei.com, lihuisong@huawei.com, ferruh.yigit@intel.com, chenhao164@huawei.com, helin.zhang@intel.com, konstantin.ananyev@intel.com, yanglong.wu@intel.com, xiaolong.ye@intel.com, ting.xu@intel.com, xiaoyun.li@intel.com, wenzhuo.lu@intel.com, andy.pei@intel.com, dan.wei@intel.com, skori@marvell.com, vattunuru@marvell.com, sony.chacko@qlogic.com, bruce.richardson@intel.com, ivan.malov@oktetlabs.ru, zyta.szpak@semihalf.com, slawomir.rosek@semihalf.com, rad@semihalf.com, Steve Yang Date: Wed, 9 Dec 2020 03:16:26 +0000 Message-Id: <20201209031628.29572-11-stevex.yang@intel.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20201209031628.29572-1-stevex.yang@intel.com> References: <20201209031628.29572-1-stevex.yang@intel.com> Subject: [dpdk-dev] [PATCH v1 10/12] net/qede: fix the jumbo frame flag condition for mtu set X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" The jumbo frame uses the 'RTE_ETHER_MAX_LEN' as boundary condition, but the Ether overhead is larger than 18 when it supports dual VLAN tags. That will cause the jumbo flag rx offload is wrong when MTU size is 'RTE_ETHER_MTU'. This fix will change the boundary condition with 'RTE_ETHER_MTU'. Fixes: 200645ac7909 ("net/qede: set MTU") Signed-off-by: Steve Yang --- drivers/net/qede/qede_ethdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/qede/qede_ethdev.c b/drivers/net/qede/qede_ethdev.c index 549013557c..d6f0f0a493 100644 --- a/drivers/net/qede/qede_ethdev.c +++ b/drivers/net/qede/qede_ethdev.c @@ -2367,7 +2367,7 @@ static int qede_set_mtu(struct rte_eth_dev *dev, uint16_t mtu) fp->rxq->rx_buf_size = rc; } } - if (max_rx_pkt_len > RTE_ETHER_MAX_LEN) + if (mtu > RTE_ETHER_MTU) dev->data->dev_conf.rxmode.offloads |= DEV_RX_OFFLOAD_JUMBO_FRAME; else dev->data->dev_conf.rxmode.offloads &= ~DEV_RX_OFFLOAD_JUMBO_FRAME; -- 2.17.1