DPDK patches and discussions
 help / color / mirror / Atom feed
From: Souvik Dey <sodey@rbbn.com>
To: rasland@nvidia.com, matan@nvidia.com, shahafs@nvidia.com,
	viacheslavo@nvidia.com
Cc: dev@dpdk.org, Souvik Dey <sodey@rbbn.com>
Subject: [dpdk-dev] [PATCH] net/mlx5:fix storing the synced MAC to internal table
Date: Wed,  9 Dec 2020 10:11:07 -0500	[thread overview]
Message-ID: <20201209151108.12352-1-sodey@rbbn.com> (raw)

During the mlx5_dev_spawn(), it tries to sync the MAC address of the
Device to the internal MAC table. In case of SR-IOV VF , the 
mlx5_nl_mac_addr_sync() gets, 2 MAC address in the fresh start. 
One the unicast MAC assigned to the VF on the host and the second
the multicast mac of 33:33:00:00:00:01. Currently without check the 
type of MAC we try to add the MAC 33:33:00:00:00:01 to the first free
place in the MAC table which will be mostly index 1, as index 0 stores 
the unicast MAC assigned to the VF. This causes issues subsequently
when we try to add multicast address list. As every IPv6 IP generates 
differnet multicast MAC, to support multiple IP on a single interface, 
we need to add a list of multicast MAC. As an example, if we try to 
add 3 multicast MAC as mentioned below
mcast addr 0 - 33:33:00:00:00:01
mcast addr 1 - 01:00:5e:00:00:01
mcast addr 2 - 33:33:ff:68:fe:7d
then, the addition of these MAC will fail with error -EADDRINUSE in 
mlx5_internal_mac_addr_add(), and none of the MAC address will be 
added to the device, which will lead of packet drop in case multicast
promiscuous is not enable.
To make this work, we should store the synced MAC to the proper section 
of the internal table, after checking the type of the MAC synced. This
check will make the MAC of 33:33:00:00:00:01(synced MAC) to be stored at 
index 128(starting of MLX5_MAX_MC_MAC_ADDRESSES), which will be removed 
and added again during the mlx5_set_mc_addr_list(). This will make sure 
that all the multicast MACs are added properly to both the internal table
and also the device, specially in case of SR-IOV VF.

Souvik Dey (1):
  net/mlx5:fix storing the synced MAC to internal table

 drivers/common/mlx5/linux/mlx5_nl.c | 20 +++++++++++++++-----
 1 file changed, 15 insertions(+), 5 deletions(-)

-- 
2.9.3.windows.1


             reply	other threads:[~2020-12-09 15:11 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-09 15:11 Souvik Dey [this message]
2020-12-09 15:11 ` Souvik Dey
2021-01-21 16:56   ` Slava Ovsiienko
2021-02-02  3:53   ` [dpdk-dev] [PATCH v2] common/mlx5: fix storing the synched " Dey, Souvik
2021-02-02 12:58     ` Slava Ovsiienko
2021-02-02 17:48     ` [dpdk-dev] [PATCH v3] " Dey, Souvik
2021-02-03  8:04       ` Slava Ovsiienko
2021-02-03 12:09         ` Dey, Souvik
2021-02-03 14:15           ` Slava Ovsiienko
2021-02-03 14:34             ` Raslan Darawsheh
2021-02-04 10:43       ` Raslan Darawsheh
  -- strict thread matches above, loose matches on Subject: below --
2020-12-09 13:42 [dpdk-dev] [PATCH] net/mlx5:fix storing the synced " Souvik Dey
2020-12-09 13:42 ` Souvik Dey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201209151108.12352-1-sodey@rbbn.com \
    --to=sodey@rbbn.com \
    --cc=dev@dpdk.org \
    --cc=matan@nvidia.com \
    --cc=rasland@nvidia.com \
    --cc=shahafs@nvidia.com \
    --cc=viacheslavo@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).