* [dpdk-dev] [PATCH] net/netvsc: ignore NVS_TYPE_TXTBL_NOTE while executing a sync command
@ 2020-12-11 7:52 Long Li
2020-12-11 17:21 ` Stephen Hemminger
0 siblings, 1 reply; 3+ messages in thread
From: Long Li @ 2020-12-11 7:52 UTC (permalink / raw)
To: Stephen Hemminger; +Cc: dev, Long Li, stable
From: Long Li <longli@microsoft.com>
On netvsc initialization, the host VSP may send a NVS_TYPE_TXTBL_NOTE packet
while executing a VSP command synchronously.
Ignore this packet as we don't use it for DPDK.
Cc: stable@dpdk.org
Signed-off-by: Long Li <longli@microsoft.com>
---
drivers/net/netvsc/hn_nvs.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/drivers/net/netvsc/hn_nvs.c b/drivers/net/netvsc/hn_nvs.c
index a0ee7d8bfa..b6aa07cc5f 100644
--- a/drivers/net/netvsc/hn_nvs.c
+++ b/drivers/net/netvsc/hn_nvs.c
@@ -97,8 +97,13 @@ __hn_nvs_execute(struct hn_data *hv,
hdr = (struct hn_nvs_hdr *)buffer;
/* Silently drop received packets while waiting for response */
- if (hdr->type == NVS_TYPE_RNDIS) {
+ switch (hdr->type) {
+ case NVS_TYPE_RNDIS:
hn_nvs_ack_rxbuf(chan, xactid);
+ /* fallthrough */
+
+ case NVS_TYPE_TXTBL_NOTE:
+ PMD_DRV_LOG(NOTICE, "discard packet type %x", hdr->type);
goto retry;
}
--
2.25.1
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [dpdk-dev] [PATCH] net/netvsc: ignore NVS_TYPE_TXTBL_NOTE while executing a sync command
2020-12-11 7:52 [dpdk-dev] [PATCH] net/netvsc: ignore NVS_TYPE_TXTBL_NOTE while executing a sync command Long Li
@ 2020-12-11 17:21 ` Stephen Hemminger
2020-12-11 20:05 ` Long Li
0 siblings, 1 reply; 3+ messages in thread
From: Stephen Hemminger @ 2020-12-11 17:21 UTC (permalink / raw)
To: Long Li; +Cc: Stephen Hemminger, dev, Long Li, stable
On Thu, 10 Dec 2020 23:52:44 -0800
Long Li <longli@linuxonhyperv.com> wrote:
> From: Long Li <longli@microsoft.com>
>
> On netvsc initialization, the host VSP may send a NVS_TYPE_TXTBL_NOTE packet
> while executing a VSP command synchronously.
>
> Ignore this packet as we don't use it for DPDK.
>
> Cc: stable@dpdk.org
> Signed-off-by: Long Li <longli@microsoft.com>
> ---
> drivers/net/netvsc/hn_nvs.c | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/netvsc/hn_nvs.c b/drivers/net/netvsc/hn_nvs.c
> index a0ee7d8bfa..b6aa07cc5f 100644
> --- a/drivers/net/netvsc/hn_nvs.c
> +++ b/drivers/net/netvsc/hn_nvs.c
> @@ -97,8 +97,13 @@ __hn_nvs_execute(struct hn_data *hv,
> hdr = (struct hn_nvs_hdr *)buffer;
>
> /* Silently drop received packets while waiting for response */
> - if (hdr->type == NVS_TYPE_RNDIS) {
> + switch (hdr->type) {
> + case NVS_TYPE_RNDIS:
> hn_nvs_ack_rxbuf(chan, xactid);
> + /* fallthrough */
> +
> + case NVS_TYPE_TXTBL_NOTE:
> + PMD_DRV_LOG(NOTICE, "discard packet type %x", hdr->type);
> goto retry;
> }
>
Could you change that log message to DEBUG (or INFO) level?
Users probably don't need to see it.
Acked-by: Stephen Hemminger <stephen@networkplumber.org>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [dpdk-dev] [PATCH] net/netvsc: ignore NVS_TYPE_TXTBL_NOTE while executing a sync command
2020-12-11 17:21 ` Stephen Hemminger
@ 2020-12-11 20:05 ` Long Li
0 siblings, 0 replies; 3+ messages in thread
From: Long Li @ 2020-12-11 20:05 UTC (permalink / raw)
To: Stephen Hemminger, Long Li; +Cc: Stephen Hemminger, dev, stable
> Subject: Re: [dpdk-dev] [PATCH] net/netvsc: ignore NVS_TYPE_TXTBL_NOTE
> while executing a sync command
>
> On Thu, 10 Dec 2020 23:52:44 -0800
> Long Li <longli@linuxonhyperv.com> wrote:
>
> > From: Long Li <longli@microsoft.com>
> >
> > On netvsc initialization, the host VSP may send a NVS_TYPE_TXTBL_NOTE
> > packet while executing a VSP command synchronously.
> >
> > Ignore this packet as we don't use it for DPDK.
> >
> > Cc: stable@dpdk.org
> > Signed-off-by: Long Li <longli@microsoft.com>
> > ---
> > drivers/net/netvsc/hn_nvs.c | 7 ++++++-
> > 1 file changed, 6 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/net/netvsc/hn_nvs.c b/drivers/net/netvsc/hn_nvs.c
> > index a0ee7d8bfa..b6aa07cc5f 100644
> > --- a/drivers/net/netvsc/hn_nvs.c
> > +++ b/drivers/net/netvsc/hn_nvs.c
> > @@ -97,8 +97,13 @@ __hn_nvs_execute(struct hn_data *hv,
> > hdr = (struct hn_nvs_hdr *)buffer;
> >
> > /* Silently drop received packets while waiting for response */
> > - if (hdr->type == NVS_TYPE_RNDIS) {
> > + switch (hdr->type) {
> > + case NVS_TYPE_RNDIS:
> > hn_nvs_ack_rxbuf(chan, xactid);
> > + /* fallthrough */
> > +
> > + case NVS_TYPE_TXTBL_NOTE:
> > + PMD_DRV_LOG(NOTICE, "discard packet type %x", hdr-
> >type);
> > goto retry;
> > }
> >
>
> Could you change that log message to DEBUG (or INFO) level?
> Users probably don't need to see it.
Sure, I'm sending a v2.
>
> Acked-by: Stephen Hemminger <stephen@networkplumber.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-12-11 20:05 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-11 7:52 [dpdk-dev] [PATCH] net/netvsc: ignore NVS_TYPE_TXTBL_NOTE while executing a sync command Long Li
2020-12-11 17:21 ` Stephen Hemminger
2020-12-11 20:05 ` Long Li
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).