From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 49D73A09FD;
	Fri, 18 Dec 2020 18:16:07 +0100 (CET)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id EC145CAF7;
	Fri, 18 Dec 2020 18:15:15 +0100 (CET)
Received: from mail-pf1-f179.google.com (mail-pf1-f179.google.com
 [209.85.210.179]) by dpdk.org (Postfix) with ESMTP id 63889CAD2
 for <dev@dpdk.org>; Fri, 18 Dec 2020 18:15:13 +0100 (CET)
Received: by mail-pf1-f179.google.com with SMTP id t22so1923047pfl.3
 for <dev@dpdk.org>; Fri, 18 Dec 2020 09:15:13 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=networkplumber-org.20150623.gappssmtp.com; s=20150623;
 h=date:from:to:cc:subject:message-id:in-reply-to:references
 :mime-version:content-transfer-encoding;
 bh=kByYv8Owuh0PZ2aUiEf2+iVijhWGncXrkD7iaRiQ1HM=;
 b=ukvXSSNwcKDxRV1558p/5mK/EN2K96SYAN2D8VXrdIT2vaRvMVj3i+gaEEd2cc6H4o
 p8xamzZQ0mNlPpw0AacYB364zgwdAlPX/DNXKFPKdVKoGF57ZBLFbCKVwR7If2HCI12c
 /59xQ6PDqUsYZAvYI/DosqK5tK6LSf8MKStr5gvSD1yJBKd1VTCO0cZX1zwaTICKinGH
 b4KvLhfGWDE4A44SFe7fXwXq6lmV16Wywz6AghQcaTCF0NBoyMTZJAFGsrj2BVo4TFf5
 8his8XCmOwH2zN6xAwG5uIw52LR3yhiYgeNpBRoatKcd06OCL/c4iZkNw66FG0uksDjR
 CC0w==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to
 :references:mime-version:content-transfer-encoding;
 bh=kByYv8Owuh0PZ2aUiEf2+iVijhWGncXrkD7iaRiQ1HM=;
 b=NS6e2eXm+atf9tS4jBXAoDZ9eKwA9XTVNMSq5IdCx0KNjNCbB54QRJclyBg0Z4VqvF
 Fq6RQ/R4beZrjirGHGSOvCrduAOKE/v2Zdbl80H7MpVAu5aryA19RbmyiJy+RG5r4Zb/
 00aIdH/n9BgqKQPmC/7os/L+hpbXBZCRjXIu3F9OvoxqQASv7tfgHPWRVOMAXT7l7KHo
 SfumcyDCFIyAyxo0HsFbRm8TcYmhsQaXaV0eObuq/PxpnvajkqADQ72+zxF2VX0vITLq
 ofKnqPWOn5u4vYkT5Rtt2xnjxHv5+3pCIeLth95vEc6ouT/7pRS0ju0x2yLyhbRLEO8g
 /8mw==
X-Gm-Message-State: AOAM531mVqibSwbsAq8y1sMkQfpepQ6PF4ESynE5lpywGTt+NKSutwH1
 3mRbUv6yw0AwNhx/NXSkdx0SAdUYLLxgoE14
X-Google-Smtp-Source: ABdhPJwd/5t1m29XheSBz2IZpvv3TxyVuDNHIC4fGkCf/xJ0IFqEQ/ALwKduBE9polglQhnZeiTHww==
X-Received: by 2002:a65:47c7:: with SMTP id f7mr1013733pgs.305.1608311711633; 
 Fri, 18 Dec 2020 09:15:11 -0800 (PST)
Received: from hermes.local (204-195-22-127.wavecable.com. [204.195.22.127])
 by smtp.gmail.com with ESMTPSA id w90sm2133472pjw.10.2020.12.18.09.15.10
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Fri, 18 Dec 2020 09:15:11 -0800 (PST)
Date: Fri, 18 Dec 2020 09:13:58 -0800
From: Stephen Hemminger <stephen@networkplumber.org>
To: Chenbo Xia <chenbo.xia@intel.com>
Cc: dev@dpdk.org, thomas@monjalon.net, david.marchand@redhat.com,
 cunming.liang@intel.com, xiuchun.lu@intel.com, miao.li@intel.com,
 jingjing.wu@intel.com
Message-ID: <20201218091358.03a82d69@hermes.local>
In-Reply-To: <20201218073851.93609-2-chenbo.xia@intel.com>
References: <20201218073851.93609-1-chenbo.xia@intel.com>
 <20201218073851.93609-2-chenbo.xia@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [PATCH 1/9] lib: introduce vfio-user library
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Fri, 18 Dec 2020 15:38:43 +0800
Chenbo Xia <chenbo.xia@intel.com> wrote:

> +inline void vfio_user_close_msg_fds(VFIO_USER_MSG *msg)
> +{
> +	int i;
> +
> +	for (i = 0; i < msg->fd_num; i++)
> +		close(msg->fds[i]);
> +}
> +

Please don't use non-static inlines.