From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id DC4DFA09EF; Mon, 21 Dec 2020 15:39:08 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id A068D2B8E; Mon, 21 Dec 2020 15:39:06 +0100 (CET) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by dpdk.org (Postfix) with ESMTP id 4E7D9CB79; Mon, 21 Dec 2020 15:39:04 +0100 (CET) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 0BLEaHiJ028636; Mon, 21 Dec 2020 06:39:02 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=date : from : to : cc : subject : message-id : references : content-type : in-reply-to : mime-version; s=pfpt0220; bh=tNb0s10X4K2Y9ejbGfenku+M7mf4jOzc8crE21jOQto=; b=lDclN23E7j9Q7vNs2wIQsiAK6TaWYaIpNzYF/i7hywcf0LHQgCErPgPjMCINnZv6Ets4 rh1qIfReWngz9nVE7woXSFRVEDT8SlRC6ZMq/oimtuXDgyi0LYFSw02pIbZZo6rQUqdD YSP4sYGE3hB3Yo3qosp0lAITmqSyYm25TQL1UmCLONF7XaFeQPUItHYPwYP1K4/YYa+8 4J8vJaXBiRP8Z3hhJ8lvwycskMiNKC9e3OH3cFp4Muovxw6QsMknEn4kr59mdym1RPeB AvzoLaLqwvBFLnPQVQSWN8QOgYnDaaRHsEEQUjViR2BZTwdTG0sOTgwdtcH7KpdUtoZZ vw== Received: from sc-exch01.marvell.com ([199.233.58.181]) by mx0b-0016f401.pphosted.com with ESMTP id 35j4wvjf8k-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Mon, 21 Dec 2020 06:39:02 -0800 Received: from DC5-EXCH02.marvell.com (10.69.176.39) by SC-EXCH01.marvell.com (10.93.176.81) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Mon, 21 Dec 2020 06:39:00 -0800 Received: from SC-EXCH03.marvell.com (10.93.176.83) by DC5-EXCH02.marvell.com (10.69.176.39) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Mon, 21 Dec 2020 06:38:59 -0800 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.177) by SC-EXCH03.marvell.com (10.93.176.83) with Microsoft SMTP Server (TLS) id 15.0.1497.2 via Frontend Transport; Mon, 21 Dec 2020 06:38:59 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XKinRrQoK4WuPxzNl0r/O+6j7qbWQww6XUu3oSblB+QYwngDvt6/IPecJ9frMWvbXuiM+LVsy8QVoV0UAWJ38fcMinB/otwLucSqSTCHqWr4+3uemXGXJpvqFCkUHeu4Z2Y/JIlnfjrZ2e6q/XvyhUPBbhnaK8HHgxG4tye0K1TQFYSRQGNcOKiGN29M9GeLBTU9opIjI0x9cvt2CRTMmmFJ+12T8oT04YjgIoGb1aSsAjMkuVkEVKcvb1mJmKeJkwbfq4wvV4CpueShfeDOovoPX0atZTn4LBzrkuVWwBlOFQuG+gk51LqKNYa45VuW4JLdKc/XfWb9TZaHqpMSug== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=tNb0s10X4K2Y9ejbGfenku+M7mf4jOzc8crE21jOQto=; b=j74A+mxvFYQEaYjePCFmGMIXjeT4/yyCKNqqn13MFvzD1Qqs00XcsFqjnPKb3tS0cMBdaZqqdHTMMYp2kyEqvhD4ktwDukMykwurLkdC79pLLcO8UAM6XLOT1+Zbdz9Mjggh2hAGLqW9roPczGpmYrF6KmkOU3gNa+EJJYt27nhaqyHZqo1T6jOsetaei61eHlBRx62PF/TzxvqcHzhJsJqNNCHa12mlqNSyb8NJT73y/5u6qyUcrhMk3128ILok80YBtYH78MgHyYjPSuArmWQvLCyRjY+jwUZrgvPOMEXHDT/IbbhmCkdZW7eM6HKOhabT/goRMag9FiIG1dLY7Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=tNb0s10X4K2Y9ejbGfenku+M7mf4jOzc8crE21jOQto=; b=QNPJG0+ipB5Rw0lzy6yqzLqrhOm47jxYPKXR+xF12TskQ+c/QXtZDB4/Id4H0RuUA/ahw41bNn7n9Jkx4CxiM9Zy0PY0Wordt/8Km+kqyqJwS/9bkIyOSvgyS+F35/NObEFaiHNMJntRvyPkfnBm4j1Y5CilxXyBACTPy6voMzM= Authentication-Results: huawei.com; dkim=none (message not signed) header.d=none;huawei.com; dmarc=none action=none header.from=marvell.com; Received: from CO6PR18MB3842.namprd18.prod.outlook.com (2603:10b6:5:341::16) by MWHPR1801MB1902.namprd18.prod.outlook.com (2603:10b6:301:68::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3676.33; Mon, 21 Dec 2020 14:38:57 +0000 Received: from CO6PR18MB3842.namprd18.prod.outlook.com ([fe80::444a:e47f:bdc:370c]) by CO6PR18MB3842.namprd18.prod.outlook.com ([fe80::444a:e47f:bdc:370c%7]) with mapi id 15.20.3676.033; Mon, 21 Dec 2020 14:38:57 +0000 Date: Mon, 21 Dec 2020 20:08:42 +0530 From: Harman Kalra To: wangyunjian CC: "dev@dpdk.org" , "david.marchand@redhat.com" , "ferruh.yigit@intel.com" , Thomas Monjalon , "Lilijun (Jerry)" , xudingke , "stable@dpdk.org" Message-ID: <20201221143840.GA853@outlook.office365.com> References: <2dc88362a7dc347547eb24e5d0570db11a59598e.1594780487.git.wangyunjian@huawei.com> <34EFBCA9F01B0748BEB6B629CE643AE60DA5CEA2@dggemm513-mbx.china.huawei.com> <20200922103141.GA54896@outlook.office365.com> <34EFBCA9F01B0748BEB6B629CE643AE60DAEBC3A@dggemm513-mbx.china.huawei.com> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <34EFBCA9F01B0748BEB6B629CE643AE60DAEBC3A@dggemm513-mbx.china.huawei.com> User-Agent: Mutt/1.10.0 (2018-05-17) X-Originating-IP: [1.6.215.26] X-ClientProxiedBy: MA1PR0101CA0052.INDPRD01.PROD.OUTLOOK.COM (2603:1096:a00:20::14) To CO6PR18MB3842.namprd18.prod.outlook.com (2603:10b6:5:341::16) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from outlook.office365.com (1.6.215.26) by MA1PR0101CA0052.INDPRD01.PROD.OUTLOOK.COM (2603:1096:a00:20::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3676.28 via Frontend Transport; Mon, 21 Dec 2020 14:38:54 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 21cfb4ed-aab8-4530-9751-08d8a5be25ea X-MS-TrafficTypeDiagnostic: MWHPR1801MB1902: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:8273; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: UExmXiatnp5L/q6cv4d6+FMUOgSmeYAMIbVD0DkhP351rAw5a2H5bZ9Nlo57SgHN55DUZ40kaVZqRcZCXW1I1OXKyBTXBOcpi84Mb3nFp/2TvcZUGXLu5sezNGw/99Kb3HjAGrxnek2g15857pwBYlRvEcLkqgciVDh0rBIi0MzfFTxrHtk9s3wyq23dVV/3zFqt1rszPedngZpNRi9nrX4lEDFHYdB1cb+XApFdp+Z3Jrs3wc3tw0z8vT8tuneUCQ2I8hUGWPFGFm7V39OAjDL/IG8kgcw9YPkDeVPznMM4c8hG5hX4Pe+SYcg0+nhuHFVRQl9+1bGQjipEbDoW1JrJlnlAQf3JuQkk3wuNlg6pKpNFVGHN9OpoB1/v54lr8KqiHWMJRTs3rRyqvaStf59yHND0PbAmVabBmkFrMNTgY165q6DU9owAO97+FM9rpAPQivFT22GhSddLfwvibw== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CO6PR18MB3842.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(39860400002)(376002)(346002)(136003)(396003)(53546011)(186003)(26005)(54906003)(16526019)(83380400001)(2906002)(6506007)(4326008)(956004)(1006002)(6666004)(316002)(9686003)(33656002)(8936002)(478600001)(1076003)(55016002)(8676002)(66476007)(66946007)(5660300002)(86362001)(52116002)(6916009)(66556008)(7696005)(36456004)(42976004); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?us-ascii?Q?oJ0tKGQJSImz6Taf26gpV/HWRTLsW3av9vux1+pVgBIP7oqj1DimoOcymNLP?= =?us-ascii?Q?hzlBJ6zxo73wyImo9IMzDebEGkY/qGOI+YtHlImUERiEutVd4pkHSb+OpeWY?= =?us-ascii?Q?tQZZXgOGfKKq812wnKiwAgiQ7guxx1cJw/VFjuTE1vW9Okr+80VFsGfIvOn5?= =?us-ascii?Q?vBrM2LAIuXRkju00snh+k33uGNz1HTxyEy3lvpyBAWFw9h0XR5mNmxfLtYHD?= =?us-ascii?Q?r7gwcVy/dQdaA0jQUq4vGCO+WqJdjsFOCETzAvZw/4nWnCmVI4rzk/mQbI1I?= =?us-ascii?Q?LA8GxHNebCC1f8+3PZ9OmsroAtKbwPxfGozYYnaMkfcNd/aD+bAxLtBDUXdy?= =?us-ascii?Q?Ww76nxS8PsAaXseFvhkcpJwiLCtzo+ZRPC7NUWZ30Q/8s6+KRY8ZGvQO2Gmd?= =?us-ascii?Q?8l2oKkFeDfoxJwAC8nsjxsVZ3SEGPwbtRgJnn1JCsSVjxQa3lqhiuq24L3xW?= =?us-ascii?Q?mkCWP9Ovr6Yloq2fhxC4OB/wK/JmmK4o2Ik46PAK+hmQWaacoYapYHZW7nIK?= =?us-ascii?Q?jHnO50IYYemCcP7+cOlbgn6AILKNx1WI6A30IbduKPM0R4ZC52PDnm0hb1Qi?= =?us-ascii?Q?yxngB8POBMzepi+4gx2UO+xjtkgkYx/6gU40i01vCADaig0ECIli6XcrPm7O?= =?us-ascii?Q?4xcBjl8aY8zduerw3Yu28xU5/DIWbAW2XX2/MdfbtwZ2nDy/Oz3/azu+PGuj?= =?us-ascii?Q?mMG5HSXrBbjmvTBOA8UePafmCyl/ifKA1PHI7CToSk5Ib2leZV1Wif0UEQRj?= =?us-ascii?Q?ZMmyipUdtAtBTek3+TWUorlOo1wcdGTlL81GRShV2d7a1FwaUNO4UTdlY8TE?= =?us-ascii?Q?4DPbvyhBNVCdXrMgz33RgTeNxo+4Mgt+15DuiSa5beclj/ODJo21QreAvFj4?= =?us-ascii?Q?M2KA19kNUXo8jAVm9gFTTAf3+tuKqtQ6+/DE18QlzQmr1OnZY0tZ8xibc7gm?= =?us-ascii?Q?ADUbj4WXxHRu8/Sf6PsPH4XGdg7xr+flf/Pm1kORfC0=3D?= X-MS-Exchange-CrossTenant-AuthSource: CO6PR18MB3842.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Dec 2020 14:38:56.9085 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-Network-Message-Id: 21cfb4ed-aab8-4530-9751-08d8a5be25ea X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: pbvMKOwiN+B9cddYg243+SJ1xrLRysX75Vq3QDbO8omtCOBEzwFxMrQSOr+8EQBKyTydsmE0IJhUo9XZptVhmg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR1801MB1902 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.343, 18.0.737 definitions=2020-12-21_08:2020-12-21, 2020-12-21 signatures=0 Subject: Re: [dpdk-dev] [EXT] RE: [PATCH 1/1] eal/linux: fix event set error for rte_epoll_event X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, Nov 02, 2020 at 02:15:01AM +0000, wangyunjian wrote: > > -----Original Message----- > > From: wangyunjian > > Sent: Tuesday, September 22, 2020 8:06 PM > > To: 'Harman Kalra' > > Cc: dev@dpdk.org; david.marchand@redhat.com; ferruh.yigit@intel.com; > > Thomas Monjalon ; Lilijun (Jerry) > > ; xudingke ; > > stable@dpdk.org > > Subject: RE: [EXT] RE: [dpdk-dev] [PATCH 1/1] eal/linux: fix event set error for > > rte_epoll_event > > > > > -----Original Message----- > > > From: Harman Kalra [mailto:hkalra@marvell.com] > > > Sent: Tuesday, September 22, 2020 6:32 PM > > > To: wangyunjian > > > Cc: dev@dpdk.org; david.marchand@redhat.com; ferruh.yigit@intel.com; > > > Thomas Monjalon ; Lilijun (Jerry) > > > ; xudingke ; > > > stable@dpdk.org > > > Subject: Re: [EXT] RE: [dpdk-dev] [PATCH 1/1] eal/linux: fix event set > > > error for rte_epoll_event > > > > > > On Sat, Sep 19, 2020 at 10:42:30AM +0000, wangyunjian wrote: > > > > External Email > > > > > > > > -------------------------------------------------------------------- > > > > -- > > > > Friendly ping. > > > > > > Hi Wang, > > > > > > I am sorry for the delay in review, I will surely complete the review > > > by end of this week. > > > Can you please elaborate on the specific case/scenario which caused > > > failure i.e. which lead you to this change. > > > > EPOLLERR event will be triggered when an exception occurs. This event will be > > set in 'evs.events', we should use 'evs.events' instead of 'rev->epdata.event' to > > assign to 'events.epdata.event'. Otherwise, the EPOLLERR event will lost. > > > > Thanks, > > Yunjian > > Hi Harman, > > Is there any ideas on this issue? Hi Yunjian Fix looks good, apologies for the delay in review. Acked-by: Harman Kalra > > > > > > > > > Thanks > > > Harman > > > > > > > > > > > > -----Original Message----- > > > > > From: wangyunjian > > > > > Sent: Wednesday, August 26, 2020 6:56 PM > > > > > To: dev@dpdk.org; hkalra@marvell.com; david.marchand@redhat.com > > > > > Cc: 'ferruh.yigit@intel.com' ; 'Thomas Monjalon' > > > > > ; Lilijun (Jerry) ; > > > > > xudingke ; stable@dpdk.org > > > > > Subject: RE: [dpdk-dev] [PATCH 1/1] eal/linux: fix event set error > > > > > for rte_epoll_event > > > > > > > > > > Ping for review, please. > > > > > > > > > > > -----Original Message----- > > > > > > From: wangyunjian > > > > > > Sent: Wednesday, July 15, 2020 10:40 AM > > > > > > To: dev@dpdk.org; hkalra@marvell.com > > > > > > Cc: Lilijun (Jerry) ; xudingke > > > > > > ; wangyunjian ; > > > > > > stable@dpdk.org > > > > > > Subject: [dpdk-dev] [PATCH 1/1] eal/linux: fix event set error > > > > > > for rte_epoll_event > > > > > > > > > > > > From: Yunjian Wang > > > > > > > > > > > > The "rev->epdata.event" assigned to "events.epdata.event" > > > > > > directly, which was wrong in case of epoll events. It should be > > > > > > set to the > > > "evs.events". > > > > > > > > > > > > Fixes: 9efe9c6cdcac ("eal/linux: add epoll wrappers") > > > > > > Cc: stable@dpdk.org > > > > > > > > > > > > Signed-off-by: Yunjian Wang > > > > > > --- > > > > > > lib/librte_eal/linux/eal_interrupts.c | 2 +- > > > > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > > > > > > > diff --git a/lib/librte_eal/linux/eal_interrupts.c > > > > > > b/lib/librte_eal/linux/eal_interrupts.c > > > > > > index 13db5c4e8..8a3c95cec 100644 > > > > > > --- a/lib/librte_eal/linux/eal_interrupts.c > > > > > > +++ b/lib/librte_eal/linux/eal_interrupts.c > > > > > > @@ -1237,7 +1237,7 @@ eal_epoll_process_event(struct epoll_event > > > > > > *evs, unsigned int n, > > > > > > events[count].status = RTE_EPOLL_VALID; > > > > > > events[count].fd = rev->fd; > > > > > > events[count].epfd = rev->epfd; > > > > > > - events[count].epdata.event = rev->epdata.event; > > > > > > + events[count].epdata.event = evs[i].events; > > > > > > events[count].epdata.data = rev->epdata.data; > > > > > > if (rev->epdata.cb_fun) > > > > > > rev->epdata.cb_fun(rev->fd, > > > > > > -- > > > > > > 2.23.0 > > > > > > > > > >