From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 38B3BA052A; Wed, 23 Dec 2020 12:58:54 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 3E1BCC9FA; Wed, 23 Dec 2020 12:58:52 +0100 (CET) Received: from mail-lf1-f49.google.com (mail-lf1-f49.google.com [209.85.167.49]) by dpdk.org (Postfix) with ESMTP id 43720C9F8 for ; Wed, 23 Dec 2020 12:58:50 +0100 (CET) Received: by mail-lf1-f49.google.com with SMTP id l11so39564108lfg.0 for ; Wed, 23 Dec 2020 03:58:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=7HsmVM6V11Ws8vBdnkD0TA3QPFeMxtU0LVAF1MdcQeQ=; b=aiE9fFr7gPFhd6mtoivcx4CQj/IOe2mByKfKb/h4WSUfdcC+vxMU6tGG+TUuRCoNSM 0U6unZyiq7aXcHFv8KVVhpjQEH9yn7vl+K5YdUMJr//jdrkBBQpMmBPt2jjzBk3DKrcb azLZpwk1tRqIKN9LfokiNEUuXYzAclClMkwlkQsHxjGIqzIO4zKT5Q6pvXaQslV9QrEi ocaPiYSo6fgH5z8To0uZKbsfhBvGNSO/aTFl1NvYQMRrPs3GwrzlWWsbh4sGZDcThVdN BJdkkHROOoyvlDiR5R/lJNr73dzkiFr+RB3RlvUVhFj8nZzNsU/FvNnMwu/k8bVhnx0L 2vrQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=7HsmVM6V11Ws8vBdnkD0TA3QPFeMxtU0LVAF1MdcQeQ=; b=qQ/0S3kJSWGEd/PR56hDhzVlMoZVNEddZg6WqsNO51RcWLdUnrKu84sxL2gC2mT8Bd g44a6zQbpf519ASnJcZSb+CTW26rQNZQ5uqIFox4qAsPJBL2mi8VkfOno9ppbGKYPow2 Wt0McfRf2xXrl+/qD/U54AmGLMoCppDhbN2NnimdqUyUfmGzeYASZlQkYox1oR37BJkH OnIVFMm5jXA+jNfRV1B2fXDGc7nfhh1UfZTPfDRYy2+bUUApG8rqZmRVfdnhyk5QcsJs 3XY+56LOtty4Ac9/hY6DeBFRpm0MkFGK72WAquDNxewKnCxXzNCyt9JLvgtJvZ4uggca 0+fw== X-Gm-Message-State: AOAM533DP+JetzlnwAMOsGPua8cFf8D0HF1p2v1tx9/yKJy+CwYqFK2k SbTZEcQ55UURDOk/bguA89A= X-Google-Smtp-Source: ABdhPJzuX55qb4yJbvN4tUGfvTfp2ZhA0IDzBlapnvm1BXoW8xcYPqC44gws4/HNFg3s1dfMpx2/Fg== X-Received: by 2002:a05:6512:74d:: with SMTP id c13mr6067923lfs.290.1608724728761; Wed, 23 Dec 2020 03:58:48 -0800 (PST) Received: from sovereign (broadband-37-110-65-23.ip.moscow.rt.ru. [37.110.65.23]) by smtp.gmail.com with ESMTPSA id 127sm3148498lfk.102.2020.12.23.03.58.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 23 Dec 2020 03:58:47 -0800 (PST) Date: Wed, 23 Dec 2020 14:58:46 +0300 From: Dmitry Kozlyuk To: Tal Shnaiderman Cc: "dev@dpdk.org" , NBU-Contact-Thomas Monjalon , "pallavi.kadam@intel.com" , "navasile@linux.microsoft.com" , "dmitrym@microsoft.com" , "david.marchand@redhat.com" Message-ID: <20201223145846.433883d8@sovereign> In-Reply-To: References: <20201217174913.14280-1-talshn@nvidia.com> <20201222073044.9084-1-talshn@nvidia.com> <20201223041801.5ea13a37@sovereign> X-Mailer: Claws Mail 3.17.6 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v4] eal: add generic thread-local-storage functions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, 23 Dec 2020 11:44:31 +0000, Tal Shnaiderman wrote: > > > diff --git a/lib/librte_eal/windows/meson.build > > > b/lib/librte_eal/windows/meson.build > > > index 3b2faf29eb..1f1398dfe9 100644 > > > --- a/lib/librte_eal/windows/meson.build > > > +++ b/lib/librte_eal/windows/meson.build > > > @@ -21,4 +21,10 @@ sources += files( > > > 'getopt.c', > > > ) > > > > > > +if (dpdk_conf.has('use_external_pthread')) > > > > Please describe the new option in meson_options.txt. > > Maybe drop "external" from the name, what do you think? > > How about use_windows_pthread to be clear that it's unrelated to UNIX pthreads? Sounds good.