Re: [dpdk-dev] [PATCH v2] ip_pipeline: add Python script file for creating visual diagram of IP pipeline config file

[Thomas Monjalon <thomas.monjalon@6wind.com>]

> > This commit adds Python script for generating diagram of the application
> > configuration file. This script requires graphviz package to be installed
> > on the machine. The input config file is translated to an output file in
> > DOT syntax, which is then used to create the image file using graphviz.
> > 
> > To run the script, following command is used;
> > 
> > ./diagram-generator.py -f <input configuration file>
> > 
> > Some optional arguments are as follows:
> >   -h, --help            show this help message and exit
> > 
> > Signed-off-by: Jasvinder Singh <jasvinder.singh@intel.com>
> > Signed-off-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
> > Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
> 
> 
> The subject line is too long:
> 
>     $ scripts/check-git-log.sh 
>     Headline too long:
>         ip_pipeline: add Python script file for creating visual diagram of IP pipeline config file
> 
> I would suggest something like:
> 
>         ip_pipeline: add script for creating config diagrams

or
	examples/ip_pipeline: add config diagram generator

> The code looks good though, so:
> 
> Acked-by: John McNamara <john.mcnamara@intel.com>

Applied, thanks

This example become more and more complex...