From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (xvm-189-124.dc0.ghst.net [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A3087A09FF; Thu, 7 Jan 2021 08:49:15 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 60BF8140EB7; Thu, 7 Jan 2021 08:49:15 +0100 (CET) Received: from mail-wr1-f43.google.com (mail-wr1-f43.google.com [209.85.221.43]) by mails.dpdk.org (Postfix) with ESMTP id B3B8B140EB6 for ; Thu, 7 Jan 2021 08:49:13 +0100 (CET) Received: by mail-wr1-f43.google.com with SMTP id c5so4646905wrp.6 for ; Wed, 06 Jan 2021 23:49:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=f9qaCbKqze8ZWl9U3OsW0zSTMF4HMb2EULJd4uL40bM=; b=g1kUng6mUzJj4jktOms3mYGB4A3pAXNoVeyQg/PgPR8Iqe+rylBpq6XZ+QQ+J5wgSU WdE9lPhh8MyOWOqYcXgqtRzJcG4YsQd/8dGrM0v/gC6P4cNrekafW+sAmQj8X4q6ynrQ 1+U+Y0CHZh8UhblUAxP6raQI9FZStX1KiYbJdaF4qVrkSKjJncJ9mFi5FOvYlStCo6Ue bYeBC8ZfxOMivJbCY2+9RfJpe/mB98yhuXBoEi+7YxvEwMxrnbt3Q5Hw/WxKWZg/N8tW NFwhm8NuEOBhmld8o7w7bwBxhRS/rVyu/dpk6hOEKeLbIZjoRSh1ZA1yro59lzGTfIuX lLAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=f9qaCbKqze8ZWl9U3OsW0zSTMF4HMb2EULJd4uL40bM=; b=psi2Q5ONAJPL+hmqyqaJVyMbJ2I6sh5kTUVOvdpLW9mdoYFlmnVTE1S4NA0shw+N9w vcQUmFoIYgOlz/n7J+rssqGRqHk0hFGpFheIphYNmZXarwhEmoHEUZPVSyamSyJHgbYi 3H0YH1ZLvFKYZigEMoN1xU7GVulHsvgRpv5jvepmFsBoq3z6/qIV11e+5DtuxOcyuzLQ PLezZHoKBRQuZ21mpeTBKFyXID077XG4KyqflsRY4Mk9Xgn5MFHp6wT8G1QYBFJ7OPIc FUD1LaggZ6+SbhiB6u33sT+9YDpMUNmLD4LNPVQLDKKvN2tLtgRz8e2OnNY8e1oI4M7l ZkRA== X-Gm-Message-State: AOAM531HeAjs/yQn14oVbotCvbQItvlqNvbe7uouLwWYEjRjZw4gtF9x beJ54gPBkygxq+HPGpNxvYVq/A== X-Google-Smtp-Source: ABdhPJx4GgMYKM5mWRm7JgpbvZz7iAAjiD2pz34mwyWzLI2Z8m20b8x75NNt2iR6DLI6EvJoWaSqUg== X-Received: by 2002:a5d:464b:: with SMTP id j11mr7585371wrs.227.1610005753505; Wed, 06 Jan 2021 23:49:13 -0800 (PST) Received: from 6wind.com ([2a01:e0a:5ac:6460:c065:401d:87eb:9b25]) by smtp.gmail.com with ESMTPSA id k1sm6724455wrn.46.2021.01.06.23.49.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 Jan 2021 23:49:12 -0800 (PST) Date: Thu, 7 Jan 2021 08:49:12 +0100 From: Olivier Matz To: Ashish Sadanandan Cc: dev@dpdk.org, stable@dpdk.org, David Marchand Message-ID: <20210107074912.GL2631@platinum> References: <20210107013114.3477-1-ashish.sadanandan@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210107013114.3477-1-ashish.sadanandan@gmail.com> User-Agent: Mutt/1.10.1 (2018-07-13) Subject: Re: [dpdk-dev] [PATCH v2 1/1] mbuf: fix rte_mbuf_dyn.h inclusion from C++ X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Jan 06, 2021 at 06:31:14PM -0700, Ashish Sadanandan wrote: > The header was missing the extern "C" directive which causes name > mangling of functions by C++ compilers, leading to linker errors > complaining of undefined references to these functions. > > Fixes: 4958ca3a443a ("mbuf: support dynamic fields and flags") > Cc: olivier.matz@6wind.com > Cc: stable@dpdk.org > > Change-Id: I9a92ada0278ff8455cc2718f8231597b0a7c6b48 I think this line can be dropped (it comes from gerrit). David, can you do it when pushing the patch? > Signed-off-by: Ashish Sadanandan Acked-by: Olivier Matz Thanks!