From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (xvm-189-124.dc0.ghst.net [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id AF9A0A0524; Thu, 7 Jan 2021 15:46:31 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7C748140F9D; Thu, 7 Jan 2021 15:46:31 +0100 (CET) Received: from mail-lf1-f43.google.com (mail-lf1-f43.google.com [209.85.167.43]) by mails.dpdk.org (Postfix) with ESMTP id 9CE62140F97 for ; Thu, 7 Jan 2021 15:46:30 +0100 (CET) Received: by mail-lf1-f43.google.com with SMTP id h205so15129340lfd.5 for ; Thu, 07 Jan 2021 06:46:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=TDjwJmes3ZVdVb7WQhCgJA0mYpTNyk0LTfDE0xVzufo=; b=oc3nKujwtZ01E2h3UynogU8ItVBpY7PQTH0lBfufMHIN64P72SxEd1I3WRhzR5j6eH p3JsY8QiLRJyaXaMGglAwN3+Ax8+5maikWCCGBBbVEdnzPiPHu67Gxf2g6+n2SZTaWMT ggrG7HDX+pUXLuEWXxftrOy0f9hJ3lqduRqeHlcMjQa9c02S4SFT8Mz0tSWVgqTgnD+w u8ywJ6SQJr2oo94Bn6WK9J0bYBWMNJUy6seL74TRc1F2KJoNIJIXP9g4RnVV+N5ne+pM wSKL2dVV/nxls8J6qM5r2dv7Nq1rfkU/zO2BJ9quRoeJkKEgEVT+4fwuO8K5blh6J9b+ NGkw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=TDjwJmes3ZVdVb7WQhCgJA0mYpTNyk0LTfDE0xVzufo=; b=jVwNr/rhylo+ePiPl2bpfBH6XHvs6HCzqt7VZY0Ows/7gEj/w5leWz9Y0DJyx9yKrM gAmBeVwXRN4F+K7/0/7z6CTdiWgHBOrKlGC2A1BJQs03bslDhtlgQ0pBoUajFrbWcj+O APLOvwkeMOgl2msqQYxipiDDpvuopHtyK7oJ0+jRD3VAwlF42tJFcT8/9Q8bQDzEhlcZ 4Q0b20CwGaA4saWmHg4Rnp6KEA42E9KNHnE62cNFmdr0FA7w6PMPzWe1VALkRGLXw04F oJVtGo/eoQdxLrRCXWx7yigGwyCY0yWsI0vSBGVdOSs5gkZQ3+QQLZzONTpO72SYCL+7 2fFA== X-Gm-Message-State: AOAM530keFXNRca5sbo/cHCEIl7xshbW4XGiHeYx2rqTQlo9jGP1crG3 j+Frwh/4EB4gn3zZfz1ZlnU= X-Google-Smtp-Source: ABdhPJxWNFcC1Ix58Pw3rn447EsZRSNe8Ot0RERwOgGUh3KchV2Cn9hq5l6lYpa0HyggUrBE7b1IZQ== X-Received: by 2002:ac2:4e92:: with SMTP id o18mr3913519lfr.576.1610030790182; Thu, 07 Jan 2021 06:46:30 -0800 (PST) Received: from sovereign (broadband-37-110-65-23.ip.moscow.rt.ru. [37.110.65.23]) by smtp.gmail.com with ESMTPSA id 132sm1195589lfm.301.2021.01.07.06.46.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 Jan 2021 06:46:29 -0800 (PST) Date: Thu, 7 Jan 2021 17:46:28 +0300 From: Dmitry Kozlyuk To: Tal Shnaiderman Cc: dev@dpdk.org, thomas@monjalon.net, pallavi.kadam@intel.com, navasile@linux.microsoft.com, dmitrym@microsoft.com, david.marchand@redhat.com Message-ID: <20210107174628.7d55a6e8@sovereign> In-Reply-To: <20210106203553.9876-3-talshn@nvidia.com> References: <20210106194543.14024-1-talshn@nvidia.com> <20210106203553.9876-1-talshn@nvidia.com> <20210106203553.9876-3-talshn@nvidia.com> X-Mailer: Claws Mail 3.17.6 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v9 2/2] eal: add generic thread-local-storage functions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, 6 Jan 2021 22:35:53 +0200, Tal Shnaiderman wrote: [...] > +int > +rte_thread_tls_key_create(rte_tls_key *key, void (*destructor)(void *)) > +{ > + int err; > + > + *key = malloc(sizeof(**key)); > + if ((*key) == NULL) { > + RTE_LOG(DEBUG, EAL, "Cannot allocate TLS key."); Missing "\n", same for Windows part. Aside from this nit, for series, Acked-by: Dmitry Kozlyuk