From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BE5D4A0A00; Mon, 11 Jan 2021 14:56:17 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A95DD140CCF; Mon, 11 Jan 2021 14:56:17 +0100 (CET) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mails.dpdk.org (Postfix) with ESMTP id AC4C0140CC1; Mon, 11 Jan 2021 14:56:15 +0100 (CET) IronPort-SDR: jRSVmq3t6ipr51CdPKsbFa0I6v8l4dTBGRgYUnLkqd1zk/6/PgfKXn4ejjg5BsRr6XulerCuXd ppSI2xZrovIQ== X-IronPort-AV: E=McAfee;i="6000,8403,9860"; a="157043424" X-IronPort-AV: E=Sophos;i="5.79,338,1602572400"; d="scan'208";a="157043424" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Jan 2021 05:56:10 -0800 IronPort-SDR: tQEXfYRpdnkKC9Cls2CC0F+kH1+6wJb2avK2U4ToNjKb2X3HFYRXO7YT2eY3tS34epzrkGujNi QLpBvwWSvFVg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.79,338,1602572400"; d="scan'208";a="567182092" Received: from silpixa00399126.ir.intel.com ([10.237.222.4]) by orsmga005.jf.intel.com with ESMTP; 11 Jan 2021 05:56:08 -0800 From: Bruce Richardson To: dev@dpdk.org Cc: thomas@monjalon.net, aboyer@pensando.io, Honnappa.Nagarahalli@arm.com, Bruce Richardson , stable@dpdk.org Date: Mon, 11 Jan 2021 13:55:59 +0000 Message-Id: <20210111135559.1169775-1-bruce.richardson@intel.com> X-Mailer: git-send-email 2.27.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-dev] [PATCH] build: provide suitable error for "both" libraries option X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Rather than having the DPDK configuration error out when linking apps and examples when "both" is select for "default_library" option, we can detect that setting earlier in the build config and provide a suitable error message to the user. CC: stable@dpdk.org Signed-off-by: Bruce Richardson --- config/meson.build | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/config/meson.build b/config/meson.build index 3ddcc3539..05e9cede5 100644 --- a/config/meson.build +++ b/config/meson.build @@ -308,3 +308,12 @@ if get_option('b_lto') add_project_link_arguments('-Wno-lto-type-mismatch', language: 'c') endif endif + +if get_option('default_library') == 'both' + error( ''' + Unsupported value "both" for "default_library" option. + + NOTE: DPDK always builds both shared and static libraries. Please set + "default_library" to either "static" or "shared" to select default linkage + for apps and any examples''') +endif -- 2.27.0