From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3B894A0A02; Wed, 13 Jan 2021 18:53:00 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B1A73140EAF; Wed, 13 Jan 2021 18:52:59 +0100 (CET) Received: from mail-lj1-f169.google.com (mail-lj1-f169.google.com [209.85.208.169]) by mails.dpdk.org (Postfix) with ESMTP id 16519140EAE; Wed, 13 Jan 2021 18:52:58 +0100 (CET) Received: by mail-lj1-f169.google.com with SMTP id m13so3495978ljo.11; Wed, 13 Jan 2021 09:52:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Mv640BTzDf6jNwjovKKIJJDhUWLIo9LUEIBoUBH0QR0=; b=M5rGGSIlDrGTlTdfTXNJ9mFUTzl+IwlMfV50wENIeZtRLcSm8F7AG8+VivrJAr5LJb ZfgV199hTNAUGf74u2jIoQrFhhq6Fp4R2ea4yMTgCQIParWiEcY4KusN/63+3Dn9GaFQ PK6e1NRvpi00GDLa8w2wbXdkc4n9DN+JZi2nO8I/xZOlq3CEa5GWC1C1ttylDcR9g9Ls u4sFdY6P3dnIUuZymYBGrzVJOEvVwBsfa/7CFJ+PrYQDAkb862RYeIlKTca8zZ7xaPIZ bsmBcKS5kxmbTGITo7h9fLs616UYUHVfOBdRcKw9mx+TN/MqMUUXRmEqOBUQ5MOXSLHG UG9Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Mv640BTzDf6jNwjovKKIJJDhUWLIo9LUEIBoUBH0QR0=; b=jve3xaJrUAATiR0gdYolutWqiFZTE4amqYLZVMJo7rEjDECmpVpQrE9xMPjVQdslii tR0fkciECsy3H0oi3CWcasDxBxvKSaRMpuhBHydUfsjfzS4xqX4xQJad4ipxLD4o585/ +Gc7Gw2k62AEa4X01t39JJkJ+DNpqWXLmo8YHLNZ62LF1OBYpt1RT83Kr9LOsxEa1v/j eQ14c4L2B434YNA1iihb9Nwj6nhjOhk7Wy3GQYd1GnAf5xBiWIlrYmnSmQ0+gi+roYPO rC3H5gzsLRiusz09qr3o0rim37xvVK+9jdKB5/6H0TNsbbHDtjfXaV0zbakCllDppQ+Z PfRQ== X-Gm-Message-State: AOAM5300shSIGChydS5YV7tfwx2LySB6lu5COA23F7BcmziOifuxcGMR qV6CiAHBfnhi8st+/mCd0SQ= X-Google-Smtp-Source: ABdhPJz8NGN+/ptdOwN1/fWMvLswqaAgxVegvBETLtWNWZZb9ZGNQllwvoz8bi5CDRzp0An/OERupg== X-Received: by 2002:a2e:9a0d:: with SMTP id o13mr1453603lji.355.1610560377617; Wed, 13 Jan 2021 09:52:57 -0800 (PST) Received: from sovereign (broadband-37-110-65-23.ip.moscow.rt.ru. [37.110.65.23]) by smtp.gmail.com with ESMTPSA id b11sm275287lfi.174.2021.01.13.09.52.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Jan 2021 09:52:56 -0800 (PST) Date: Wed, 13 Jan 2021 20:52:55 +0300 From: Dmitry Kozlyuk To: Tyler Retzlaff Cc: dev@dpdk.org, navasile@linux.microsoft.com, stable@dpdk.org Message-ID: <20210113205255.6e865a04@sovereign> In-Reply-To: <1610414325-9104-1-git-send-email-roretzla@linux.microsoft.com> References: <1610414325-9104-1-git-send-email-roretzla@linux.microsoft.com> X-Mailer: Claws Mail 3.17.6 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] eal/headers: explicitly cast void * to type * X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, 11 Jan 2021 17:18:45 -0800, Tyler Retzlaff wrote: > Explicitly cast void * to type * so that eal headers may be compiled > as C or C++. Topic should probably be "eal/windows". Fixes: e8428a9d89f1 ("eal/windows: add some basic functions and macros") Cc: stable@dpdk.org > Signed-off-by: Tyler Retzlaff > --- [...] > diff --git a/lib/librte_ethdev/rte_ethdev_pci.h b/lib/librte_ethdev/rte_ethdev_pci.h > index bf715896a..c20be29b1 100644 > --- a/lib/librte_ethdev/rte_ethdev_pci.h > +++ b/lib/librte_ethdev/rte_ethdev_pci.h > @@ -47,7 +47,7 @@ rte_eth_copy_pci_info(struct rte_eth_dev *eth_dev, > > static inline int > eth_dev_pci_specific_init(struct rte_eth_dev *eth_dev, void *bus_device) { > - struct rte_pci_device *pci_dev = bus_device; > + struct rte_pci_device *pci_dev = (struct rte_pci_device *)bus_device; > > if (!pci_dev) > return -ENODEV; This is a private header, it's never exposed---why the change is needed (not that I have a strong opinion, though)?