From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 00BD3A0A02; Thu, 14 Jan 2021 10:50:47 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1A58714108A; Thu, 14 Jan 2021 10:50:18 +0100 (CET) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mails.dpdk.org (Postfix) with ESMTP id CCE46141053 for ; Thu, 14 Jan 2021 10:50:16 +0100 (CET) IronPort-SDR: VN5MzXTsgs00YfxTeWG2pmbu4oqLTGpfDPgTaX0v0taHHsY4Rzurn4sRTZfkJ0l774nWNAmRKl MoPjxBYPwVYg== X-IronPort-AV: E=McAfee;i="6000,8403,9863"; a="242411101" X-IronPort-AV: E=Sophos;i="5.79,347,1602572400"; d="scan'208";a="242411101" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Jan 2021 01:50:15 -0800 IronPort-SDR: +BGzDKUWtEaZXOe8NPxFAQDvPctmapa+i8wt6X3f2w6KEqFV721wL5UYIteTJmpQoriQVuqjK7 LqmY7wLEX95Q== X-IronPort-AV: E=Sophos;i="5.79,347,1602572400"; d="scan'208";a="572283886" Received: from intel-npg-odc-srv01.cd.intel.com ([10.240.178.136]) by fmsmga005-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Jan 2021 01:50:14 -0800 From: Steve Yang To: dev@dpdk.org Cc: andrew.rybchenko@oktetlabs.ru, Steve Yang Date: Thu, 14 Jan 2021 09:47:03 +0000 Message-Id: <20210114094703.14278-1-stevex.yang@intel.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20201217092312.27033-1-stevex.yang@intel.com> References: <20201217092312.27033-1-stevex.yang@intel.com> Subject: [dpdk-dev] [PATCH v3 14/22] net/sfc: fix the jumbo frame flag condition for mtu set X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" The jumbo frame uses the 'RTE_ETHER_MAX_LEN' as boundary condition, but the Ether overhead is larger than 18 when it supports VLAN tag. That will cause the jumbo flag rx offload is wrong when MTU size is 'RTE_ETHER_MTU'. This fix will change the boundary condition with 'RTE_ETHER_MTU', that perhaps impacts the cases of the jumbo frame related. Fixes: ff6a1197c3b1 ("net/sfc: convert to new Rx offload API") Signed-off-by: Steve Yang --- drivers/net/sfc/sfc_ethdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/sfc/sfc_ethdev.c b/drivers/net/sfc/sfc_ethdev.c index 93fc7baa0d..f2f5336435 100644 --- a/drivers/net/sfc/sfc_ethdev.c +++ b/drivers/net/sfc/sfc_ethdev.c @@ -1017,7 +1017,7 @@ sfc_dev_set_mtu(struct rte_eth_dev *dev, uint16_t mtu) * The driver does not use it, but other PMDs update jumbo frame * flag and max_rx_pkt_len when MTU is set. */ - if (mtu > RTE_ETHER_MAX_LEN) { + if (mtu > RTE_ETHER_MTU) { struct rte_eth_rxmode *rxmode = &dev->data->dev_conf.rxmode; rxmode->offloads |= DEV_RX_OFFLOAD_JUMBO_FRAME; } -- 2.17.1