From: Steve Yang <stevex.yang@intel.com>
To: dev@dpdk.org
Cc: asomalap@amd.com, Steve Yang <stevex.yang@intel.com>
Subject: [dpdk-dev] [PATCH v3 18/22] net/axgbe: fix the jumbo frame flag condition for mtu set
Date: Thu, 14 Jan 2021 09:47:26 +0000 [thread overview]
Message-ID: <20210114094726.14466-1-stevex.yang@intel.com> (raw)
In-Reply-To: <20201217092312.27033-1-stevex.yang@intel.com>
The jumbo frame uses the 'RTE_ETHER_MAX_LEN' as boundary condition.
If the Ether overhead is larger than 18 when it supports VLAN tag,
that will cause the jumbo flag rx offload is wrong when MTU size is
'RTE_ETHER_MTU'.
This fix will normalize the boundary condition with 'RTE_ETHER_MTU'
and overhead even though current overhead is 18.
Fixes: b58d8781fa1f ("net/axgbe: support setting MTU")
Signed-off-by: Steve Yang <stevex.yang@intel.com>
---
drivers/net/axgbe/axgbe_ethdev.c | 2 +-
drivers/net/axgbe/axgbe_ethdev.h | 6 ++++++
2 files changed, 7 insertions(+), 1 deletion(-)
diff --git a/drivers/net/axgbe/axgbe_ethdev.c b/drivers/net/axgbe/axgbe_ethdev.c
index ddd903680d..ebe9a2876d 100644
--- a/drivers/net/axgbe/axgbe_ethdev.c
+++ b/drivers/net/axgbe/axgbe_ethdev.c
@@ -1490,7 +1490,7 @@ static int axgb_mtu_set(struct rte_eth_dev *dev, uint16_t mtu)
dev->data->port_id);
return -EBUSY;
}
- if (frame_size > RTE_ETHER_MAX_LEN) {
+ if (frame_size > AXGBE_ETH_MAX_LEN) {
dev->data->dev_conf.rxmode.offloads |=
DEV_RX_OFFLOAD_JUMBO_FRAME;
val = 1;
diff --git a/drivers/net/axgbe/axgbe_ethdev.h b/drivers/net/axgbe/axgbe_ethdev.h
index 1481fd9ff3..a6226729fe 100644
--- a/drivers/net/axgbe/axgbe_ethdev.h
+++ b/drivers/net/axgbe/axgbe_ethdev.h
@@ -125,6 +125,12 @@
/* MDIO port types */
#define AXGMAC_MAX_C22_PORT 3
+/* The max frame size with default MTU */
+#define AXGBE_ETH_MAX_LEN ( \
+ RTE_ETHER_MTU + \
+ RTE_ETHER_HDR_LEN + \
+ RTE_ETHER_CRC_LEN)
+
/* Helper macro for descriptor handling
* Always use AXGBE_GET_DESC_DATA to access the descriptor data
* since the index is free-running and needs to be and-ed
--
2.17.1
next prev parent reply other threads:[~2021-01-14 9:51 UTC|newest]
Thread overview: 115+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-09 3:16 [dpdk-dev] [PATCH v1 00/12] fix rx packets dropped issue Steve Yang
2020-12-09 3:16 ` [dpdk-dev] [PATCH v1 01/12] net/dpaa2: fix the jumbo frame flag condition for mtu set Steve Yang
2020-12-09 3:16 ` [dpdk-dev] [PATCH v1 02/12] net/e1000: " Steve Yang
2020-12-09 3:16 ` [dpdk-dev] [PATCH v1 03/12] net/hns3: " Steve Yang
2020-12-09 3:16 ` [dpdk-dev] [PATCH v1 04/12] net/i40e: fix the jumbo frame flag condition Steve Yang
2020-12-09 3:16 ` [dpdk-dev] [PATCH v1 05/12] net/iavf: " Steve Yang
2020-12-09 3:16 ` [dpdk-dev] [PATCH v1 06/12] net/ice: " Steve Yang
2020-12-09 3:16 ` [dpdk-dev] [PATCH v1 07/12] net/ipn3ke: fix the jumbo frame flag condition for mtu set Steve Yang
2020-12-09 3:16 ` [dpdk-dev] [PATCH v1 08/12] net/octeontx: " Steve Yang
2020-12-09 3:16 ` [dpdk-dev] [PATCH v1 09/12] net/octeontx2: fix the jumbo frame flag condition for mtu Steve Yang
2020-12-21 7:16 ` [dpdk-dev] [EXT] " Sunil Kumar Kori
2020-12-09 3:16 ` [dpdk-dev] [PATCH v1 10/12] net/qede: fix the jumbo frame flag condition for mtu set Steve Yang
2020-12-09 3:16 ` [dpdk-dev] [PATCH v1 11/12] net/sfc: " Steve Yang
2020-12-09 3:16 ` [dpdk-dev] [PATCH v1 12/12] net/thunderx: " Steve Yang
2020-12-11 4:31 ` [dpdk-dev] [PATCH v1 00/12] fix rx packets dropped issue Guo, Jia
2020-12-14 17:44 ` Ferruh Yigit
2020-12-17 9:22 ` [dpdk-dev] [PATCH v2 00/22] " Steve Yang
2020-12-17 9:22 ` [dpdk-dev] [PATCH v2 01/22] ethdev: fix MTU size exceeds max rx packet length Steve Yang
2020-12-28 14:51 ` Andrew Rybchenko
2021-01-13 10:32 ` Ferruh Yigit
2020-12-30 10:19 ` oulijun
[not found] ` <DM6PR11MB43627F10DDAFC9801816FF5BF9D00@DM6PR11MB4362.namprd11.prod.outlook.com>
2021-01-13 10:25 ` Ferruh Yigit
2021-01-13 11:04 ` Ferruh Yigit
2020-12-17 9:22 ` [dpdk-dev] [PATCH v2 02/22] app/testpmd: fix max rx packet length for VLAN packets Steve Yang
2021-01-13 11:26 ` Ferruh Yigit
2020-12-17 9:22 ` [dpdk-dev] [PATCH v2 03/22] net/dpaa: fix the jumbo frame flag condition for mtu set Steve Yang
2020-12-17 9:22 ` [dpdk-dev] [PATCH v2 04/22] net/dpaa2: " Steve Yang
2020-12-17 9:22 ` [dpdk-dev] [PATCH v2 05/22] net/e1000: " Steve Yang
2020-12-18 2:42 ` Guo, Jia
2020-12-17 9:22 ` [dpdk-dev] [PATCH v2 06/22] net/hns3: " Steve Yang
2020-12-17 9:22 ` [dpdk-dev] [PATCH v2 07/22] net/i40e: fix the jumbo frame flag condition Steve Yang
2020-12-18 2:44 ` Guo, Jia
2020-12-17 9:22 ` [dpdk-dev] [PATCH v2 08/22] net/iavf: " Steve Yang
2020-12-17 9:22 ` [dpdk-dev] [PATCH v2 09/22] net/ice: " Steve Yang
2020-12-17 9:23 ` [dpdk-dev] [PATCH v2 10/22] net/ipn3ke: fix the jumbo frame flag condition for mtu set Steve Yang
2020-12-19 0:54 ` Xu, Rosen
2020-12-17 9:23 ` [dpdk-dev] [PATCH v2 11/22] net/octeontx: " Steve Yang
2020-12-21 15:04 ` [dpdk-dev] [EXT] " Harman Kalra
2020-12-17 9:23 ` [dpdk-dev] [PATCH v2 12/22] net/octeontx2: fix the jumbo frame flag condition for mtu Steve Yang
2020-12-18 10:15 ` Nithin Dabilpuram
2020-12-21 7:19 ` [dpdk-dev] [EXT] " Sunil Kumar Kori
2020-12-17 9:23 ` [dpdk-dev] [PATCH v2 13/22] net/qede: fix the jumbo frame flag condition for mtu set Steve Yang
2020-12-17 9:23 ` [dpdk-dev] [PATCH v2 14/22] net/sfc: " Steve Yang
2020-12-17 9:23 ` [dpdk-dev] [PATCH v2 15/22] net/thunderx: " Steve Yang
2020-12-17 9:23 ` [dpdk-dev] [PATCH v2 16/22] net/ixgbe: fix the jumbo frame flag condition Steve Yang
2020-12-18 2:43 ` Guo, Jia
2020-12-17 9:23 ` [dpdk-dev] [PATCH v2 17/22] net/cxgbe: " Steve Yang
2020-12-17 9:23 ` [dpdk-dev] [PATCH v2 18/22] net/axgbe: fix the jumbo frame flag condition for mtu set Steve Yang
2020-12-17 9:23 ` [dpdk-dev] [PATCH v2 19/22] net/enetc: " Steve Yang
2020-12-17 9:23 ` [dpdk-dev] [PATCH v2 20/22] net/hinic: " Steve Yang
2020-12-17 9:23 ` [dpdk-dev] [PATCH v2 21/22] net/nfp: " Steve Yang
2020-12-17 9:23 ` [dpdk-dev] [PATCH v2 22/22] net/liquidio: " Steve Yang
2021-01-13 11:32 ` [dpdk-dev] [PATCH v2 00/22] fix rx packets dropped issue Ferruh Yigit
2021-01-14 9:45 ` [dpdk-dev] [PATCH v3 " Steve Yang
2021-01-14 9:45 ` [dpdk-dev] [PATCH v3 01/22] ethdev: fix MTU size exceeds max rx packet length Steve Yang
2021-01-14 16:36 ` Ferruh Yigit
2021-01-14 17:13 ` Ferruh Yigit
2021-01-14 17:29 ` Andrew Boyer
2021-01-14 20:44 ` Ferruh Yigit
2021-01-15 10:44 ` oulijun
2021-01-18 10:42 ` Ferruh Yigit
2021-01-19 8:46 ` oulijun
2021-01-23 9:05 ` oulijun
2021-01-25 12:22 ` Ferruh Yigit
2021-01-18 7:04 ` [dpdk-dev] [PATCH v4 00/22] fix rx packets dropped issue Steve Yang
2021-01-18 7:04 ` [dpdk-dev] [PATCH v4 01/22] ethdev: fix MTU size exceeds max rx packet length Steve Yang
2021-01-18 7:04 ` [dpdk-dev] [PATCH v4 02/22] app/testpmd: fix max rx packet length for VLAN packets Steve Yang
2021-01-21 15:27 ` Lance Richardson
2021-01-22 14:26 ` Lance Richardson
2021-01-25 12:14 ` Ferruh Yigit
2021-01-18 7:04 ` [dpdk-dev] [PATCH v4 03/22] net/dpaa: fix the jumbo frame flag condition for mtu set Steve Yang
2021-01-18 7:04 ` [dpdk-dev] [PATCH v4 04/22] net/dpaa2: " Steve Yang
2021-01-18 7:04 ` [dpdk-dev] [PATCH v4 05/22] net/e1000: " Steve Yang
2021-01-18 7:04 ` [dpdk-dev] [PATCH v4 06/22] net/hns3: " Steve Yang
2021-01-18 7:04 ` [dpdk-dev] [PATCH v4 07/22] net/i40e: fix the jumbo frame flag condition Steve Yang
2021-01-18 7:04 ` [dpdk-dev] [PATCH v4 08/22] net/iavf: " Steve Yang
2021-01-18 7:04 ` [dpdk-dev] [PATCH v4 09/22] net/ice: " Steve Yang
2021-01-18 7:04 ` [dpdk-dev] [PATCH v4 10/22] net/ipn3ke: fix the jumbo frame flag condition for mtu set Steve Yang
2021-01-18 7:04 ` [dpdk-dev] [PATCH v4 11/22] net/octeontx: " Steve Yang
2021-01-18 7:04 ` [dpdk-dev] [PATCH v4 12/22] net/octeontx2: fix the jumbo frame flag condition for mtu Steve Yang
2021-01-18 7:04 ` [dpdk-dev] [PATCH v4 13/22] net/qede: fix the jumbo frame flag condition for mtu set Steve Yang
2021-01-18 7:04 ` [dpdk-dev] [PATCH v4 14/22] net/sfc: " Steve Yang
2021-01-18 7:04 ` [dpdk-dev] [PATCH v4 15/22] net/thunderx: " Steve Yang
2021-01-18 7:04 ` [dpdk-dev] [PATCH v4 16/22] net/ixgbe: fix the jumbo frame flag condition Steve Yang
2021-01-18 7:04 ` [dpdk-dev] [PATCH v4 17/22] net/cxgbe: " Steve Yang
2021-01-18 7:04 ` [dpdk-dev] [PATCH v4 18/22] net/axgbe: fix the jumbo frame flag condition for mtu set Steve Yang
2021-01-18 7:04 ` [dpdk-dev] [PATCH v4 19/22] net/enetc: " Steve Yang
2021-01-18 7:04 ` [dpdk-dev] [PATCH v4 20/22] net/hinic: " Steve Yang
2021-01-18 7:04 ` [dpdk-dev] [PATCH v4 21/22] net/nfp: " Steve Yang
2021-01-18 7:04 ` [dpdk-dev] [PATCH v4 22/22] net/liquidio: " Steve Yang
2021-01-18 11:54 ` [dpdk-dev] [PATCH v4 00/22] fix rx packets dropped issue Ferruh Yigit
2021-01-14 9:45 ` [dpdk-dev] [PATCH v3 02/22] app/testpmd: fix max rx packet length for VLAN packets Steve Yang
2021-01-14 9:45 ` [dpdk-dev] [PATCH v3 03/22] net/dpaa: fix the jumbo frame flag condition for mtu set Steve Yang
2021-01-14 10:26 ` Hemant Agrawal
2021-01-14 9:46 ` [dpdk-dev] [PATCH v3 04/22] net/dpaa2: " Steve Yang
2021-01-14 10:27 ` Hemant Agrawal
2021-01-14 9:46 ` [dpdk-dev] [PATCH v3 05/22] net/e1000: " Steve Yang
2021-01-14 9:46 ` [dpdk-dev] [PATCH v3 06/22] net/hns3: " Steve Yang
2021-01-18 1:30 ` oulijun
2021-01-14 9:46 ` [dpdk-dev] [PATCH v3 07/22] net/i40e: fix the jumbo frame flag condition Steve Yang
2021-01-14 9:46 ` [dpdk-dev] [PATCH v3 08/22] net/iavf: " Steve Yang
2021-01-14 9:46 ` [dpdk-dev] [PATCH v3 09/22] net/ice: " Steve Yang
2021-01-14 9:46 ` [dpdk-dev] [PATCH v3 10/22] net/ipn3ke: fix the jumbo frame flag condition for mtu set Steve Yang
2021-01-14 9:46 ` [dpdk-dev] [PATCH v3 11/22] net/octeontx: " Steve Yang
2021-01-14 9:46 ` [dpdk-dev] [PATCH v3 12/22] net/octeontx2: fix the jumbo frame flag condition for mtu Steve Yang
2021-01-14 9:46 ` [dpdk-dev] [PATCH v3 13/22] net/qede: fix the jumbo frame flag condition for mtu set Steve Yang
2021-01-14 9:47 ` [dpdk-dev] [PATCH v3 14/22] net/sfc: " Steve Yang
2021-01-14 9:47 ` [dpdk-dev] [PATCH v3 15/22] net/thunderx: " Steve Yang
2021-01-14 9:47 ` [dpdk-dev] [PATCH v3 16/22] net/ixgbe: fix the jumbo frame flag condition Steve Yang
2021-01-14 9:47 ` [dpdk-dev] [PATCH v3 17/22] net/cxgbe: " Steve Yang
2021-01-14 9:47 ` Steve Yang [this message]
2021-01-14 9:47 ` [dpdk-dev] [PATCH v3 19/22] net/enetc: fix the jumbo frame flag condition for mtu set Steve Yang
2021-01-14 9:47 ` [dpdk-dev] [PATCH v3 20/22] net/hinic: " Steve Yang
2021-01-14 9:47 ` [dpdk-dev] [PATCH v3 21/22] net/nfp: " Steve Yang
2021-01-14 9:47 ` [dpdk-dev] [PATCH v3 22/22] net/liquidio: " Steve Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210114094726.14466-1-stevex.yang@intel.com \
--to=stevex.yang@intel.com \
--cc=asomalap@amd.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).