From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E55B0A0A02; Thu, 14 Jan 2021 08:05:59 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D0905140EA4; Thu, 14 Jan 2021 08:05:59 +0100 (CET) Received: from mail-lj1-f174.google.com (mail-lj1-f174.google.com [209.85.208.174]) by mails.dpdk.org (Postfix) with ESMTP id 3D096140E73; Thu, 14 Jan 2021 08:05:59 +0100 (CET) Received: by mail-lj1-f174.google.com with SMTP id u11so5261126ljo.13; Wed, 13 Jan 2021 23:05:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=ZipzufjvJYDpDhdqMxB90PVn4++yXDCgpaC3mLlet9s=; b=QiSoLq5k6GxO2igb40skGYj0txl/twa2mUhYVwu7XaziRHKOgRQIQP4EpUHGWTAwff pKGHyBnmr6tpd74J2MYOYALKkFo3nRAqUXGd2NdJStb6+XXo2mchnTMjJomHXTEPR7HY VGeC4dHUD9C1/4SoRyn+5CWXhgi5aX6gHecbdfgNSIV1fZE+5FBY+AfHbsRsmGzvVhtV YJ32/+GadrEPbpEkHosM1fx8VgYpvaVsRbnjiqSXHx2lDPijAl1Zj/M01HWVu7zTro9S yfjda+hJLWAsfEMBpKWOtfJaPTpeUgffDtwDNUrDBjSAIzIDmSSeRttoflMRUnw86jYT rP/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=ZipzufjvJYDpDhdqMxB90PVn4++yXDCgpaC3mLlet9s=; b=dHB1JV7B93lIikLc4LXHh4uXGjsHlPaat45+QsgalZXYkCxLyWRoGknlDXvPReXX5U m8z8C1eiHsGwbShrZxswLI1FH0+pqgIPdvH1g7Z/xweoLZN6mI4HLPjEgSou/c2rqqLp Bh/9Z654VwZrpewMS+AovJhnzhptJ6/S5zc0SSukACcT57i+taoJ3Ioss3/nmu4TcRwf A55w1c6hQ7sJhHXeqlwAKOFShOjvDaDP6DNRlzHvEj8+c2vt7uUZkip/zPKlqxu9HJSU eFK+ucDvWMPOYcFjZqstyeq2SXQxlOt3FLeRf4w6YzAM7GRPa5W3RMzEp/czQiyzalSB Nobg== X-Gm-Message-State: AOAM533A/WHRJ6EzX7NNgZF5/12XlSNLCUJ1QOkSUEAPXBPv/bkMPSpx wRRQTtwbYRjs6iEXstRDxLw= X-Google-Smtp-Source: ABdhPJwyfOkMy+bsAXpPbgzN7A4Zrl+7uH16RdWe0h5DoDmmmXgw+AB+Mjb/jDxkIre+aqC20JZxzg== X-Received: by 2002:a2e:8e3b:: with SMTP id r27mr2603189ljk.196.1610607958827; Wed, 13 Jan 2021 23:05:58 -0800 (PST) Received: from sovereign (broadband-37-110-65-23.ip.moscow.rt.ru. [37.110.65.23]) by smtp.gmail.com with ESMTPSA id g69sm453575lfd.161.2021.01.13.23.05.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Jan 2021 23:05:58 -0800 (PST) Date: Thu, 14 Jan 2021 10:05:57 +0300 From: Dmitry Kozlyuk To: Tyler Retzlaff Cc: dev@dpdk.org, navasile@linux.microsoft.com, stable@dpdk.org, Bruce Richardson Message-ID: <20210114100557.3ec44961@sovereign> In-Reply-To: <20210114054549.GA27612@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> References: <1610414325-9104-1-git-send-email-roretzla@linux.microsoft.com> <20210113205255.6e865a04@sovereign> <20210114054549.GA27612@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> X-Mailer: Claws Mail 3.17.6 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] eal/headers: explicitly cast void * to type * X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, 13 Jan 2021 21:45:49 -0800, Tyler Retzlaff wrote: > On Wed, Jan 13, 2021 at 08:52:55PM +0300, Dmitry Kozlyuk wrote: > > On Mon, 11 Jan 2021 17:18:45 -0800, Tyler Retzlaff wrote: > > > Explicitly cast void * to type * so that eal headers may be compiled > > > as C or C++. > > > > Topic should probably be "eal/windows". > > i'll submit a new rev that changes this, it's not really windows specific > but i guess windows is the only people crazy enough to use c++. 1. Topic usually describe area of changes, rte_os.h is in windows directory. 2. It's a perfectly valid concern that public headers must be usable from C++. > > > diff --git a/lib/librte_ethdev/rte_ethdev_pci.h b/lib/librte_ethdev/rte_ethdev_pci.h > > > index bf715896a..c20be29b1 100644 > > > --- a/lib/librte_ethdev/rte_ethdev_pci.h > > > +++ b/lib/librte_ethdev/rte_ethdev_pci.h > > > @@ -47,7 +47,7 @@ rte_eth_copy_pci_info(struct rte_eth_dev *eth_dev, > > > > > > static inline int > > > eth_dev_pci_specific_init(struct rte_eth_dev *eth_dev, void *bus_device) { > > > - struct rte_pci_device *pci_dev = bus_device; > > > + struct rte_pci_device *pci_dev = (struct rte_pci_device *)bus_device; > > > > > > if (!pci_dev) > > > return -ENODEV; > > > > This is a private header, it's never exposed---why the change is needed (not > > that I have a strong opinion, though)? > > interesting, i'll look into why/how it is being included and confirm. i suppose > the question in the back of my mind is if it is private then why is the header > being installed at all? + Bruce If it's a public header then maybe it's missing a @file?