From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 38E85A0A02; Fri, 15 Jan 2021 12:49:18 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0FE75140FFF; Fri, 15 Jan 2021 12:49:18 +0100 (CET) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mails.dpdk.org (Postfix) with ESMTP id A5E45140FFE; Fri, 15 Jan 2021 12:49:16 +0100 (CET) IronPort-SDR: uYNlmceZHzYz/0olIui6m4RhXhCsxj2neDJjao2J84/1hu+bUHjHOqNQd6rrwTjceby2FGpQwR Xsmv9Llx7VZA== X-IronPort-AV: E=McAfee;i="6000,8403,9864"; a="175957061" X-IronPort-AV: E=Sophos;i="5.79,349,1602572400"; d="scan'208";a="175957061" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Jan 2021 03:49:15 -0800 IronPort-SDR: rUTcYN135mkVp7QdCPHVh07R2ddGTNyjNWwir9+jCVW6+cqVG/mAqqom0l/BsQboNKWnARYNAQ kan9eUWUQNJA== X-IronPort-AV: E=Sophos;i="5.79,349,1602572400"; d="scan'208";a="364558346" Received: from bricha3-mobl.ger.corp.intel.com ([10.252.8.25]) by orsmga002-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 15 Jan 2021 03:49:13 -0800 Date: Fri, 15 Jan 2021 11:49:10 +0000 From: Bruce Richardson To: "Medvedkin, Vladimir" Cc: dev@dpdk.org, david.marchand@redhat.com, stable@dpdk.org, Konstantin Ananyev , Bernard Iremonger , Akhil Goyal Message-ID: <20210115114910.GA1487@bricha3-MOBL.ger.corp.intel.com> References: <20210114110606.21142-1-bruce.richardson@intel.com> <20210115111052.16437-1-bruce.richardson@intel.com> <20210115111052.16437-10-bruce.richardson@intel.com> <40459d99-f163-71cc-f910-0edfb3e9b9bf@intel.com> <5b7fd1d6-eee6-e468-65fd-5f9163614b57@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <5b7fd1d6-eee6-e468-65fd-5f9163614b57@intel.com> Subject: Re: [dpdk-dev] [PATCH v2 09/19] ipsec: fix missing header include X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, Jan 15, 2021 at 11:45:11AM +0000, Medvedkin, Vladimir wrote: > Hi Bruce, > > Just a one nit, please put before rte_ includes. > Good point, I'll fix if I do a V3. > On 15/01/2021 11:37, Medvedkin, Vladimir wrote: > > > > > > On 15/01/2021 11:10, Bruce Richardson wrote: > > > The rte_ipsec_sad.h header used the standard uintXX_t types, but did not > > > include stdint.h header for them. > > > > > > Fixes: 401633d9c112 ("ipsec: add inbound SAD API") > > > Cc: stable@dpdk.org > > > > > > Signed-off-by: Bruce Richardson > > > --- > > >   lib/librte_ipsec/rte_ipsec_sad.h | 1 + > > >   1 file changed, 1 insertion(+) > > > > > > diff --git a/lib/librte_ipsec/rte_ipsec_sad.h > > > b/lib/librte_ipsec/rte_ipsec_sad.h > > > index 3e67ab1e4b..66c703ff3a 100644 > > > --- a/lib/librte_ipsec/rte_ipsec_sad.h > > > +++ b/lib/librte_ipsec/rte_ipsec_sad.h > > > @@ -7,6 +7,7 @@ > > >   #define _RTE_IPSEC_SAD_H_ > > >   #include > > > +#include > > >   /** > > >    * @file rte_ipsec_sad.h > > > > > > > Acked-by: Vladimir Medvedkin > > > > -- > Regards, > Vladimir