From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 95C17A0A04;
	Fri, 15 Jan 2021 20:21:56 +0100 (CET)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 089B0140EA6;
	Fri, 15 Jan 2021 20:21:56 +0100 (CET)
Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182])
 by mails.dpdk.org (Postfix) with ESMTP id D08F9140EA5;
 Fri, 15 Jan 2021 20:21:53 +0100 (CET)
Received: by linux.microsoft.com (Postfix, from userid 1086)
 id EA3E620B7192; Fri, 15 Jan 2021 11:21:52 -0800 (PST)
DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com EA3E620B7192
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;
 s=default; t=1610738512;
 bh=3Vok87DT/Eflp4SNNq4KIIcOWog5q2U+/m7V3ojYnck=;
 h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
 b=qE6l4GbbdFUFFG+ZSrFa/dAlpp4eFEhrxK7RHfA4RWdaJpuRikc2qEsM7VHt4Gubt
 /qSnsbiNXQN75pBCudI1128H6HBFex2Dic5odc2xuifWdrhcfP7b9GiN7Xqx7A9Fr4
 C0aJB5aSP6B0EX2POxuAXszMEtEU3VgQxWuVSyOE=
Date: Fri, 15 Jan 2021 11:21:52 -0800
From: Tyler Retzlaff <roretzla@linux.microsoft.com>
To: Bruce Richardson <bruce.richardson@intel.com>
Cc: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>, dev@dpdk.org,
 navasile@linux.microsoft.com, stable@dpdk.org
Message-ID: <20210115192152.GA17930@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net>
References: <1610414325-9104-1-git-send-email-roretzla@linux.microsoft.com>
 <20210113205255.6e865a04@sovereign>
 <20210114054549.GA27612@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net>
 <20210114100557.3ec44961@sovereign>
 <20210114105554.GA1959@bricha3-MOBL.ger.corp.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210114105554.GA1959@bricha3-MOBL.ger.corp.intel.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Subject: Re: [dpdk-dev] [PATCH] eal/headers: explicitly cast void * to type *
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Thu, Jan 14, 2021 at 10:55:54AM +0000, Bruce Richardson wrote:
> > > > This is a private header, it's never exposed---why the change is
> > > > needed (not that I have a strong opinion, though)?  
> > > 
> > > interesting, i'll look into why/how it is being included and confirm. i
> > > suppose the question in the back of my mind is if it is private then
> > > why is the header being installed at all?

okay, i now understand how we ended up compiling this header directly. long
story short we just had it #include directly somewhere.

as you have noted it is a private header. a quick examination of the other
installed headers shows that it is not included by any of them.

i will update the patch to remove the cast from rte_ethdev_pci.h since it
is not necessary.

would you also like a patch submitted that stops installing the header. the
change will be breaking if any other consumers have made the same mistake as
we did. i'm not sure what dpdk's stance is on pulling headers back out of
public space.

thanks