From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A5AA3A0A05; Tue, 19 Jan 2021 17:05:18 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 74E55140EED; Tue, 19 Jan 2021 17:05:18 +0100 (CET) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by mails.dpdk.org (Postfix) with ESMTP id 3705B140EE7 for ; Tue, 19 Jan 2021 17:05:13 +0100 (CET) IronPort-SDR: zOP0vnFdN4K0fi5K61Sdf9SHmI4w88CWduesUFoIpxEDH4xcG+PBz1uBK09KOwZdHJhXLfo1Sv llsOqFFb+Tzg== X-IronPort-AV: E=McAfee;i="6000,8403,9869"; a="240488221" X-IronPort-AV: E=Sophos;i="5.79,359,1602572400"; d="scan'208";a="240488221" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Jan 2021 08:04:28 -0800 IronPort-SDR: GIsmdQSjG3FF1ul2Rc/4AwZtEGKeDvf7D1drP+91/1CDOFbQ6ca49O0cvqnfuo9El8V3878ame cWEgopdoQLVg== X-IronPort-AV: E=Sophos;i="5.79,359,1602572400"; d="scan'208";a="355671672" Received: from bricha3-mobl.ger.corp.intel.com ([10.252.18.163]) by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 19 Jan 2021 08:04:22 -0800 Date: Tue, 19 Jan 2021 16:04:18 +0000 From: Bruce Richardson To: Thomas Monjalon Cc: Juraj =?utf-8?Q?Linke=C5=A1?= , "Ruifeng.Wang@arm.com" , "Honnappa.Nagarahalli@arm.com" , "Phil.Yang@arm.com" , "vcchunga@amazon.com" , "Dharmik.Thakkar@arm.com" , "jerinjacobk@gmail.com" , "hemant.agrawal@nxp.com" , "ajit.khaparde@broadcom.com" , "ferruh.yigit@intel.com" , "aboyer@pensando.io" , "dev@dpdk.org" Message-ID: <20210119160418.GF1786@bricha3-MOBL.ger.corp.intel.com> References: <1608724059-8562-1-git-send-email-juraj.linkes@pantheon.tech> <4853612.H2Lh91oTzL@thomas> <41e763746e344be89a07adac8eefb712@pantheon.tech> <5100660.PnnWPLytas@thomas> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <5100660.PnnWPLytas@thomas> Subject: Re: [dpdk-dev] [PATCH v15 11/12] build: add Arm SoC meson option X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Jan 19, 2021 at 04:52:19PM +0100, Thomas Monjalon wrote: > 19/01/2021 15:56, Juraj Linkeš: > > From: Thomas Monjalon > > > 15/01/2021 14:26, Juraj Linkeš: > > > > Add Arm SoC configuration to Arm meson.build and add a meson option to > > > > enable those options for native builds. This is preferable to > > > > specifying a cross file when doing aarch64 -> aarch64 builds, since > > > > the cross file specifies the toolchain as well. > > > > > > > > Signed-off-by: Juraj Linkeš > > > > Reviewed-by: Honnappa Nagarahalli > > > [...] > > > > --- a/config/arm/arm64_graviton2_linux_gcc > > > > +++ b/config/arm/arm64_graviton2_linux_gcc > > > > [properties] > > > > -implementor_id = '0x41' > > > > -implementor_pn = '0xd0c' > > > > -max_lcores = 64 > > > > -max_numa_nodes = 1 > > > > -numa = false > > > > +soc = 'graviton2' > > > [...] > > > > --- a/meson_options.txt > > > > +++ b/meson_options.txt > > > > +option('arm_soc', type: 'string', value: '', > > > > + description: 'Specify if you want to build for a particular aarch64 > > > > +Arm SoC when building on an aarch64 machine.') > > > > > > This is more elegant, I like how cross and native share almost the same option. > > > > > > Why the option is named "arm_soc" and not just "soc"? > > > The same option could be used by other archs, isn't it? > > > > Agree that a more generic name would be better. > > I'll change it to "soc" if there are no other suggestions. > > Another name could be "machine". > Should it be the same mechanism as compiling for a specific x86 CPU > from an x86 machine? > I'd rather not re-use the term "machine", for a new use, better to use a new term IMHO.