From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 20489A0A05; Tue, 19 Jan 2021 22:31:00 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A125E140FA5; Tue, 19 Jan 2021 22:28:27 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mails.dpdk.org (Postfix) with ESMTP id 12935140FD3 for ; Tue, 19 Jan 2021 22:28:25 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1611091705; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=d0adfVQSlwLyludUabCDO/PONfRVafPkUC7zLT66aRk=; b=N4HJ5ZKG/Tqq2cuEjldNKgtG6YP9ujKyTRYQYokawLpzdL+rsW8NVreIxP1kFZzZDMtQoG rKWONA/qJyal6brU1fHvk9rRqgthD0n9fEfz3OV3JGdSjn5mkMkbRYIMXOxUZvpwUZrUkQ NLCqbCLYX255g4FA0/vW4/CBI9lnjR0= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-111-B-oyZceeMLOmv39Yhe8wDQ-1; Tue, 19 Jan 2021 16:28:22 -0500 X-MC-Unique: B-oyZceeMLOmv39Yhe8wDQ-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 281BC8066E8; Tue, 19 Jan 2021 21:28:21 +0000 (UTC) Received: from max-t490s.redhat.com (unknown [10.36.110.29]) by smtp.corp.redhat.com (Postfix) with ESMTP id 9476F5D9DD; Tue, 19 Jan 2021 21:28:16 +0000 (UTC) From: Maxime Coquelin To: dev@dpdk.org, chenbo.xia@intel.com, olivier.matz@6wind.com, amorenoz@redhat.com, david.marchand@redhat.com Cc: Maxime Coquelin Date: Tue, 19 Jan 2021 22:25:01 +0100 Message-Id: <20210119212507.1043636-39-maxime.coquelin@redhat.com> In-Reply-To: <20210119212507.1043636-1-maxime.coquelin@redhat.com> References: <20210119212507.1043636-1-maxime.coquelin@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=maxime.coquelin@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII" Subject: [dpdk-dev] [PATCH v2 38/44] net/virtio: move protocol features to Vhost-user X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Since only protocol features are specific to Vhost-user backend, this patch moves all related code to Vhost-user file. Signed-off-by: Maxime Coquelin --- drivers/net/virtio/virtio_user/vhost.h | 20 +---- drivers/net/virtio/virtio_user/vhost_kernel.c | 9 ++ drivers/net/virtio/virtio_user/vhost_user.c | 83 +++++++++++++++---- drivers/net/virtio/virtio_user/vhost_vdpa.c | 34 +++++++- .../net/virtio/virtio_user/virtio_user_dev.c | 47 ++--------- drivers/net/virtio/virtio_user_ethdev.c | 17 ---- 6 files changed, 113 insertions(+), 97 deletions(-) diff --git a/drivers/net/virtio/virtio_user/vhost.h b/drivers/net/virtio/virtio_user/vhost.h index 2aa6b2cb70..dfa2735a20 100644 --- a/drivers/net/virtio/virtio_user/vhost.h +++ b/drivers/net/virtio/virtio_user/vhost.h @@ -46,23 +46,6 @@ struct vhost_vring_addr { uint64_t log_guest_addr; }; -#ifndef VHOST_USER_F_PROTOCOL_FEATURES -#define VHOST_USER_F_PROTOCOL_FEATURES 30 -#endif - -/** Protocol features. */ -#ifndef VHOST_USER_PROTOCOL_F_MQ -#define VHOST_USER_PROTOCOL_F_MQ 0 -#endif - -#ifndef VHOST_USER_PROTOCOL_F_REPLY_ACK -#define VHOST_USER_PROTOCOL_F_REPLY_ACK 3 -#endif - -#ifndef VHOST_USER_PROTOCOL_F_STATUS -#define VHOST_USER_PROTOCOL_F_STATUS 16 -#endif - #ifndef VHOST_BACKEND_F_IOTLB_MSG_V2 #define VHOST_BACKEND_F_IOTLB_MSG_V2 1 #endif @@ -82,11 +65,10 @@ struct virtio_user_dev; struct virtio_user_backend_ops { int (*setup)(struct virtio_user_dev *dev); + int (*get_backend_features)(uint64_t *features); int (*set_owner)(struct virtio_user_dev *dev); int (*get_features)(struct virtio_user_dev *dev, uint64_t *features); int (*set_features)(struct virtio_user_dev *dev, uint64_t features); - int (*get_protocol_features)(struct virtio_user_dev *dev, uint64_t *features); - int (*set_protocol_features)(struct virtio_user_dev *dev, uint64_t features); int (*set_memory_table)(struct virtio_user_dev *dev); int (*set_vring_num)(struct virtio_user_dev *dev, struct vhost_vring_state *state); int (*set_vring_base)(struct virtio_user_dev *dev, struct vhost_vring_state *state); diff --git a/drivers/net/virtio/virtio_user/vhost_kernel.c b/drivers/net/virtio/virtio_user/vhost_kernel.c index 68f0c0b83d..5477eb7015 100644 --- a/drivers/net/virtio/virtio_user/vhost_kernel.c +++ b/drivers/net/virtio/virtio_user/vhost_kernel.c @@ -445,8 +445,17 @@ vhost_kernel_enable_queue_pair(struct virtio_user_dev *dev, return 0; } +static int +vhost_kernel_get_backend_features(uint64_t *features) +{ + *features = 0; + + return 0; +} + struct virtio_user_backend_ops virtio_ops_kernel = { .setup = vhost_kernel_setup, + .get_backend_features = vhost_kernel_get_backend_features, .set_owner = vhost_kernel_set_owner, .get_features = vhost_kernel_get_features, .set_features = vhost_kernel_set_features, diff --git a/drivers/net/virtio/virtio_user/vhost_user.c b/drivers/net/virtio/virtio_user/vhost_user.c index a48fadd8c9..986d8ac1ac 100644 --- a/drivers/net/virtio/virtio_user/vhost_user.c +++ b/drivers/net/virtio/virtio_user/vhost_user.c @@ -17,6 +17,29 @@ #include "vhost.h" #include "virtio_user_dev.h" + +#ifndef VHOST_USER_F_PROTOCOL_FEATURES +#define VHOST_USER_F_PROTOCOL_FEATURES 30 +#endif + +/** Protocol features. */ +#ifndef VHOST_USER_PROTOCOL_F_MQ +#define VHOST_USER_PROTOCOL_F_MQ 0 +#endif + +#ifndef VHOST_USER_PROTOCOL_F_REPLY_ACK +#define VHOST_USER_PROTOCOL_F_REPLY_ACK 3 +#endif + +#ifndef VHOST_USER_PROTOCOL_F_STATUS +#define VHOST_USER_PROTOCOL_F_STATUS 16 +#endif + +#define VHOST_USER_SUPPORTED_PROTOCOL_FEATURES \ + (1ULL << VHOST_USER_PROTOCOL_F_MQ | \ + 1ULL << VHOST_USER_PROTOCOL_F_REPLY_ACK | \ + 1ULL << VHOST_USER_PROTOCOL_F_STATUS) + /* The version of the protocol we support */ #define VHOST_USER_VERSION 0x1 @@ -205,11 +228,11 @@ vhost_user_set_owner(struct virtio_user_dev *dev) } static int -vhost_user_get_features(struct virtio_user_dev *dev, uint64_t *features) +vhost_user_get_protocol_features(struct virtio_user_dev *dev, uint64_t *features) { int ret; struct vhost_user_msg msg = { - .request = VHOST_USER_GET_FEATURES, + .request = VHOST_USER_GET_PROTOCOL_FEATURES, .flags = VHOST_USER_VERSION, }; @@ -221,7 +244,7 @@ vhost_user_get_features(struct virtio_user_dev *dev, uint64_t *features) if (ret < 0) goto err; - if (msg.request != VHOST_USER_GET_FEATURES) { + if (msg.request != VHOST_USER_GET_PROTOCOL_FEATURES) { PMD_DRV_LOG(ERR, "Unexpected request type (%d)", msg.request); goto err; } @@ -235,27 +258,25 @@ vhost_user_get_features(struct virtio_user_dev *dev, uint64_t *features) return 0; err: - PMD_DRV_LOG(ERR, "Failed to get backend features"); + PMD_DRV_LOG(ERR, "Failed to get backend protocol features"); return -1; } static int -vhost_user_set_features(struct virtio_user_dev *dev, uint64_t features) +vhost_user_set_protocol_features(struct virtio_user_dev *dev, uint64_t features) { int ret; struct vhost_user_msg msg = { - .request = VHOST_USER_SET_FEATURES, + .request = VHOST_USER_SET_PROTOCOL_FEATURES, .flags = VHOST_USER_VERSION, .size = sizeof(features), .payload.u64 = features, }; - msg.payload.u64 |= dev->device_features & (1ULL << VHOST_USER_F_PROTOCOL_FEATURES); - ret = vhost_user_write(dev->vhostfd, &msg, NULL, 0); if (ret < 0) { - PMD_DRV_LOG(ERR, "Failed to set features"); + PMD_DRV_LOG(ERR, "Failed to set protocol features"); return -1; } @@ -263,11 +284,11 @@ vhost_user_set_features(struct virtio_user_dev *dev, uint64_t features) } static int -vhost_user_get_protocol_features(struct virtio_user_dev *dev, uint64_t *features) +vhost_user_get_features(struct virtio_user_dev *dev, uint64_t *features) { int ret; struct vhost_user_msg msg = { - .request = VHOST_USER_GET_PROTOCOL_FEATURES, + .request = VHOST_USER_GET_FEATURES, .flags = VHOST_USER_VERSION, }; @@ -279,7 +300,7 @@ vhost_user_get_protocol_features(struct virtio_user_dev *dev, uint64_t *features if (ret < 0) goto err; - if (msg.request != VHOST_USER_GET_PROTOCOL_FEATURES) { + if (msg.request != VHOST_USER_GET_FEATURES) { PMD_DRV_LOG(ERR, "Unexpected request type (%d)", msg.request); goto err; } @@ -291,27 +312,46 @@ vhost_user_get_protocol_features(struct virtio_user_dev *dev, uint64_t *features *features = msg.payload.u64; + if (!(*features & (1ULL << VHOST_USER_F_PROTOCOL_FEATURES))) + return 0; + + /* Negotiate protocol features */ + ret = vhost_user_get_protocol_features(dev, &dev->protocol_features); + if (ret < 0) + goto err; + + dev->protocol_features &= VHOST_USER_SUPPORTED_PROTOCOL_FEATURES; + + ret = vhost_user_set_protocol_features(dev, dev->protocol_features); + if (ret < 0) + goto err; + + if (!(dev->protocol_features & (1ULL << VHOST_USER_PROTOCOL_F_MQ))) + dev->unsupported_features |= (1ull << VIRTIO_NET_F_MQ); + return 0; err: - PMD_DRV_LOG(ERR, "Failed to get backend protocol features"); + PMD_DRV_LOG(ERR, "Failed to get backend features"); return -1; } static int -vhost_user_set_protocol_features(struct virtio_user_dev *dev, uint64_t features) +vhost_user_set_features(struct virtio_user_dev *dev, uint64_t features) { int ret; struct vhost_user_msg msg = { - .request = VHOST_USER_SET_PROTOCOL_FEATURES, + .request = VHOST_USER_SET_FEATURES, .flags = VHOST_USER_VERSION, .size = sizeof(features), .payload.u64 = features, }; + msg.payload.u64 |= dev->device_features & (1ULL << VHOST_USER_F_PROTOCOL_FEATURES); + ret = vhost_user_write(dev->vhostfd, &msg, NULL, 0); if (ret < 0) { - PMD_DRV_LOG(ERR, "Failed to set protocol features"); + PMD_DRV_LOG(ERR, "Failed to set features"); return -1; } @@ -780,13 +820,20 @@ vhost_user_enable_queue_pair(struct virtio_user_dev *dev, return 0; } +static int +vhost_user_get_backend_features(uint64_t *features) +{ + *features = 1ULL << VHOST_USER_F_PROTOCOL_FEATURES; + + return 0; +} + struct virtio_user_backend_ops virtio_ops_user = { .setup = vhost_user_setup, + .get_backend_features = vhost_user_get_backend_features, .set_owner = vhost_user_set_owner, .get_features = vhost_user_get_features, .set_features = vhost_user_set_features, - .get_protocol_features = vhost_user_get_protocol_features, - .set_protocol_features = vhost_user_set_protocol_features, .set_memory_table = vhost_user_set_memory_table, .set_vring_num = vhost_user_set_vring_num, .set_vring_base = vhost_user_set_vring_base, diff --git a/drivers/net/virtio/virtio_user/vhost_vdpa.c b/drivers/net/virtio/virtio_user/vhost_vdpa.c index 7fb1249569..8d354b298e 100644 --- a/drivers/net/virtio/virtio_user/vhost_vdpa.c +++ b/drivers/net/virtio/virtio_user/vhost_vdpa.c @@ -13,6 +13,10 @@ #include "vhost.h" #include "virtio_user_dev.h" +#define VHOST_VDPA_SUPPORTED_BACKEND_FEATURES \ + (1ULL << VHOST_BACKEND_F_IOTLB_MSG_V2 | \ + 1ULL << VHOST_BACKEND_F_IOTLB_BATCH) + /* vhost kernel & vdpa ioctls */ #define VHOST_VIRTIO 0xAF #define VHOST_GET_FEATURES _IOR(VHOST_VIRTIO, 0x00, __u64) @@ -88,13 +92,13 @@ vhost_vdpa_set_owner(struct virtio_user_dev *dev) } static int -vhost_vdpa_get_backend_features(struct virtio_user_dev *dev, uint64_t *features) +vhost_vdpa_get_protocol_features(struct virtio_user_dev *dev, uint64_t *features) { return vhost_vdpa_ioctl(dev->vhostfd, VHOST_GET_BACKEND_FEATURES, features); } static int -vhost_vdpa_set_backend_features(struct virtio_user_dev *dev, uint64_t features) +vhost_vdpa_set_protocol_features(struct virtio_user_dev *dev, uint64_t features) { return vhost_vdpa_ioctl(dev->vhostfd, VHOST_SET_BACKEND_FEATURES, &features); } @@ -113,6 +117,21 @@ vhost_vdpa_get_features(struct virtio_user_dev *dev, uint64_t *features) /* Multiqueue not supported for now */ *features &= ~(1ULL << VIRTIO_NET_F_MQ); + /* Negotiated vDPA backend features */ + ret = vhost_vdpa_get_protocol_features(dev, &dev->protocol_features); + if (ret < 0) { + PMD_DRV_LOG(ERR, "Failed to get backend features"); + return -1; + } + + dev->protocol_features &= VHOST_VDPA_SUPPORTED_BACKEND_FEATURES; + + ret = vhost_vdpa_set_protocol_features(dev, dev->protocol_features); + if (ret < 0) { + PMD_DRV_LOG(ERR, "Failed to set backend features"); + return -1; + } + return 0; } @@ -438,13 +457,20 @@ vhost_vdpa_enable_queue_pair(struct virtio_user_dev *dev, return 0; } +static int +vhost_vdpa_get_backend_features(uint64_t *features) +{ + *features = 0; + + return 0; +} + struct virtio_user_backend_ops virtio_ops_vdpa = { .setup = vhost_vdpa_setup, + .get_backend_features = vhost_vdpa_get_backend_features, .set_owner = vhost_vdpa_set_owner, .get_features = vhost_vdpa_get_features, .set_features = vhost_vdpa_set_features, - .get_protocol_features = vhost_vdpa_get_backend_features, - .set_protocol_features = vhost_vdpa_set_backend_features, .set_memory_table = vhost_vdpa_set_memory_table, .set_vring_num = vhost_vdpa_set_vring_num, .set_vring_base = vhost_vdpa_set_vring_base, diff --git a/drivers/net/virtio/virtio_user/virtio_user_dev.c b/drivers/net/virtio/virtio_user/virtio_user_dev.c index c2a41fe3a0..2614bcb349 100644 --- a/drivers/net/virtio/virtio_user/virtio_user_dev.c +++ b/drivers/net/virtio/virtio_user/virtio_user_dev.c @@ -480,24 +480,15 @@ virtio_user_dev_setup(struct virtio_user_dev *dev) 1ULL << VIRTIO_NET_F_GUEST_TSO6 | \ 1ULL << VIRTIO_F_IN_ORDER | \ 1ULL << VIRTIO_F_VERSION_1 | \ - 1ULL << VIRTIO_F_RING_PACKED | \ - 1ULL << VHOST_USER_F_PROTOCOL_FEATURES) + 1ULL << VIRTIO_F_RING_PACKED) -#define VHOST_USER_SUPPORTED_PROTOCOL_FEATURES \ - (1ULL << VHOST_USER_PROTOCOL_F_MQ | \ - 1ULL << VHOST_USER_PROTOCOL_F_REPLY_ACK | \ - 1ULL << VHOST_USER_PROTOCOL_F_STATUS) - -#define VHOST_VDPA_SUPPORTED_PROTOCOL_FEATURES \ - (1ULL << VHOST_BACKEND_F_IOTLB_MSG_V2 | \ - 1ULL << VHOST_BACKEND_F_IOTLB_BATCH) int virtio_user_dev_init(struct virtio_user_dev *dev, char *path, int queues, int cq, int queue_size, const char *mac, char **ifname, int server, int mrg_rxbuf, int in_order, int packed_vq, enum virtio_user_backend_type backend_type) { - uint64_t protocol_features = 0; + uint64_t backend_features; pthread_mutex_init(&dev->mutex, NULL); strlcpy(dev->path, path, PATH_MAX); @@ -508,14 +499,9 @@ virtio_user_dev_init(struct virtio_user_dev *dev, char *path, int queues, dev->is_server = server; dev->mac_specified = 0; dev->frontend_features = 0; - dev->unsupported_features = ~VIRTIO_USER_SUPPORTED_FEATURES; + dev->unsupported_features = 0; dev->backend_type = backend_type; - if (dev->backend_type == VIRTIO_USER_BACKEND_VHOST_USER) - dev->protocol_features = VHOST_USER_SUPPORTED_PROTOCOL_FEATURES; - else if (dev->backend_type == VIRTIO_USER_BACKEND_VHOST_VDPA) - dev->protocol_features = VHOST_VDPA_SUPPORTED_PROTOCOL_FEATURES; - parse_mac(dev, mac); if (*ifname) { @@ -528,38 +514,21 @@ virtio_user_dev_init(struct virtio_user_dev *dev, char *path, int queues, return -1; } - if (dev->backend_type != VIRTIO_USER_BACKEND_VHOST_USER) - dev->unsupported_features |= - (1ULL << VHOST_USER_F_PROTOCOL_FEATURES); - if (dev->ops->set_owner(dev) < 0) { PMD_INIT_LOG(ERR, "(%s) Failed to set backend owner", dev->path); return -1; } - if (dev->ops->get_features(dev, &dev->device_features) < 0) { + if (dev->ops->get_backend_features(&backend_features) < 0) { PMD_INIT_LOG(ERR, "(%s) Failed to get backend features", dev->path); return -1; } - if ((dev->device_features & (1ULL << VHOST_USER_F_PROTOCOL_FEATURES)) || - dev->backend_type == VIRTIO_USER_BACKEND_VHOST_VDPA) { - if (dev->ops->get_protocol_features(dev, &protocol_features)) { - PMD_INIT_LOG(ERR, "(%s) Failed to get backend protocol features", - dev->path); - return -1; - } - - dev->protocol_features &= protocol_features; - - if (dev->ops->set_protocol_features(dev, dev->protocol_features)) { - PMD_INIT_LOG(ERR, "(%s) Failed to set backend protocol features", - dev->path); - return -1; - } + dev->unsupported_features = ~(VIRTIO_USER_SUPPORTED_FEATURES | backend_features); - if (!(dev->protocol_features & (1ULL << VHOST_USER_PROTOCOL_F_MQ))) - dev->unsupported_features |= (1ull << VIRTIO_NET_F_MQ); + if (dev->ops->get_features(dev, &dev->device_features) < 0) { + PMD_INIT_LOG(ERR, "(%s) Failed to get device features", dev->path); + return -1; } if (!mrg_rxbuf) diff --git a/drivers/net/virtio/virtio_user_ethdev.c b/drivers/net/virtio/virtio_user_ethdev.c index e822d93690..e2c606a838 100644 --- a/drivers/net/virtio/virtio_user_ethdev.c +++ b/drivers/net/virtio/virtio_user_ethdev.c @@ -70,7 +70,6 @@ virtio_user_server_reconnect(struct virtio_user_dev *dev) int ret, connectfd, old_status; struct rte_eth_dev *eth_dev = &rte_eth_devices[dev->port_id]; struct virtio_hw *hw = &dev->hw; - uint64_t protocol_features; connectfd = accept(dev->listenfd, NULL, NULL); if (connectfd < 0) @@ -91,22 +90,6 @@ virtio_user_server_reconnect(struct virtio_user_dev *dev) return -1; } - if (dev->device_features & - (1ULL << VHOST_USER_F_PROTOCOL_FEATURES)) { - if (dev->ops->get_protocol_features(dev, &protocol_features)) - return -1; - - /* Offer VHOST_USER_PROTOCOL_F_STATUS */ - dev->protocol_features |= (1ULL << VHOST_USER_PROTOCOL_F_STATUS); - dev->protocol_features &= protocol_features; - - if (dev->ops->set_protocol_features(dev, dev->protocol_features)) - return -1; - - if (!(dev->protocol_features & (1ULL << VHOST_USER_PROTOCOL_F_MQ))) - dev->unsupported_features |= (1ull << VIRTIO_NET_F_MQ); - } - dev->device_features |= dev->frontend_features; /* umask vhost-user unsupported features */ -- 2.29.2