From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3767EA0A05; Tue, 19 Jan 2021 22:31:53 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id AC23A140F88; Tue, 19 Jan 2021 22:31:27 +0100 (CET) Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mails.dpdk.org (Postfix) with ESMTP id 10143140F87 for ; Tue, 19 Jan 2021 22:31:26 +0100 (CET) Received: by linux.microsoft.com (Postfix, from userid 1086) id 630B120B7192; Tue, 19 Jan 2021 13:31:25 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 630B120B7192 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1611091885; bh=m49ryBAV794pa9oCvavorNqn2t45Z0DY5hPbeD3JYEU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=MYvpDYZGzme9GCqsIYxLFuR55o3Vk9i/ex6WaxaEm0gMexRy8q8GFVlL4HZ0V912W FImWnE9rEryVfoWNIuvjeNboTyxB1BqsNX3irDZrEHUXPPAKaU1x4/vr9YTdGLZX8q dSISFxo1RTR11JFeePhu3FYaNJPob9uBnM2R2sMU= Date: Tue, 19 Jan 2021 13:31:25 -0800 From: Tyler Retzlaff To: Thomas Monjalon Cc: dev@dpdk.org, dmitry.kozliuk@gmail.com, navasile@linux.microsoft.com, ciara.power@intel.com, bruce.richardson@intel.com Message-ID: <20210119213125.GA1983@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> References: <1610408246-29482-1-git-send-email-roretzla@linux.microsoft.com> <1610415051-10593-1-git-send-email-roretzla@linux.microsoft.com> <4843599.5pFrObeWOY@thomas> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4843599.5pFrObeWOY@thomas> User-Agent: Mutt/1.5.21 (2010-09-15) Subject: Re: [dpdk-dev] [PATCH v2] metrics/windows: build rte_metrics library X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Sun, Jan 17, 2021 at 11:19:55PM +0100, Thomas Monjalon wrote: > > Not sure it makes sense without the new telemetry feature. > Please focus on telemetry lib instead of half-enabling > the old metrics lib. > can you elaborate? (or reference a mailing list discussion) that gives some guidance? is the telemetry lib a replacement for metrics? the component we have now relies on the non-telemetry functions exported from metrics but does not use the telemetry functions. also, i notice that the meson.build for telemetry lib has an include path that references rte_metrics but does not appear to actually include any of the headers from rte_metrics (vestigial? missed in previous cleanup perhaps?) thanks!