From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6524FA0A05; Wed, 20 Jan 2021 08:23:19 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E68F4140D67; Wed, 20 Jan 2021 08:23:18 +0100 (CET) Received: from mail-lf1-f50.google.com (mail-lf1-f50.google.com [209.85.167.50]) by mails.dpdk.org (Postfix) with ESMTP id 42F0F140D4B; Wed, 20 Jan 2021 08:23:17 +0100 (CET) Received: by mail-lf1-f50.google.com with SMTP id o10so32741918lfl.13; Tue, 19 Jan 2021 23:23:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=KhMYue1t18FUbDV9DQSnJfW9aKoZoduH+/ypKlohr1U=; b=rvsbXuzDUbwGFYUrECkay0arIcPDnpP5DanpSLg+VnGpmXrkiyPdSO//IcOsoy8+CF pR8PASusIMHI2Gc+2KAn4jJPJXOGXMRKEKwANL8cCBsW13JWAmTUnM9/aflhk7RPukHw 0rIHCDrzg6VQ8eHEwtaA1dGwFPNFbzm3IvIkj80qnCepHdYBAsrNEen77ZlhRCkX2aNG 1RBSpPr0fK+S4vJSdIMCbPdNqU/mb28SbQwVSN+8TWjbMiNSjh6D6REVX07xUHgUk7wy 5PiGi9/blnmSfstlFB8rNVshCrfTetSDLodawT5PG09bX4mCJjK1ysPiKUKWPIbxwyZa u3xA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=KhMYue1t18FUbDV9DQSnJfW9aKoZoduH+/ypKlohr1U=; b=gleMLFQxm43FldxBcKeW/yV2jRCIjdHHH1lowsconyvgmZN2xYppsVerrtwI7FWhda Il0baipq8f3AVfthp0AwQ4qZ3NZC9OOhGAdRRzfwEYe7dLtULGVfj+hFW9H0LlXS4eEd G1KcRJQSVGCjZU1nNk+QDVyDdZvLlNwFDxanT6eEqB8OfSptNEe5md5dkZdIWugwVaNM DLHDyVNjik/LpHO4YKgc6gh0gHcLE/Lf+AeMot4mDtZ3pXFJv1fxWQgESwxfgj7+1EuD PmYqfJOKAuYDsn15Rrv+hNpLhrWq5zXY+7RrtoqAL2LTbZN3W1ppITu7Cp0Fh84KaDKi Xcug== X-Gm-Message-State: AOAM533oZ4ZYKuq0ZpKkbgVz4IefFP0AKv7OQw8uNkhl9dKj4VKarLaJ v2gfrBBkNmzduy+dNnU0aH8= X-Google-Smtp-Source: ABdhPJwZ1wwTCzglame/LqowPX8ettsx1ae7UCDbwe5MCrd43gAJvs7A5HQ+wnr4d+gN7vIfDhlqsw== X-Received: by 2002:ac2:4431:: with SMTP id w17mr3345595lfl.223.1611127396682; Tue, 19 Jan 2021 23:23:16 -0800 (PST) Received: from sovereign (broadband-37-110-65-23.ip.moscow.rt.ru. [37.110.65.23]) by smtp.gmail.com with ESMTPSA id v21sm114773ljk.73.2021.01.19.23.23.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 Jan 2021 23:23:15 -0800 (PST) Date: Wed, 20 Jan 2021 10:23:14 +0300 From: Dmitry Kozlyuk To: Thomas Monjalon Cc: dev@dpdk.org, ci@dpdk.org, Stephen Hemminger , David Marchand , Maxime Coquelin , Aaron Conole , Bruce Richardson , ferruh.yigit@intel.com Message-ID: <20210120102314.0235dfc1@sovereign> In-Reply-To: <5629972.kJsfQy86Dy@thomas> References: <20201014183136.22239-1-dmitry.kozliuk@gmail.com> <20201020174404.28653-1-dmitry.kozliuk@gmail.com> <20201020174404.28653-3-dmitry.kozliuk@gmail.com> <5629972.kJsfQy86Dy@thomas> X-Mailer: Claws Mail 3.17.6 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v8 2/3] build: use Python pmdinfogen X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, 20 Jan 2021 01:05:59 +0100, Thomas Monjalon wrote: > This is now the right timeframe to introduce this change > with the new Python module dependency. > Unfortunately, the ABI check is returning an issue: > > 'const char mlx5_common_pci_pmd_info[62]' was changed > to 'const char mlx5_common_pci_pmd_info[60]' at rte_common_mlx5.pmd.c Will investigate and fix ASAP. > Few more comments below: > > 20/10/2020 19:44, Dmitry Kozlyuk: > > --- a/buildtools/meson.build > > +++ b/buildtools/meson.build > > +if host_machine.system() != 'windows' > > You can use "is_windows". It's defined by config/meson.build, which is processed after buidtools/meson.build, because of the dependency, if swapped: config/x86/meson.build:6:1: ERROR: Unknown variable "binutils_avx512_check". > > --- a/doc/guides/linux_gsg/sys_reqs.rst > > +++ b/doc/guides/linux_gsg/sys_reqs.rst > > +* ``pyelftools`` (version 0.22+) > > This requirement is missing in doc/guides/freebsd_gsg/build_dpdk.rst OK. > > --- a/meson.build > > +++ b/meson.build > > -subdir('buildtools/pmdinfogen') > > This could be in patch 3 (removing the code). It would redefine "pmdinfogen" variable to old pmdinfogen. Besides, why build what's not used at this patch already?