From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9B39EA0A0A; Wed, 20 Jan 2021 20:27:41 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 292EF140CF0; Wed, 20 Jan 2021 20:27:41 +0100 (CET) Received: from mail-lj1-f175.google.com (mail-lj1-f175.google.com [209.85.208.175]) by mails.dpdk.org (Postfix) with ESMTP id E852A140CEF for ; Wed, 20 Jan 2021 20:27:39 +0100 (CET) Received: by mail-lj1-f175.google.com with SMTP id i17so2276973ljn.1 for ; Wed, 20 Jan 2021 11:27:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=4nYDEUB+TS5jbEvDdpRUu/3Cqxz74KBvVRhoaLdyE3c=; b=M3xfTxTRn5UPxUaBn0OoCzDnGKRT9gFauL2poHzYbg7OvL9yax9wMyP6Cxm7NKTTMO y3+HBDBBOaN/mig3bTIzUgfZy2V7PVL3NDWfOR19rmq6gF9nvkPGYpLU5Zh+IowOn9yE pxtHZAM9aWmdmMv+3QYm3DPA5NZi33Q61mWzCy2euCZYFHXifo34jMU9pDvqjtflgMSj UBPlcZb8mGwX9qMBWrHowj81y4B5M0dLJ9wZYFO2Pw/ZRMgVRpDl8v1YDMopIvI634HQ 8mr/GjevC8oZQfX6tOPJp137dxTLP1qYe11TFvXxvtML9ma61c0nLbRII49zIEKVcf0e VPZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=4nYDEUB+TS5jbEvDdpRUu/3Cqxz74KBvVRhoaLdyE3c=; b=GhpCMhsI6FdhLwv0FpfBfHYRNJHN2KFNaS+vFmFgNROFZU/lHXqZH+tOWHQQEE1EV5 0+sFjsqYODxQm9C13MFEIzP4roefpsRkUnHVcc+57j+qcxcE0eiWhq+sNN0lLeKaMCtJ n65QuDcNqB/6qkjURIunxyTNc9SB11p74WLObB86Fz47+bb55bXoR66t48+LnycoTNRh H+l+NUiFddUGTZx+Ey+3kvWif4TU9TK6Fx7sik9DL9qsLkgzTgmX+1KDV9fqA7TPH8g6 8X2Byw1SoLWYj7kGQ+i3HCKPjOIe/oVhtSw14OXmBcsI6LN5bqcm9JV0kcrEEBYUu+RB CoHQ== X-Gm-Message-State: AOAM531JOV7vk2UpjalfAziE7MM992EVJGCfDKNrsU2hsqeXQghs8wIA BhPI9YAAOGKQL0jIQvUqu1c= X-Google-Smtp-Source: ABdhPJwFy59HEwBQPyxv/CXr4pJ6WEDLwnLtN93LMZPfOWR1uCS0kHU9gUBQlf2TcdWsqQv0Es2Qzw== X-Received: by 2002:a2e:8ec7:: with SMTP id e7mr5085536ljl.249.1611170859497; Wed, 20 Jan 2021 11:27:39 -0800 (PST) Received: from sovereign (broadband-37-110-65-23.ip.moscow.rt.ru. [37.110.65.23]) by smtp.gmail.com with ESMTPSA id b4sm127172ljp.53.2021.01.20.11.27.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 Jan 2021 11:27:38 -0800 (PST) Date: Wed, 20 Jan 2021 22:27:37 +0300 From: Dmitry Kozlyuk To: Ferruh Yigit Cc: David Marchand , dev@dpdk.org, navasile@linux.microsoft.com, dmitrym@microsoft.com, pallavi.kadam@intel.com, Beilei Xing , Jeff Guo , Wenzhuo Lu , Leyi Rong , Bruce Richardson Message-ID: <20210120222737.5f1fbd5c@sovereign> In-Reply-To: <77c3a7fb-a703-4b8d-62b5-f81dcfcca15a@intel.com> References: <20210120164016.26745-1-david.marchand@redhat.com> <20210120212124.72fe1289@sovereign> <77c3a7fb-a703-4b8d-62b5-f81dcfcca15a@intel.com> X-Mailer: Claws Mail 3.17.6 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] net/i40e: disable AVX512 for Windows X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, 20 Jan 2021 18:24:43 +0000, Ferruh Yigit wrote: > On 1/20/2021 6:21 PM, Dmitry Kozlyuk wrote: > > On Wed, 20 Jan 2021 17:40:16 +0100, David Marchand wrote: > >> There is probably better to do rather than disabling AVX512 globally for > >> Windows but since I saw no patch fixing this, here it is. > >> > >> --- > >> drivers/net/i40e/meson.build | 2 +- > >> 1 file changed, 1 insertion(+), 1 deletion(-) > >> > >> diff --git a/drivers/net/i40e/meson.build b/drivers/net/i40e/meson.build > >> index c0acdf4fd4..c9a1a50407 100644 > >> --- a/drivers/net/i40e/meson.build > >> +++ b/drivers/net/i40e/meson.build > >> @@ -54,7 +54,7 @@ if arch_subdir == 'x86' > >> cc.has_argument('-mavx512f') and > >> cc.has_argument('-mavx512bw')) > >> > >> - if i40e_avx512_cpu_support == true or i40e_avx512_cc_support == true > >> + if not is_windows and (i40e_avx512_cpu_support == true or i40e_avx512_cc_support == true) > >> cflags += ['-DCC_AVX512_SUPPORT'] > >> avx512_args = [cflags, '-mavx512f', '-mavx512bw'] > >> if cc.has_argument('-march=skylake-avx512') > > > > Clang doesn't seem to be affected, suggesting a cc.get_id() == 'gcc' check. > > > > The error seems related to SEH (structured exception handling). Some MinGW > > flavours don't use it, which can explain why the bug isn't not 100% > > reproducible. IMO, just disabling AVX512 for MinGW is enough. > > > > Is there a way to disable it selectively, only for the compiler versions that > doesn't support it? It was a guesswork and it proved wrong, setsmp/longjmp flavour [1] with GCC 8.1.0 also fails. Fedora 32 has GCC 9.2.1 (works), while Fedora 33 has GCC 10.2.1 (fails). I use a reproducible environment [2] with GCC 9.3.0, which succeeds. Seems like GCC 9 is the only known version that works, which is pretty close to "doesn't work with MinGW at all". [1]: https://sourceforge.net/projects/mingw-w64/files/Toolchains%20targetting%20Win64/Personal%20Builds/mingw-builds/8.1.0/threads-win32/sjlj/x86_64-8.1.0-release-win32-sjlj-rt_v6-rev0.7z [2]: https://github.com/PlushBeaver/nix-shells/tree/master/dpdk