DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH v2] net/ice: drain out DCF AdminQ command queue
       [not found] <220210121141804.83855-1-haiyue.wang@intel.com>
@ 2021-01-21 14:23 ` Haiyue Wang
  2021-01-21 17:31 ` [dpdk-dev] [PATCH v3] " Haiyue Wang
  1 sibling, 0 replies; 3+ messages in thread
From: Haiyue Wang @ 2021-01-21 14:23 UTC (permalink / raw)
  To: dev; +Cc: qiming.yang, qi.z.zhang, qi.fu, Haiyue Wang, stable

The virtchnl command message response is handled by matching the opcode
only for limitation.

The DCF AdminQ command with buffer data needs two virtchnl commands, one
is to handle the AdminQ header, the other is to handle AdminQ buffer. If
the AdminQ header command gets the failure response, the AdminQ buffer
command needs to wait for the buffer message response until timeout to
drain out the virtchnl command queue, since both of them are sent to PF,
the PF will handle them one by one, and send back the response. If not,
it will cause the next AdminQ command failure with the stall response.

Fixes: daa714d55c72 ("net/ice: handle AdminQ command by DCF")
Cc: stable@dpdk.org

Signed-off-by: Haiyue Wang <haiyue.wang@intel.com>
---
v2: Fix the commit message typo : 'matchiing' should be 'matching'
---
 drivers/net/ice/ice_dcf.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/net/ice/ice_dcf.c b/drivers/net/ice/ice_dcf.c
index 4a9af3292c..a211797d9e 100644
--- a/drivers/net/ice/ice_dcf.c
+++ b/drivers/net/ice/ice_dcf.c
@@ -506,7 +506,6 @@ ice_dcf_send_aq_cmd(void *dcf_hw, struct ice_aq_desc *desc,
 
 	do {
 		if ((!desc_cmd.pending && !buff_cmd.pending) ||
-		    (!desc_cmd.pending && desc_cmd.v_ret != IAVF_SUCCESS) ||
 		    (!buff_cmd.pending && buff_cmd.v_ret != IAVF_SUCCESS))
 			break;
 
-- 
2.30.0


^ permalink raw reply	[flat|nested] 3+ messages in thread

* [dpdk-dev] [PATCH v3] net/ice: drain out DCF AdminQ command queue
       [not found] <220210121141804.83855-1-haiyue.wang@intel.com>
  2021-01-21 14:23 ` [dpdk-dev] [PATCH v2] net/ice: drain out DCF AdminQ command queue Haiyue Wang
@ 2021-01-21 17:31 ` Haiyue Wang
  2021-01-22  2:38   ` Zhang, Qi Z
  1 sibling, 1 reply; 3+ messages in thread
From: Haiyue Wang @ 2021-01-21 17:31 UTC (permalink / raw)
  To: dev; +Cc: qiming.yang, qi.z.zhang, qi.fu, Haiyue Wang, stable

The virtchnl message is handled one by one by checking opcode to match
the response for the request.

The DCF AdminQ command with buffer needs two virtchnl commands, one is
to handle the AdminQ descriptor, the other is to the handle AdminQ
buffer. If both of them are sent to PF successfully, it needs to wait
two responses from PF, even if the AdminQ descriptor command gets the
failure response. Since PF will handle them one by one, and send back
the response for each.

If not wait for the buffer message response until timeout to drain out
the virtchnl command queue, it will cause the next AdminQ command with
buffer to get the stall buffer response from previous.

Fixes: daa714d55c72 ("net/ice: handle AdminQ command by DCF")
Cc: stable@dpdk.org

Signed-off-by: Haiyue Wang <haiyue.wang@intel.com>
---
v3: Reword the commit message, and remove the no needed checking.
v2: Fix the commit message typo : 'matchiing' should be 'matching'
---
 drivers/net/ice/ice_dcf.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/net/ice/ice_dcf.c b/drivers/net/ice/ice_dcf.c
index 4a9af3292c..d947d02c5b 100644
--- a/drivers/net/ice/ice_dcf.c
+++ b/drivers/net/ice/ice_dcf.c
@@ -505,9 +505,7 @@ ice_dcf_send_aq_cmd(void *dcf_hw, struct ice_aq_desc *desc,
 	}
 
 	do {
-		if ((!desc_cmd.pending && !buff_cmd.pending) ||
-		    (!desc_cmd.pending && desc_cmd.v_ret != IAVF_SUCCESS) ||
-		    (!buff_cmd.pending && buff_cmd.v_ret != IAVF_SUCCESS))
+		if (!desc_cmd.pending && !buff_cmd.pending)
 			break;
 
 		rte_delay_ms(ICE_DCF_ARQ_CHECK_TIME);
-- 
2.30.0


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-dev] [PATCH v3] net/ice: drain out DCF AdminQ command queue
  2021-01-21 17:31 ` [dpdk-dev] [PATCH v3] " Haiyue Wang
@ 2021-01-22  2:38   ` Zhang, Qi Z
  0 siblings, 0 replies; 3+ messages in thread
From: Zhang, Qi Z @ 2021-01-22  2:38 UTC (permalink / raw)
  To: Wang, Haiyue, dev; +Cc: Yang, Qiming, Fu, Qi, stable



> -----Original Message-----
> From: Wang, Haiyue <haiyue.wang@intel.com>
> Sent: Friday, January 22, 2021 1:32 AM
> To: dev@dpdk.org
> Cc: Yang, Qiming <qiming.yang@intel.com>; Zhang, Qi Z
> <qi.z.zhang@intel.com>; Fu, Qi <qi.fu@intel.com>; Wang, Haiyue
> <haiyue.wang@intel.com>; stable@dpdk.org
> Subject: [PATCH v3] net/ice: drain out DCF AdminQ command queue
> 
> The virtchnl message is handled one by one by checking opcode to match the
> response for the request.
> 
> The DCF AdminQ command with buffer needs two virtchnl commands, one is to
> handle the AdminQ descriptor, the other is to the handle AdminQ buffer. If both
> of them are sent to PF successfully, it needs to wait two responses from PF,
> even if the AdminQ descriptor command gets the failure response. Since PF will
> handle them one by one, and send back the response for each.
> 
> If not wait for the buffer message response until timeout to drain out the
> virtchnl command queue, it will cause the next AdminQ command with buffer to
> get the stall buffer response from previous.
> 
> Fixes: daa714d55c72 ("net/ice: handle AdminQ command by DCF")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Haiyue Wang <haiyue.wang@intel.com>

Acked-by: Qi Zhang <qi.z.zhang@intel.com>

Applied to dpdk-next-net-intel.

Thanks
Qi

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-01-22  2:38 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <220210121141804.83855-1-haiyue.wang@intel.com>
2021-01-21 14:23 ` [dpdk-dev] [PATCH v2] net/ice: drain out DCF AdminQ command queue Haiyue Wang
2021-01-21 17:31 ` [dpdk-dev] [PATCH v3] " Haiyue Wang
2021-01-22  2:38   ` Zhang, Qi Z

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror http://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ http://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git