From: Steve Yang <stevex.yang@intel.com>
To: dev@dpdk.org
Cc: wenzhuo.lu@intel.com, xiaoyun.li@intel.com,
bernard.iremonger@intel.com, thomas@monjalon.net,
ferruh.yigit@intel.com, andrew.rybchenko@oktetlabs.ru,
stevex.yang@intel.com, qiming.yang@intel.com
Subject: [dpdk-dev] [PATCH v3 0/3] fix 'max-pkt-len' errors
Date: Fri, 22 Jan 2021 09:01:07 +0000 [thread overview]
Message-ID: <20210122090110.50453-1-stevex.yang@intel.com> (raw)
In-Reply-To: <20201223085152.20866-1-stevex.yang@intel.com>
Here fixed 3 issues for 'max-pkt-len':
1. When cmdline option '--max-pkt-len' set the value less then
'1500 + overhead', the app/testpmd will force to resize the 'max-pkt-len'
to '1500 + overhead'. However, the user really want to configure
'max-pkt-len' to a specified value (< 1500 + overhead);
2. If the large value of '--max-pkt-len' gave (e.g.: 8000), and user want to
reset the value to a small one (e.g.: 1400), it will became invalid due to
JUMBO_FRAME offload state doesn't change before port started;
3. When rx/tx queue offloads capabilities aren't specified, the rx/tx queue
setup will be failed once the port offloads changed.
---
v3:
* rebased code to latest;
* splited to 3 commits;
v2:
* moved the update logic to 'rxtx_port_config';
* added the 'tx_conf' part;
* optimized the 'default' assignment;
---
Steve Yang (3):
ethdev: fix MTU doesn't update when jumbo frame disabled
app/testpmd: fix max-pkt-len option invalid
app/testpmd: fix dynamic config error
app/test-pmd/cmdline.c | 1 +
app/test-pmd/parameters.c | 1 +
app/test-pmd/testpmd.c | 59 +++++++++++++++++++++++-----------
app/test-pmd/testpmd.h | 2 ++
lib/librte_ethdev/rte_ethdev.c | 8 ++---
5 files changed, 48 insertions(+), 23 deletions(-)
--
2.17.1
next prev parent reply other threads:[~2021-01-22 9:04 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-22 8:13 [dpdk-dev] [PATCH v1] app/testpmd: fix dynamic config error for max-pkt-len Steve Yang
2020-12-23 2:27 ` Li, Xiaoyun
2020-12-23 8:51 ` [dpdk-dev] [PATCH v2] app/testpmd: fix dynamic config error Steve Yang
2020-12-23 9:00 ` Li, Xiaoyun
2021-01-13 8:13 ` Chen, BoX C
2021-01-19 15:44 ` Ferruh Yigit
2021-01-22 9:01 ` Steve Yang [this message]
2021-01-22 9:01 ` [dpdk-dev] [PATCH v3 1/3] ethdev: fix MTU doesn't update when jumbo frame disabled Steve Yang
2021-01-25 7:12 ` Huisong Li
[not found] ` <DM6PR11MB43628A600BAAEC75FFF1343BF9BD9@DM6PR11MB4362.namprd11.prod.outlook.com>
2021-01-25 12:38 ` Ferruh Yigit
2021-01-22 9:01 ` [dpdk-dev] [PATCH v3 2/3] app/testpmd: fix max-pkt-len option invalid Steve Yang
2021-01-22 9:01 ` [dpdk-dev] [PATCH v3 3/3] app/testpmd: fix dynamic config error Steve Yang
2021-01-22 17:04 ` Ferruh Yigit
2021-01-22 17:15 ` Ferruh Yigit
2021-01-25 8:32 ` [dpdk-dev] [PATCH v4 0/2] fix 'max-pkt-len' errors Steve Yang
2021-01-25 8:32 ` [dpdk-dev] [PATCH v4 1/2] ethdev: fix MTU doesn't update when jumbo frame disabled Steve Yang
2021-01-25 12:41 ` Ferruh Yigit
2021-01-25 8:32 ` [dpdk-dev] [PATCH v4 2/2] app/testpmd: fix max-pkt-len option invalid Steve Yang
2021-01-25 14:45 ` Ferruh Yigit
2021-01-25 15:46 ` Lance Richardson
2021-01-25 17:57 ` Ferruh Yigit
2021-01-25 18:15 ` [dpdk-dev] [PATCH v5] app/testpmd: fix setting maximum packet length Ferruh Yigit
2021-01-25 19:41 ` Lance Richardson
2021-01-26 0:44 ` Ferruh Yigit
2021-01-26 3:22 ` Lance Richardson
2021-01-26 3:45 ` Lance Richardson
2021-01-26 7:54 ` Li, Xiaoyun
2021-01-26 11:01 ` Ferruh Yigit
2021-01-28 21:36 ` Lance Richardson
2021-01-28 22:12 ` [dpdk-dev] [dpdk-stable] " Ferruh Yigit
2021-01-26 9:02 ` [dpdk-dev] " Wisam Monther
2021-01-27 3:04 ` Li, Xiaoyun
2021-01-28 1:57 ` Chen, BoX C
2021-01-28 9:18 ` Wisam Monther
2021-01-28 9:26 ` Ferruh Yigit
2021-01-28 11:08 ` Wisam Monther
2021-01-28 12:07 ` [dpdk-dev] [PATCH v6] " Ferruh Yigit
2021-01-29 9:34 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210122090110.50453-1-stevex.yang@intel.com \
--to=stevex.yang@intel.com \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=bernard.iremonger@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=qiming.yang@intel.com \
--cc=thomas@monjalon.net \
--cc=wenzhuo.lu@intel.com \
--cc=xiaoyun.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).