From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 81671A0A0A; Fri, 22 Jan 2021 10:04:51 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0C23B140DE5; Fri, 22 Jan 2021 10:04:42 +0100 (CET) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by mails.dpdk.org (Postfix) with ESMTP id 626E5140DE5 for ; Fri, 22 Jan 2021 10:04:40 +0100 (CET) IronPort-SDR: kLXVA+/6v0VSAjy0IefP4XziuJcR4sTNZ+qoaaBoT5Vgf1j5aQ3Um+aPrDGOuufkfqU9tKnPCe CMQewmaT8RFA== X-IronPort-AV: E=McAfee;i="6000,8403,9871"; a="240962318" X-IronPort-AV: E=Sophos;i="5.79,366,1602572400"; d="scan'208";a="240962318" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Jan 2021 01:04:40 -0800 IronPort-SDR: JnokwB9fy2rS0C7PXQP+ny313kSNaOfopHMwY9mTcTK0pr7Rtui96LUYBL6zsCksOdYm0+TSC/ jKqXTFmJ9OBg== X-IronPort-AV: E=Sophos;i="5.79,366,1602572400"; d="scan'208";a="427910777" Received: from intel-npg-odc-srv01.cd.intel.com ([10.240.178.136]) by orsmga001-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Jan 2021 01:04:37 -0800 From: Steve Yang To: dev@dpdk.org Cc: wenzhuo.lu@intel.com, xiaoyun.li@intel.com, bernard.iremonger@intel.com, thomas@monjalon.net, ferruh.yigit@intel.com, andrew.rybchenko@oktetlabs.ru, stevex.yang@intel.com, qiming.yang@intel.com Date: Fri, 22 Jan 2021 09:01:10 +0000 Message-Id: <20210122090110.50453-4-stevex.yang@intel.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20210122090110.50453-1-stevex.yang@intel.com> References: <20201223085152.20866-1-stevex.yang@intel.com> <20210122090110.50453-1-stevex.yang@intel.com> Subject: [dpdk-dev] [PATCH v3 3/3] app/testpmd: fix dynamic config error X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" The offloads of 'tx/rx_conf' didn't keep up with the corresponding offloads of 'dev_conf' if rx queue capability was 0, it would cause the configuration invalid. For example: Configuring 'max-pkt-len' would change 'rx_offloads' in dev_conf while rx_conf.offloads of each queue still kept the old value. It would cause the failure of offloads check in 'rte_eth_rx_queue_setup'. This patch applied tx/rx offloads configuration for each queue once it changed and corresponding tx/rx queue capability was 0. Fixes: 5e91aeef218c ("app/testpmd: fix offload flags after port config") Signed-off-by: Steve Yang --- app/test-pmd/testpmd.c | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c index a2c9aad960..8307c7f9e9 100644 --- a/app/test-pmd/testpmd.c +++ b/app/test-pmd/testpmd.c @@ -3296,7 +3296,11 @@ rxtx_port_config(struct rte_port *port) for (qid = 0; qid < nb_rxq; qid++) { offloads = port->rx_conf[qid].offloads; port->rx_conf[qid] = port->dev_info.default_rxconf; - if (offloads != 0) + if (port->dev_info.rx_queue_offload_capa == 0 && + offloads != port->dev_conf.rxmode.offloads) + port->rx_conf[qid].offloads = + port->dev_conf.rxmode.offloads; + else if (offloads != 0) port->rx_conf[qid].offloads = offloads; /* Check if any Rx parameters have been passed */ @@ -3321,7 +3325,11 @@ rxtx_port_config(struct rte_port *port) for (qid = 0; qid < nb_txq; qid++) { offloads = port->tx_conf[qid].offloads; port->tx_conf[qid] = port->dev_info.default_txconf; - if (offloads != 0) + if (port->dev_info.tx_queue_offload_capa == 0 && + offloads != port->dev_conf.txmode.offloads) + port->tx_conf[qid].offloads = + port->dev_conf.txmode.offloads; + else if (offloads != 0) port->tx_conf[qid].offloads = offloads; /* Check if any Tx parameters have been passed */ -- 2.17.1