From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 58CB5A0A0A; Fri, 22 Jan 2021 23:24:08 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 33CA21411BB; Fri, 22 Jan 2021 23:24:08 +0100 (CET) Received: from mail-lf1-f41.google.com (mail-lf1-f41.google.com [209.85.167.41]) by mails.dpdk.org (Postfix) with ESMTP id B44F41411B3 for ; Fri, 22 Jan 2021 23:24:06 +0100 (CET) Received: by mail-lf1-f41.google.com with SMTP id o17so9700623lfg.4 for ; Fri, 22 Jan 2021 14:24:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=PPgQdgdTWeMVhD5geV6tHmqHpP3aWxZlgZQ1NLqRtoM=; b=Jj0smW9/ER8ObR2AOAxVuWmgG4vIDl9StMNHmd0cJ8SVmxRiPECeIV9QGpUFrCZ0Ct +eZ4ogHwBZZNZfSHzWluJBwpMFxqxXs2g89RgR2/v9L7wjqh+CkVzhIpHSwS1K64kham juHvSbOcd3WlqJC01Dk/cs/Q0+ZRX9mjAZUC5pniMEgNCe1zUsR/kuKlXgp42bnlJK79 qL3cBUTVue7LpsuOYQx7GMM3pyFBO3xw5Boy08eC1icyPFZ6fMHOMWFIKpwEgB7U4AoK R1UtbO42/PNhHJFYc1eybWqLtPFm/1lIhiKsni2BRFWUZBwMAdm2XtVYK2sOZ4vBLdnb YqWA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=PPgQdgdTWeMVhD5geV6tHmqHpP3aWxZlgZQ1NLqRtoM=; b=GlSlitoigBTgE7bQF0bDIbYoErXDNN/RbdULsZ4YNR8pFVI7bVQaHkJn1usQRoD+No +2PKCRc28yGLI2etK7Ntr/im9SjtvBgR33pnFmxJPEH8fxu6YS+83/p1ut0MS3+OYIIa 5zQlt8VPGqXIPwI/DrrFXCcJxRgpq+dYk5NVE5v1toQQNsKfL/TxdCJNM8W4MYGgb+gK mg6eEZW3nCNbiA4+W60E2u+TmM49D9jFBCtpV3k/+8LPeCOTzpbYB57tzaXY6VUqUP9e s76bTW5+CD6LsrRZstqN95qNTXaN6LpN9pU2wShFE2EMTiOelvqKDsjBd0PlPtH/ukaE ye+w== X-Gm-Message-State: AOAM533nsmTtSgRBy+8vn52QMvW3o83jkWzckPXTE67uYsro+ALsi2dT 7dgL8bILdcl5CEGKjQkZihE= X-Google-Smtp-Source: ABdhPJyo1DlAd8JOM6BB+R1fDcA1XHAikkjm581CW9qgoxchA9x0Pqbcs4zGz8ajl8rCDEnN6C4zIg== X-Received: by 2002:a19:f203:: with SMTP id q3mr1103647lfh.166.1611354246144; Fri, 22 Jan 2021 14:24:06 -0800 (PST) Received: from sovereign (broadband-37-110-65-23.ip.moscow.rt.ru. [37.110.65.23]) by smtp.gmail.com with ESMTPSA id m26sm1113981ljj.134.2021.01.22.14.24.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 22 Jan 2021 14:24:05 -0800 (PST) Date: Sat, 23 Jan 2021 01:24:03 +0300 From: Dmitry Kozlyuk To: Thomas Monjalon Cc: dev@dpdk.org, Stephen Hemminger , David Marchand , Maxime Coquelin , Aaron Conole , Bruce Richardson , ferruh.yigit@intel.com, ray.kinsella@intel.com Message-ID: <20210123012403.1bdb35d0@sovereign> In-Reply-To: <5444857.Q0qPc8oPp2@thomas> References: <20201014183136.22239-1-dmitry.kozliuk@gmail.com> <2534344.1dmFBEvUxf@thomas> <20210122233116.31d1538b@sovereign> <5444857.Q0qPc8oPp2@thomas> X-Mailer: Claws Mail 3.17.6 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v8 2/3] build: use Python pmdinfogen X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, 22 Jan 2021 21:57:15 +0100, Thomas Monjalon wrote: > 22/01/2021 21:31, Dmitry Kozlyuk: > > On Wed, 20 Jan 2021 11:24:21 +0100, Thomas Monjalon wrote: > > > 20/01/2021 08:23, Dmitry Kozlyuk: > > > > On Wed, 20 Jan 2021 01:05:59 +0100, Thomas Monjalon wrote: > > > > > This is now the right timeframe to introduce this change > > > > > with the new Python module dependency. > > > > > Unfortunately, the ABI check is returning an issue: > > > > > > > > > > 'const char mlx5_common_pci_pmd_info[62]' was changed > > > > > to 'const char mlx5_common_pci_pmd_info[60]' at rte_common_mlx5.pmd.c > > > > > > > > Will investigate and fix ASAP. > > > > Now that I think of it: strings like this change every time new PCI IDs are > > added to a PMD, but AFAIK adding PCI IDs is not considered an ABI breakage, > > is it? One example is 28c9a7d7b48e ("net/mlx5: add ConnectX-6 Lx device ID") > > added 2020-07-08, i.e. clearly outside of ABI change window. > > You're right. > > > "xxx_pmd_info" changes are due to JSON formatting (new is more canonical), > > which can be worked around easily, if the above is wrong. > > If the new format is better, please keep it. > What we need is an exception for the pmdinfo symbols > in the file devtools/libabigail.abignore. > You can probably use a regex for these symbols. This would allow real breakages to pass ABI check, abidiff doesn't analyze variable content and it's not easy to compare. Maybe later a script can be added that checks lines with RTE_DEVICE_IN in patches. There are at most 32 of 5494 relevant commits between 19.11 and 20.11, though. To verify there are no meaningful changes I ensured empty diff between results of the following command for "main" and the branch: find build/drivers -name '*.so' -exec usertools/dpdk-pmdinfo.py